> This file is generated from something in rtems-central. This was at the > top of the file: > > * This file is part of the RTEMS quality process and was automatically > * generated. If you find something that needs to be fixed or > * worded better please post a report or patch to an RTEMS mailing list
No, problem. I can fix this before I check in the patch. re: this do you need me to change it to something? On Wed, 14 Feb 2024 at 09:28, Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > > > On 14.02.24 15:18, Joel Sherrill wrote: > > I'm cc'ing Sebastian because you edited the text in a generated file. He > > should be able to point us to the right place to fix it. > > > > On Mon, Feb 12, 2024 at 8:26 PM <zakthertems...@gmail.com > > <mailto:zakthertems...@gmail.com>> wrote: > > > > From: Zack leung <z.liang...@gmail.com <mailto:z.liang...@gmail.com > >> > > > > diff --git a/cpukit/doxygen/appl-config.h > b/cpukit/doxygen/appl-config.h > > index bd7cde628f..d480eb3971 100644 > > --- a/cpukit/doxygen/appl-config.h > > +++ b/cpukit/doxygen/appl-config.h > > @@ -3312,7 +3312,7 @@ > > * @parblock > > * The following constraints apply to this configuration option: > > * > > - * * The value of the configuration option shall be greater than or > > equal to > > + * * The value of the configuration option shall be greater than > > * zero. > > > > > > > > This file is generated from something in rtems-central. This was at the > > top of the file: > > > > * This file is part of the RTEMS quality process and was automatically > > * generated. If you find something that needs to be fixed or > > * worded better please post a report or patch to an RTEMS mailing list > > No, problem. I can fix this before I check in the patch. > > > > > * > > * * The value of the configuration option shall be less than or > > equal to <a > > diff --git a/cpukit/include/rtems/confdefs/clock.h > > b/cpukit/include/rtems/confdefs/clock.h > > index 26519cc70b..d0d7c453bc 100644 > > --- a/cpukit/include/rtems/confdefs/clock.h > > +++ b/cpukit/include/rtems/confdefs/clock.h > > @@ -74,6 +74,10 @@ > > #error "CONFIGURE_MICROSECONDS_PER_TICK must be positive" > > #endif > > > > +#if CONFIGURE_TICKS_PER_TIMESLICE <= 0 && > > defined(CONFIGURE_TICKS_PER_TIMESLICE) > > + #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero" > > +#endif > > + > > > > > > This is modifying the right file but I think it is safer to check that > > it is defined > > before checking its value. > > Yes, the defined() check should be first. > > -- > embedded brains GmbH & Co. KG > Herr Sebastian HUBER > Dornierstr. 4 > 82178 Puchheim > Germany > email: sebastian.hu...@embedded-brains.de > phone: +49-89-18 94 741 - 16 > fax: +49-89-18 94 741 - 08 > > Registergericht: Amtsgericht München > Registernummer: HRB 157899 > Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler > Unsere Datenschutzerklärung finden Sie hier: > https://embedded-brains.de/datenschutzerklaerung/ >
_______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
