[PATCH] bsps/irq: bsp_interrupt_facility_initialize()

2021-07-27 Thread Sebastian Huber
Do not return a status code in bsp_interrupt_facility_initialize() since this leads to unreachable code in bsp_interrupt_initialize(). Use RTEMS_DEBUG assertions in bsp_interrupt_facility_initialize() if necessary. --- bsps/arm/beagle/irq/irq.c | 4 +-- bsps/arm/csb336/irq/irq.c

[PATCH rtems-libbsd.nfs 3/4] sys/netinet/libalias: Fix symbols clashes

2021-07-27 Thread chrisj
From: Chris Johns Update #4475 --- freebsd/sys/netinet/libalias/alias_cuseeme.c | 3 +++ freebsd/sys/netinet/libalias/alias_dummy.c | 4 +++- freebsd/sys/netinet/libalias/alias_ftp.c | 3 +++ freebsd/sys/netinet/libalias/alias_irc.c | 3 +++ freebsd/sys/netinet/libalias/alias_nbt.c

[PATCH rtems-libbsd.nfs 2/4] waf: Fix clashing symbols in the user land symbols

2021-07-27 Thread chrisj
From: Chris Johns Update #4475 --- libbsd.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libbsd.py b/libbsd.py index 09a1fbc4..2318e470 100644 --- a/libbsd.py +++ b/libbsd.py @@ -5019,7 +5019,7 @@ class dhcpcd(builder.Module): 'dhcpcd/compat/pselect.c',

[PATCH rtems-libbsd.nfs 4/4] kern-symbols: Add symbols from the everything build set

2021-07-27 Thread chrisj
From: Chris Johns - Minor fix to rtems-kern-symbols Update #4475 --- rtems-kern-symbols| 2 +- .../machine/rtems-bsd-kernel-namespace.h | 127 ++ 2 files changed, 128 insertions(+), 1 deletion(-) diff --git a/rtems-kern-symbols b/rtems-kern-sy

[PATCH] score: Remove _Internal_errors_What_happened

2021-07-27 Thread Sebastian Huber
Users have access to the fatal error source and code though the fatal error extension. The user-specific fatal error handling should be done in statically initialized fatal error handlers. The _Internal_errors_What_happened was updated after the fatal error extension. In addition, there was no AP

libbsd: Add kerel trace support

2021-07-27 Thread chrisj
This patch set addis trace support, a lockmgr and proc0 to libbsd. The patch set is part of adding NFSv4 to libbsd. This involves adding VFS and refactoring the syscall interfaces and tracing is an important part of the long term maintenance of these features. Part of this is adding a proc0. RTEM

[PATCH rtems-libbsd 2/7] testsuite: Optionally allow all command in a shell

2021-07-27 Thread chrisj
From: Chris Johns Update #4475 --- testsuite/include/rtems/bsd/test/default-network-init.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/testsuite/include/rtems/bsd/test/default-network-init.h b/testsuite/include/rtems/bsd/test/default-network-init.h index ce1fc015..fffb739c 100644 ---

[PATCH rtems-libbsd 1/7] rtemsbsd: Catch timeout overflows

2021-07-27 Thread chrisj
From: Chris Johns Update #4475 --- rtemsbsd/rtems/rtems-kernel-timesupport.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/rtemsbsd/rtems/rtems-kernel-timesupport.c b/rtemsbsd/rtems/rtems-kernel-timesupport.c index ef14d1fa..5d290d66 100644 --- a/rtemsbsd/rtems/rtem

[PATCH rtems-libbsd 3/7] sys/kern: Add lockmgr support

2021-07-27 Thread chrisj
From: Chris Johns - See `man lockmgr` - Implement the lock_object and move the RTEMS mutex to that object - Add debug support to track the locks with gdb Update #4475 --- freebsd/sys/sys/_lock.h | 10 +- freebsd/sys/sys/_lockmgr.h| 6 + freebsd/sys

[PATCH rtems-libbsd 4/7] kern: Import kern_prot.c fnd kern_resource.c for proc0

2021-07-27 Thread chrisj
From: Chris Johns Update #4475 --- freebsd/sys/kern/kern_prot.c | 2247 ++ freebsd/sys/kern/kern_resource.c | 1539 2 files changed, 3786 insertions(+) create mode 100644 freebsd/sys/kern/kern_prot.c create mode 100644 freebsd/sys/kern/kern_

[PATCH rtems-libbsd 5/7] kern: Add a proc0

2021-07-27 Thread chrisj
From: Chris Johns - Provides the thread's proc pointer and with that access to creds Update #4475 --- freebsd/sys/kern/init_main.c | 4 +++ freebsd/sys/kern/kern_prot.c | 45 ++-- freebsd/sys/kern/kern_resource.c | 12 +++ freebsd/sys/sys/proc.h

[PATCH rtems-libbsd 6/7] kern: Import kern_ktr.c

2021-07-27 Thread chrisj
From: Chris Johns Update #4475 --- freebsd/sys/kern/kern_ktr.c | 476 1 file changed, 476 insertions(+) create mode 100644 freebsd/sys/kern/kern_ktr.c diff --git a/freebsd/sys/kern/kern_ktr.c b/freebsd/sys/kern/kern_ktr.c new file mode 100644 index

[PATCH rtems-libbsd 7/7] kern: Add kernel trace support (KTR)

2021-07-27 Thread chrisj
From: Chris Johns Update #4475 --- README.md | 9 + freebsd/sys/kern/kern_intr.c | 6 ++ freebsd/sys/kern/kern_ktr.c| 14 +++--- freebsd/sys/kern/kern_synch.c | 10 ++ freebsd/sys/kern/subr_

Re: [PATCH 1/3] rsb: Store patches in separate directories

2021-07-27 Thread Alex White
On Tue, Jul 27, 2021 at 12:46 AM Chris Johns wrote: > > On 27/7/21 3:39 pm, Sebastian Huber wrote: > > On 27/07/2021 05:30, Alex White wrote: > >> This prevents patches with the same name from conflicting and causing > >> the build to fail. > > > > Why can't the patches have a unique file name? >

Re: [PATCH rtems-libbsd 3/4] nexus-devices: Include CDC Ethernet for Beagle

2021-07-27 Thread Ahamed Husni
On Fri, Jul 16, 2021 at 1:25 AM Christian Mauderer wrote: > On 06/07/2021 19:00, Husni Faiz wrote: > > Configure bus for CDC Ethernet > > Include CDC Ethernet in Beagle BSP > > > > Signed-off-by: Husni Faiz > > --- > > rtemsbsd/include/bsp/nexus-devices.h | 5 + > > rtemsbsd/in

Re: [PATCH rtems-libbsd 3/4] nexus-devices: Include CDC Ethernet for Beagle

2021-07-27 Thread Christian Mauderer
Hello Husni, On 27/07/2021 17:04, Ahamed Husni wrote: On Fri, Jul 16, 2021 at 1:25 AM Christian Mauderer > wrote: On 06/07/2021 19:00, Husni Faiz wrote: > Configure bus for CDC Ethernet > Include CDC Ethernet in Beagle BSP > > Signed-off-by:

Re: [PATCH 3/3] rsb: Add Xilinx QEMU

2021-07-27 Thread Gedare Bloom
On Mon, Jul 26, 2021 at 9:30 PM Alex White wrote: > > --- > bare/config/devel/qemu-xilinx-1.cfg | 28 > bare/config/devel/qemu-xilinx.bset | 24 > 2 files changed, 52 insertions(+) > create mode 100644 bare/config/devel/qemu-xilinx-1.cfg >

Re: [PATCH] score: Remove _Internal_errors_What_happened

2021-07-27 Thread Gedare Bloom
Thanks, this also needs a rtems-docs/c-user/fatal-error update On Tue, Jul 27, 2021 at 2:13 AM Sebastian Huber wrote: > > Users have access to the fatal error source and code though the fatal error > extension. The user-specific fatal error handling should be done in > statically > initialized

Re: [PATCH] bsps/irq: bsp_interrupt_facility_initialize()

2021-07-27 Thread Gedare Bloom
ok On Tue, Jul 27, 2021 at 2:03 AM Sebastian Huber wrote: > > Do not return a status code in bsp_interrupt_facility_initialize() since this > leads to unreachable code in bsp_interrupt_initialize(). Use RTEMS_DEBUG > assertions in bsp_interrupt_facility_initialize() if necessary. > --- > bsps/a

Re: [PATCH rtems-libbsd 3/4] nexus-devices: Include CDC Ethernet for Beagle

2021-07-27 Thread Ahamed Husni
Hello Christian, On Wed, Jul 28, 2021 at 12:34 AM Christian Mauderer wrote: > Hello Husni, > > On 27/07/2021 17:04, Ahamed Husni wrote: > > > > > > On Fri, Jul 16, 2021 at 1:25 AM Christian Mauderer > > wrote: > > > > On 06/07/2021 19:00, Husni Faiz wrote: > >

Re: [PATCH rtems-libbsd.nfs 1/4] Implement portable kernel symbol namespace tool

2021-07-27 Thread Gedare Bloom
On Tue, Jul 27, 2021 at 2:09 AM wrote: > > From: Chris Johns > > - The script's use of sort proved to not be portable > > - No need to check the commits as symbols are only added > > - Regenerated kernel header to reset the sort order > > Update #4475 > --- > CONTRIBUTING.md

Re: [PATCH rtems-libbsd.nfs 4/4] kern-symbols: Add symbols from the everything build set

2021-07-27 Thread Gedare Bloom
squash into 1/4 if you regenerate 1 after review? On Tue, Jul 27, 2021 at 2:09 AM wrote: > > From: Chris Johns > > - Minor fix to rtems-kern-symbols > > Update #4475 > --- > rtems-kern-symbols| 2 +- > .../machine/rtems-bsd-kernel-namespace.h | 127 +++

Re: [PATCH rtems-libbsd 1/7] rtemsbsd: Catch timeout overflows

2021-07-27 Thread Gedare Bloom
On Tue, Jul 27, 2021 at 2:59 AM wrote: > > From: Chris Johns > > Update #4475 This change could probably use its own ticket. > --- > rtemsbsd/rtems/rtems-kernel-timesupport.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/rtemsbsd/rtems/rtems-kernel-timesupport.

Re: [PATCH rtems-libbsd 1/7] rtemsbsd: Catch timeout overflows

2021-07-27 Thread Chris Johns
On 28/7/21 7:38 am, Gedare Bloom wrote: > On Tue, Jul 27, 2021 at 2:59 AM wrote: >> >> From: Chris Johns >> >> Update #4475 > This change could probably use its own ticket. Without the change the RPC client fails to connect in a reliable way because the connection may time out for no real reason

[PATCH] closes #3889

2021-07-27 Thread Zacchaeus Leung
adds --- cpukit/include/rtems/posix/timer.h| 1 + cpukit/posix/src/psxtimercreate.c | 5 +- cpukit/posix/src/timergettime.c | 59 +-- testsuites/psxtests/psxtimer02/psxtimer.c | 26 ++ 4 files changed, 63 insertions(+), 28 deletions(-) dif

Re: [PATCH 1/3] rsb: Store patches in separate directories

2021-07-27 Thread Chris Johns
On 28/7/21 12:13 am, Alex White wrote: > On Tue, Jul 27, 2021 at 12:46 AM Chris Johns wrote: >> >> On 27/7/21 3:39 pm, Sebastian Huber wrote: >> > On 27/07/2021 05:30, Alex White wrote: >> >> This prevents patches with the same name from conflicting and causing >> >> the build to fail. >> > >> > W

Re: [PATCH rtems-libbsd.nfs 1/4] Implement portable kernel symbol namespace tool

2021-07-27 Thread Chris Johns
Thanks for the review ... On 28/7/21 7:16 am, Gedare Bloom wrote: > On Tue, Jul 27, 2021 at 2:09 AM wrote: >> +environment `PATH` variable or you can specify the top level path as an >> argument: >> +``` >> +$ ./rtems-kern-symbols --tools=/opt/work/rtems/6 >> +``` > > This is inconsistent with

[PATCH rtems-libbsd v2 3/4] sys/netinet/libalias: Fix symbols clashes

2021-07-27 Thread chrisj
From: Chris Johns Update #4475 --- freebsd/sys/netinet/libalias/alias_cuseeme.c | 3 +++ freebsd/sys/netinet/libalias/alias_dummy.c | 4 +++- freebsd/sys/netinet/libalias/alias_ftp.c | 3 +++ freebsd/sys/netinet/libalias/alias_irc.c | 3 +++ freebsd/sys/netinet/libalias/alias_nbt.c

[PATCH rtems-libbsd v2 2/4] waf: Fix clashing symbols in the user land symbols

2021-07-27 Thread chrisj
From: Chris Johns Update #4475 --- libbsd.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libbsd.py b/libbsd.py index 09a1fbc4..2318e470 100644 --- a/libbsd.py +++ b/libbsd.py @@ -5019,7 +5019,7 @@ class dhcpcd(builder.Module): 'dhcpcd/compat/pselect.c',

[PATCH rtems-libbsd v2 4/4] kern-symbols: Add symbols from the everything build set

2021-07-27 Thread chrisj
From: Chris Johns Update #4475 --- .../machine/rtems-bsd-kernel-namespace.h | 127 ++ 1 file changed, 127 insertions(+) diff --git a/rtemsbsd/include/machine/rtems-bsd-kernel-namespace.h b/rtemsbsd/include/machine/rtems-bsd-kernel-namespace.h index 108709ce..76e76b58 10064

Re: [PATCH rtems-libbsd v2 1/4] Implement portable kernel symbol namespace tool

2021-07-27 Thread Chris Johns
Please ignore v2, I forgot to the rebase the fixes from the review. V3 will be posted soon. On 28/7/21 11:06 am, chr...@rtems.org wrote: > From: Chris Johns > > - The script's use of sort proved to not be portable > > - No need to check the commits as symbols are only added > > - Regenerated k

[PATCH rtems-libbsd v3 2/4] waf: Fix clashing symbols in the user land symbols

2021-07-27 Thread chrisj
From: Chris Johns Update #4475 --- libbsd.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libbsd.py b/libbsd.py index 09a1fbc4..2318e470 100644 --- a/libbsd.py +++ b/libbsd.py @@ -5019,7 +5019,7 @@ class dhcpcd(builder.Module): 'dhcpcd/compat/pselect.c',

[PATCH rtems-libbsd v3 3/4] sys/netinet/libalias: Fix symbols clashes

2021-07-27 Thread chrisj
From: Chris Johns Update #4475 --- freebsd/sys/netinet/libalias/alias_cuseeme.c | 3 +++ freebsd/sys/netinet/libalias/alias_dummy.c | 4 +++- freebsd/sys/netinet/libalias/alias_ftp.c | 3 +++ freebsd/sys/netinet/libalias/alias_irc.c | 3 +++ freebsd/sys/netinet/libalias/alias_nbt.c

[PATCH rtems-libbsd v3 4/4] kern-symbols: Add symbols from the everything build set

2021-07-27 Thread chrisj
From: Chris Johns Update #4475 --- .../machine/rtems-bsd-kernel-namespace.h | 127 ++ 1 file changed, 127 insertions(+) diff --git a/rtemsbsd/include/machine/rtems-bsd-kernel-namespace.h b/rtemsbsd/include/machine/rtems-bsd-kernel-namespace.h index 108709ce..76e76b58 10064

NSFv4: LibBSD VFS and FS

2021-07-27 Thread Chris Johns
Hello, Ticket #4475 documents the addition of the FreeBSD NFS client to LibBSD. https://devel.rtems.org/ticket/4475 The change is large because the NFS client uses FreeBSD's VFS and this in turn requires LibBSD use FreeBSD's file descriptor and file support. Breaking this patch down into section

Re: [PATCH rtems-libbsd 1/7] rtemsbsd: Catch timeout overflows

2021-07-27 Thread Sebastian Huber
On 28/07/2021 00:53, Chris Johns wrote: On 28/7/21 7:38 am, Gedare Bloom wrote: On Tue, Jul 27, 2021 at 2:59 AM wrote: From: Chris Johns Update #4475 This change could probably use its own ticket. Without the change the RPC client fails to connect in a reliable way because the connection ma

Re: [PATCH rtems-libbsd 3/7] sys/kern: Add lockmgr support

2021-07-27 Thread Sebastian Huber
On 27/07/2021 10:58, chr...@rtems.org wrote: From: Chris Johns - See `man lockmgr` - Implement the lock_object and move the RTEMS mutex to that object - Add debug support to track the locks with gdb Update #4475 --- freebsd/sys/sys/_lock.h | 10 +- freebsd/sys/sys

Re: [PATCH rtems-libbsd 7/7] kern: Add kernel trace support (KTR)

2021-07-27 Thread Sebastian Huber
On 27/07/2021 10:58, chr...@rtems.org wrote: diff --git a/rtemsbsd/rtems/rtems-kernel-thread.c b/rtemsbsd/rtems/rtems-kernel-thread.c index 3e1e44b9..49ec6df7 100644 --- a/rtemsbsd/rtems/rtems-kernel-thread.c +++ b/rtemsbsd/rtems/rtems-kernel-thread.c @@ -260,6 +260,9 @@ rtems_bsd_thread_start(s

Re: [PATCH rtems-libbsd v3 2/4] waf: Fix clashing symbols in the user land symbols

2021-07-27 Thread Sebastian Huber
On 28/07/2021 04:53, chr...@rtems.org wrote: From: Chris Johns Update #4475 --- libbsd.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libbsd.py b/libbsd.py index 09a1fbc4..2318e470 100644 --- a/libbsd.py +++ b/libbsd.py @@ -5019,7 +5019,7 @@ class dhcpcd(builder.Modu

Re: [PATCH rtems-libbsd v3 2/4] waf: Fix clashing symbols in the user land symbols

2021-07-27 Thread Chris Johns
On 28/7/21 4:29 pm, Sebastian Huber wrote: > On 28/07/2021 04:53, chr...@rtems.org wrote: >> From: Chris Johns >> >> Update #4475 >> --- >>   libbsd.py | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libbsd.py b/libbsd.py >> index 09a1fbc4..2318e470 100644 >> --- a/libb

Re: [PATCH rtems-libbsd v3 1/4] Implement portable kernel symbol namespace tool

2021-07-27 Thread Sebastian Huber
On 28/07/2021 04:53, chr...@rtems.org wrote: -#definezy7_slcr_postload_pl _bsd_zy7_slcr_postload_pl +#define AES_CBC_MAC_Final _bsd_AES_CBC_MAC_Final The FreeBSD coding style has a tab after the #define. This is why it was where. -- embedded brains GmbH Herr Sebastian HUBER Dornierst

Re: [PATCH rtems-libbsd v3 1/4] Implement portable kernel symbol namespace tool

2021-07-27 Thread Chris Johns
On 28/7/21 4:34 pm, Sebastian Huber wrote: > On 28/07/2021 04:53, chr...@rtems.org wrote: >> -#define    zy7_slcr_postload_pl _bsd_zy7_slcr_postload_pl >> +#define AES_CBC_MAC_Final _bsd_AES_CBC_MAC_Final > > The FreeBSD coding style has a tab after the #define. This is why it was > where. > Do

Re: [PATCH rtems-libbsd v3 1/4] Implement portable kernel symbol namespace tool

2021-07-27 Thread Sebastian Huber
On 28/07/2021 04:53, chr...@rtems.org wrote: +for sym in self.output['symbols']: +out += ['#define %s_bsd_%s' % (sym, sym)] If you add a tab after the #define, then the output is in line with the FreeBSD style and you have a lot less changes in the generated file compared

Re: [PATCH rtems-libbsd 1/7] rtemsbsd: Catch timeout overflows

2021-07-27 Thread Chris Johns
On 28/7/21 4:03 pm, Sebastian Huber wrote: > On 28/07/2021 00:53, Chris Johns wrote: >> On 28/7/21 7:38 am, Gedare Bloom wrote: >>> On Tue, Jul 27, 2021 at 2:59 AM  wrote: From: Chris Johns Update #4475 >>> This change could probably use its own ticket. >> Without the change the RPC

Re: [PATCH rtems-libbsd 1/7] rtemsbsd: Catch timeout overflows

2021-07-27 Thread Sebastian Huber
On 28/07/2021 08:43, Chris Johns wrote: Why don't we use the FreeBSD implementation one-to-one: freebsd-org/sys/kern/kern_clock.c I am fixing the code that exists. I have no idea why kern_clock.c was not ported in the first place. I will not be porting the clock code at this point in time, tha

Re: [PATCH rtems-libbsd 3/4] nexus-devices: Include CDC Ethernet for Beagle

2021-07-27 Thread Christian MAUDERER
Hello Husni, Am 27.07.21 um 22:37 schrieb Ahamed Husni: Hello Christian, On Wed, Jul 28, 2021 at 12:34 AM Christian Mauderer > wrote: Hello Husni, On 27/07/2021 17:04, Ahamed Husni wrote: > > > On Fri, Jul 16, 2021 at 1:25 AM Christian Mauder

Re: [PATCH rtems-libbsd v3 1/4] Implement portable kernel symbol namespace tool

2021-07-27 Thread Chris Johns
On 28/7/21 4:38 pm, Sebastian Huber wrote: > On 28/07/2021 04:53, chr...@rtems.org wrote: >> +    for sym in self.output['symbols']: >> +    out += ['#define %s_bsd_%s' % (sym, sym)] > > If you add a tab after the #define, then the output is in line with the > FreeBSD > style and you

Re: [PATCH rtems-libbsd 7/7] kern: Add kernel trace support (KTR)

2021-07-27 Thread Chris Johns
On 28/7/21 4:27 pm, Sebastian Huber wrote: > On 27/07/2021 10:58, chr...@rtems.org wrote: >> diff --git a/rtemsbsd/rtems/rtems-kernel-thread.c >> b/rtemsbsd/rtems/rtems-kernel-thread.c >> index 3e1e44b9..49ec6df7 100644 >> --- a/rtemsbsd/rtems/rtems-kernel-thread.c >> +++ b/rtemsbsd/rtems/rtems-ker

Re: [PATCH rtems-libbsd 7/7] kern: Add kernel trace support (KTR)

2021-07-27 Thread Sebastian Huber
On 28/07/2021 08:53, Chris Johns wrote: On 28/7/21 4:27 pm, Sebastian Huber wrote: On 27/07/2021 10:58,chr...@rtems.org wrote: diff --git a/rtemsbsd/rtems/rtems-kernel-thread.c b/rtemsbsd/rtems/rtems-kernel-thread.c index 3e1e44b9..49ec6df7 100644 --- a/rtemsbsd/rtems/rtems-kernel-thread.c +++