RE: [PATCH 0/1] grlib/genirq: Issue when enabling/disabling interrupt

2021-04-15 Thread Jan.Sommer
Does someone have any objections to this patch? I would like to push it to master and 5. Or should we reach out to someone at Gaisler to check if it is ok? Best regards, Jan > -Original Message- > From: devel On Behalf Of > gabriel.moy...@dlr.de > Sent: Tuesday, April 13, 2021 10:09

Re: [PATCH 0/1] grlib/genirq: Issue when enabling/disabling interrupt

2021-04-15 Thread Daniel Hellstrom
Hi Jan, I think it is a correct analysis of the bad return value, when using shared interrupt routines on the same interrupt source. I'm fine with the patch, maybe it could have been simplified, like this: +++ b/bsps/shared/grlib/irq/genirq.c @@ -188,8 +188,8 @@ static int genirq_set_active(

[PATCH v2 0/1] grlib/genirq: Issue when enabling/disabling interrupt

2021-04-15 Thread Moyano, Gabriel
Here the new patch as proposed by Daniel (thx btw). It closes ticket 4385 (https://devel.rtems.org/ticket/4385#ticket). Moyano, Gabriel (1): grlib/genirq: Taking into account that it could be more than one ISR enabled/disabled bsps/shared/grlib/irq/genirq.c | 4 ++-- 1 file changed, 2 ins

[PATCH v2 1/1] grlib/genirq: Taking into account that it could be more than one ISR enabled/disabled

2021-04-15 Thread Moyano, Gabriel
--- bsps/shared/grlib/irq/genirq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bsps/shared/grlib/irq/genirq.c b/bsps/shared/grlib/irq/genirq.c index 285416b0d3..ca80445c70 100644 --- a/bsps/shared/grlib/irq/genirq.c +++ b/bsps/shared/grlib/irq/genirq.c @@ -188,8 +188,8

Re: [PATCH v2 1/1] grlib/genirq: Taking into account that it could be more than one ISR enabled/disabled

2021-04-15 Thread Daniel Hellstrom
Looks good. Thanks, Daniel On 2021-04-15 11:52, Moyano, Gabriel wrote: --- bsps/shared/grlib/irq/genirq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bsps/shared/grlib/irq/genirq.c b/bsps/shared/grlib/irq/genirq.c index 285416b0d3..ca80445c70 100644 --- a

Re: [PATCH v2 0/2] powerpc/shared/console: Console baud rate fixes

2021-04-15 Thread Joel Sherrill
No one has posted publicly about these in 5 days and asking privately a group of mvme users, I only got feedback from Heinz == I can only note that we have some (many) users who would like to stay at the fixed 9600 baud because that is what they have been used to since "forever”. I had

Re: [PATCH rtems-libbsd 2/2] st-sdmmc: Handle short not cache aligned buffers

2021-04-15 Thread Christian MAUDERER
Hello Gedare, thanks for the review. Best regards Christian Am 14.04.21 um 18:31 schrieb Gedare Bloom: These two look good if no one complains go ahead. (I'm not 100% on this libbsd stuff yet.) On Wed, Apr 14, 2021 at 1:21 AM Christian Mauderer wrote: Possible data sources for SD driver:

Re: [PATCH rtems-net-legacy v3] netlegacy: Use os.path instead of hardcoded Unix like path

2021-04-15 Thread Vijay Kumar Banerjee
On Wed, Apr 14, 2021 at 10:22 PM Vijay Kumar Banerjee wrote: > > On Wed, Apr 14, 2021 at 8:40 PM Chris Johns wrote: > > > > On 15/4/21 5:22 am, Vijay Kumar Banerjee wrote: > > > On Wed, Apr 14, 2021 at 1:10 PM Gedare Bloom wrote: > > >> > > >> On Wed, Apr 14, 2021 at 12:36 PM Vijay Kumar Banerje

Re: [PATCH rtems-net-legacy v3] netlegacy: Use os.path instead of hardcoded Unix like path

2021-04-15 Thread Gedare Bloom
On Thu, Apr 15, 2021 at 10:49 AM Vijay Kumar Banerjee wrote: > > > > On Wed, Apr 14, 2021 at 10:22 PM Vijay Kumar Banerjee wrote: > > > > On Wed, Apr 14, 2021 at 8:40 PM Chris Johns wrote: > > > > > > On 15/4/21 5:22 am, Vijay Kumar Banerjee wrote: > > > > On Wed, Apr 14, 2021 at 1:10 PM Gedare

Re: [PATCH rtems-net-legacy v3] netlegacy: Use os.path instead of hardcoded Unix like path

2021-04-15 Thread Vijay Kumar Banerjee
On Thu, Apr 15, 2021 at 11:36 AM Gedare Bloom wrote: > > On Thu, Apr 15, 2021 at 10:49 AM Vijay Kumar Banerjee wrote: > > > > > > > > On Wed, Apr 14, 2021 at 10:22 PM Vijay Kumar Banerjee > > wrote: > > > > > > On Wed, Apr 14, 2021 at 8:40 PM Chris Johns wrote: > > > > > > > > On 15/4/21 5:22

Re: [PATCH rtems-net-legacy v3] nfsclient: Build nfsclient from the top level netlegacy script

2021-04-15 Thread Vijay Kumar Banerjee
On Wed, Apr 14, 2021 at 12:20 AM Gedare Bloom wrote: > > looks good, other than the comment I made on the other patch about '${PREFIX}' > Pushed, thanks. > On Wed, Apr 14, 2021 at 12:01 AM Vijay Kumar Banerjee wrote: > > > > Ping :) > > > > On Wed, Apr 7, 2021 at 10:51 AM Vijay Kumar Banerjee

Re: [PATCH rtems-net-legacy] bsp_drivers: Use os.path for compatibility with non Unix host

2021-04-15 Thread Vijay Kumar Banerjee
It has been less than 3 days, still pinging it. :) On Tue, Apr 13, 2021 at 11:49 PM Vijay Kumar Banerjee wrote: > > --- > bsp_drivers.py | 26 +- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/bsp_drivers.py b/bsp_drivers.py > index 3ca10c6..4a07847

Re: [PATCH rtems-net-legacy] netlegacy: Remove telnetd build

2021-04-15 Thread Vijay Kumar Banerjee
Telnet patches already reverted. Is this good to go? On Tue, Apr 13, 2021 at 11:49 PM Vijay Kumar Banerjee wrote: > > --- > netlegacy.py | 13 ++--- > testsuites/telnetd01/wscript | 5 + > 2 files changed, 7 insertions(+), 11 deletions(-) > > diff --git a/netlegacy.p

Re: [PATCH rtems-net-legacy] bsp_drivers: Use os.path for compatibility with non Unix host

2021-04-15 Thread Gedare Bloom
On Thu, Apr 15, 2021 at 12:01 PM Vijay Kumar Banerjee wrote: > > It has been less than 3 days, still pinging it. :) > > On Tue, Apr 13, 2021 at 11:49 PM Vijay Kumar Banerjee wrote: > > > > --- > > bsp_drivers.py | 26 +- > > 1 file changed, 13 insertions(+), 13 deletions(

Re: [PATCH rtems-net-legacy] netlegacy: Remove telnetd build

2021-04-15 Thread Gedare Bloom
On Thu, Apr 15, 2021 at 12:01 PM Vijay Kumar Banerjee wrote: > > Telnet patches already reverted. Is this good to go? > Yes, except... > On Tue, Apr 13, 2021 at 11:49 PM Vijay Kumar Banerjee wrote: > > > > --- > > netlegacy.py | 13 ++--- > > testsuites/telnetd01/wscript

Re: [PATCH rtems-net-legacy] bsp_drivers: Use os.path for compatibility with non Unix host

2021-04-15 Thread Vijay Kumar Banerjee
On Thu, Apr 15, 2021 at 2:46 PM Gedare Bloom wrote: > > On Thu, Apr 15, 2021 at 12:01 PM Vijay Kumar Banerjee wrote: > > > > It has been less than 3 days, still pinging it. :) > > > > On Tue, Apr 13, 2021 at 11:49 PM Vijay Kumar Banerjee > > wrote: > > > > > > --- > > > bsp_drivers.py | 26 +++

Re: [PATCH rtems-net-legacy] bsp_drivers: Use os.path for compatibility with non Unix host

2021-04-15 Thread Gedare Bloom
On Thu, Apr 15, 2021 at 2:49 PM Vijay Kumar Banerjee wrote: > > On Thu, Apr 15, 2021 at 2:46 PM Gedare Bloom wrote: > > > > On Thu, Apr 15, 2021 at 12:01 PM Vijay Kumar Banerjee > > wrote: > > > > > > It has been less than 3 days, still pinging it. :) > > > > > > On Tue, Apr 13, 2021 at 11:49 P

Re: [PATCH rtems-net-legacy] netlegacy: Remove telnetd build

2021-04-15 Thread Vijay Kumar Banerjee
On Thu, Apr 15, 2021 at 2:48 PM Gedare Bloom wrote: > > On Thu, Apr 15, 2021 at 12:01 PM Vijay Kumar Banerjee wrote: > > > > Telnet patches already reverted. Is this good to go? > > > Yes, except... > > > On Tue, Apr 13, 2021 at 11:49 PM Vijay Kumar Banerjee > > wrote: > > > > > > --- > > > ne

OS Neutrality in Python Development Guidelines?

2021-04-15 Thread Gedare Bloom
Hello all, To revisit a little bit of a controversial subject :) The Python Development Guidelines have been in place now for a little while, but one thing that seems to have been missed entirely is guidance on writing Python code that is OS-neutral. This mostly matters if someone wants to try to

Re: [PATCH rtems-net-legacy] bsp_drivers: Use os.path for compatibility with non Unix host

2021-04-15 Thread Vijay Kumar Banerjee
On Thu, Apr 15, 2021 at 2:51 PM Gedare Bloom wrote: > > On Thu, Apr 15, 2021 at 2:49 PM Vijay Kumar Banerjee wrote: > > > > On Thu, Apr 15, 2021 at 2:46 PM Gedare Bloom wrote: > > > > > > On Thu, Apr 15, 2021 at 12:01 PM Vijay Kumar Banerjee > > > wrote: > > > > > > > > It has been less than 3

Re: OS Neutrality in Python Development Guidelines?

2021-04-15 Thread Chris Johns
On 16/4/21 6:58 am, Gedare Bloom wrote: > Hello all, > > To revisit a little bit of a controversial subject :) The Python > Development Guidelines have been in place now for a little while, but > one thing that seems to have been missed entirely is guidance on > writing Python code that is OS-neut

Re: OS Neutrality in Python Development Guidelines?

2021-04-15 Thread Sebastian Huber
Hello Gedare, On 15/04/2021 22:58, Gedare Bloom wrote: I guess we should define something to add here? Is anything written somewhere we can adopt? the spirit of the Python guide is to have rules which are enforced by tools. If a certain component should run on platform X, then I think some CI

RE: [PATCH v2 1/1] grlib/genirq: Taking into account that it could be more than one ISR enabled/disabled

2021-04-15 Thread Jan.Sommer
Thanks, pushed to master and 5. From: devel On Behalf Of Daniel Hellstrom Sent: Thursday, April 15, 2021 1:03 PM To: Moyano Heredia, Victor Gabriel ; devel@rtems.org Subject: Re: [PATCH v2 1/1] grlib/genirq: Taking into account that it could be more than one ISR enabled/disabled Looks good. T

[PATCH] c-user: Document rtems_semaphore_obtain() errors

2021-04-15 Thread Sebastian Huber
Update #3993. --- c-user/semaphore/directives.rst | 8 1 file changed, 8 insertions(+) diff --git a/c-user/semaphore/directives.rst b/c-user/semaphore/directives.rst index 54f40a4..7c2a9c8 100644 --- a/c-user/semaphore/directives.rst +++ b/c-user/semaphore/directives.rst @@ -525,9 +525,1