[PATCH] spec/aarch64: Enable previously disabled tests

2021-03-08 Thread Alex White
This enables several testsuites that were initially disabled during development. --- spec/build/bsps/aarch64/a53/tsta53.yml| 10 +- spec/build/bsps/aarch64/xilinx-zynqmp/tstqemu.yml | 10 +- 2 files changed, 2 insertions(+), 18 deletions(-) diff --git a/spec/build/bsps

Re: [PATCH] spec/aarch64: Enable previously disabled tests

2021-03-08 Thread Sebastian Huber
On 08/03/2021 16:30, Alex White wrote: This enables several testsuites that were initially disabled during development. Looks good, thanks. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 f

RE: [PATCH 0/2] Import ehci_pci

2021-03-08 Thread Jan.Sommer
Could someone please approve this patchset (and ideally the similar ones for 6-freebsd-12 and 5-freebsd-12)? They only import the files for the USB flash drive support from FreeBSD without any RTEMS related changes. Best regards, Jan > -Original Message- > From: devel On Behalf O

Re: [PATCH 0/2] Import ehci_pci

2021-03-08 Thread Sebastian Huber
On 08/03/2021 16:38, jan.som...@dlr.de wrote: Could someone please approve this patchset (and ideally the similar ones for 6-freebsd-12 and 5-freebsd-12)? They only import the files for the USB flash drive support from FreeBSD without any RTEMS related changes. The changes are fine. -- embed

Re: [PATCH 00/26] leon: various fixes and TN0018 errata workaround

2021-03-08 Thread Joel Sherrill
On Sun, Mar 7, 2021 at 9:51 AM Daniel Hellstrom wrote: > On 2020-09-23 17:05, Gedare Bloom wrote: > > On Wed, Sep 23, 2020 at 4:34 AM Daniel Hellstrom > wrote: > > Hi Sebastian, > > Thanks for asking and sorry for dropping the ball on these. > > The status is that two needs updating (BSD licen

RE: [PATCH 0/2] Import ehci_pci

2021-03-08 Thread Jan.Sommer
> -Original Message- > From: Sebastian Huber > Sent: Monday, March 8, 2021 4:42 PM > To: Sommer, Jan ; Moyano Heredia, Victor Gabriel > ; devel@rtems.org > Subject: Re: [PATCH 0/2] Import ehci_pci > > On 08/03/2021 16:38, jan.som...@dlr.de wrote: > > > Could someone please approve this

Re: RSB build issue with rtems-libbsd

2021-03-08 Thread Chris Johns
On 6/3/21 2:24 pm, Vijay Kumar Banerjee wrote: > Hello, > > I'm getting the following error when trying to build rtems-libbsd from > RSB. Is there anything that I'm missing? > > ``` > ../source-builder/sb-set-builder --prefix=$RTEMS6_PREFIX > 6/rtems-libbsd --host=powerpc-rtems6 --with-rtems-bsp=

Re: [PATCH rtems-net-legacy] netlegacy: Build libtelnetd.a and install header file in correct location

2021-03-08 Thread Chris Johns
On 6/3/21 6:18 am, Vijay Kumar Banerjee wrote: > Pushed. :) I did not see any vc posts and the archive does not show any. Are the repo's hooks working? Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH rtems-net-legacy] netlegacy: Build libtelnetd.a and install header file in correct location

2021-03-08 Thread Vijay Kumar Banerjee
On Mon, Mar 8, 2021 at 3:06 PM Chris Johns wrote: > > On 6/3/21 6:18 am, Vijay Kumar Banerjee wrote: > > Pushed. :) > > I did not see any vc posts and the archive does not show any. Are the repo's > hooks working? > https://lists.rtems.org/pipermail/vc/2021-March/035534.html > Chris __

Re: [PATCH rtems-net-legacy] netlegacy: Build libtelnetd.a and install header file in correct location

2021-03-08 Thread Joel Sherrill
On Fri, Mar 5, 2021, 1:07 PM Gedare Bloom wrote: > On Fri, Mar 5, 2021 at 11:42 AM Vijay Kumar Banerjee > wrote: > > > > --- > > netlegacy.py | 27 +-- > > testsuites/telnetd01/wscript | 2 +- > > 2 files changed, 22 insertions(+), 7 deletions(-) > > > >

Re: RSB build issue with rtems-libbsd

2021-03-08 Thread Joel Sherrill
On Mon, Mar 8, 2021, 4:02 PM Chris Johns wrote: > On 6/3/21 2:24 pm, Vijay Kumar Banerjee wrote: > > Hello, > > > > I'm getting the following error when trying to build rtems-libbsd from > > RSB. Is there anything that I'm missing? > > > > ``` > > ../source-builder/sb-set-builder --prefix=$RTEMS6

Re: [PATCH rtems-net-legacy] netlegacy: Build libtelnetd.a and install header file in correct location

2021-03-08 Thread Chris Johns
On 9/3/21 9:10 am, Vijay Kumar Banerjee wrote: > On Mon, Mar 8, 2021 at 3:06 PM Chris Johns wrote: >> >> On 6/3/21 6:18 am, Vijay Kumar Banerjee wrote: >>> Pushed. :) >> >> I did not see any vc posts and the archive does not show any. Are the repo's >> hooks working? >> > https://lists.rtems.org/p

[PATCH v1 5/7] ck: Update for ILP32

2021-03-08 Thread Kinsey Moore
libck assumes all AArch64 pointers are 8 bytes. This adds the required defines to handle 4 byte pointers on ILP32. --- freebsd/sys/contrib/ck/include/gcc/aarch64/ck_pr.h | 8 1 file changed, 8 insertions(+) diff --git a/freebsd/sys/contrib/ck/include/gcc/aarch64/ck_pr.h b/freebsd/sys/co

[PATCH v1 4/7] nexus: Add ZynqMP SLCR driver

2021-03-08 Thread Kinsey Moore
Add a System Level Control Register driver for the Xilinx Zynq Ultrascale+ MPSoC with basic clock control functionality for use with the Cadence GEM. This also removes the Zynq-7000 clock control weakref from compilation depending on the BSP in use. --- freebsd/sys/arm/xilinx/zy7_slcr.c

[PATCH v1 3/7] nexus: Switch ZynqMP platforms to CGEM3

2021-03-08 Thread Kinsey Moore
Similar to the UARTs, ZynqMP hardware platforms use the highest memory-mapped CGEM peripheral as the primary instance of that peripheral. This change allows operation on hardware as well as QEMU. --- rtemsbsd/include/bsp/nexus-devices.h | 9 - 1 file changed, 8 insertions(+), 1 deletion(-)

[PATCH v1 1/7] rtembsd: Fix alignment of allocations for 64bit

2021-03-08 Thread Kinsey Moore
Alignment on 64bit hardware is strict in comparison to running in an emulator. This resolves an alignment exception when allocating memory on real hardware. --- rtemsbsd/rtems/rtems-program.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/rtemsbsd/rtems/rtems-program.c b/

[PATCH v1 2/7] if_cgem: Add support for ZynqMP CGEM

2021-03-08 Thread Kinsey Moore
This is a port of the latest patch in FreeBSD that adds support for 64bit CGEMs as used in ZynqMP. This does not include the work necessary for support on RISC-V systems. --- freebsd/sys/dev/cadence/if_cgem.c| 241 ++- freebsd/sys/dev/cadence/if_cgem_hw.h | 45 + 2

[PATCH v1 6/7] linker: Enforce set alignment requirements

2021-03-08 Thread Kinsey Moore
According to commentary on GCC bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99143, the alignment behavior of linker sections on which RTEMS has relied was never guaranteed to be consistent across platforms and any alignment requirements for linker sections needs to be enforced explicitly. This

[PATCH v1 7/7] nexus: Add UKPHY driver to ZynqMP

2021-03-08 Thread Kinsey Moore
ZynqMP hardware comes with many different Ethernet PHYs depending on which board is used. Add the UKPHY driver to handle basic PHY interaction for any unrecognized PHYs. --- rtemsbsd/include/bsp/nexus-devices.h | 1 + rtemsbsd/include/machine/rtems-bsd-nexus-bus.h | 9 + 2 files

RE: [PATCH v1 7/7] spec/aarch64: Force strict alignment for ZynqMP

2021-03-08 Thread Kinsey Moore
So after a little more diving into this, I have found why --strict-align is required. If the MMU is disabled, all memory is treated as device memory which requires strictly aligned accesses. Kinsey -Original Message- From: devel On Behalf Of Kinsey Moore Sent: Friday, March 5, 2021 07:1

Re: [PATCH v1 1/7] rtembsd: Fix alignment of allocations for 64bit

2021-03-08 Thread Chris Johns
OK for 1 to 7 from me. In regards to the if_ cgem driver, will any be posted up stream? Chris On 9/3/21 10:27 am, Kinsey Moore wrote: > Alignment on 64bit hardware is strict in comparison to running in an > emulator. This resolves an alignment exception when allocating memory on > real hardware.

Re: [PATCH v1 7/7] spec/aarch64: Force strict alignment for ZynqMP

2021-03-08 Thread Chris Johns
On 9/3/21 10:40 am, Kinsey Moore wrote: > So after a little more diving into this, I have found why --strict-align is > required. > If the MMU is disabled, all memory is treated as device memory which requires > strictly aligned accesses. I think I have missed something or not understanding the b

Re: [5 PATCH 0/2] Backport fixes to zynq uart to RTEMS5

2021-03-08 Thread Chris Johns
OK for 5. On 6/3/21 5:58 am, Jan Sommer wrote: > This patchset backports the commits of Kinsey Moore and myself, which > fix the stdin behavior for the zynq-uart based console driver. > I checked the behavior on hardware with the termios.exe application. > Before, the scanf and similar functions d

RE: [PATCH v1 1/7] rtembsd: Fix alignment of allocations for 64bit

2021-03-08 Thread Kinsey Moore
The patch to the if_cgem driver is actually a modified (to LibBSD style) backport of the 64bit cgem patch that's in 13. FreeBSD doesn't appear to care about ILP32 and that is the majority of functional difference between the upstream and what is being applied here. Kinsey -Original Message

Re: [PATCH 0/3] Fix Missing break in switch Coverity issues

2021-03-08 Thread Chris Johns
On 6/3/21 6:04 am, Gedare Bloom wrote: > On Fri, Mar 5, 2021 at 11:48 AM Sebastian Huber > wrote: >> >> On 05/03/2021 19:40, Joel Sherrill wrote: >> >>> On Fri, Mar 5, 2021, 12:25 PM Sebastian Huber >>> >> > wrote: >>> >>> On 05/03/2021 16:27, Gedare

Re: [PATCH v1 1/7] rtembsd: Fix alignment of allocations for 64bit

2021-03-08 Thread Chris Johns
On 9/3/21 1:21 pm, Kinsey Moore wrote: > The patch to the if_cgem driver is actually a modified (to LibBSD style) > backport of the > 64bit cgem patch that's in 13. FreeBSD doesn't appear to care about ILP32 and > that is > the majority of functional difference between the upstream and what is be

[PATCH rtems-docs] networking: Rename to legacy networking

2021-03-08 Thread Vijay Kumar Banerjee
--- book/index_book.rst | 2 +- {networking => legacy-networking}/command.rst | 0 {networking => legacy-networking}/conf.py | 4 ++-- {networking => legacy-networking}/dec_21140.rst | 0 {networking => leg

RE: [PATCH v1 7/7] spec/aarch64: Force strict alignment for ZynqMP

2021-03-08 Thread Kinsey Moore
I was working under the impression that I didn't need it since RTEMS uses a flat memory model. I'll be spending some time tomorrow seeing what it will take to enable usage of the "normal" memory model via a configured MMU. Kinsey -Original Message- From: Chris Johns Sent: Monday, March

RE: [PATCH v1 1/7] rtembsd: Fix alignment of allocations for 64bit

2021-03-08 Thread Kinsey Moore
Thus far, GCC has been just fine other than violating some behavioral expectations that were never guaranteed (the linker sets patches). Newlib has some ILP32 issues that need to be addressed. I've gotten a patch into the upstream ARM optimized routines that will eventually make it into Newlib a

[PATCH RSB] Add recipe for building rtems-net-legacy

2021-03-08 Thread Vijay Kumar Banerjee
--- rtems/config/6/rtems-net-legacy.bset | 4 ++ rtems/config/tools/rtems-net-legacy-6.cfg | 12 .../config/tools/rtems-net-legacy-common.cfg | 65 +++ 3 files changed, 81 insertions(+) create mode 100644 rtems/config/6/rtems-net-legacy.bset create mode 100644

Re: [PATCH v1 7/7] spec/aarch64: Force strict alignment for ZynqMP

2021-03-08 Thread Chris Johns
On 9/3/21 1:24 pm, Kinsey Moore wrote: > I was working under the impression that I didn't need it since RTEMS uses a > flat > memory model. I'll be spending some time tomorrow seeing what it will take to > enable usage of the "normal" memory model via a configured MMU. Most architectures with MMU

Re: [PATCH RSB] Add recipe for building rtems-net-legacy

2021-03-08 Thread Vijay Kumar Banerjee
Hello, This patch doesn't build due to an unrelated error in RSB: https://devel.rtems.org/ticket/4319 With a workaround to bypass the above error, this patch builds and installs rtems-net-legacy. Best regards, Vijay On Mon, Mar 8, 2021 at 7:31 PM Vijay Kumar Banerjee wrote: > > --- > rtems/co

Re: RSB build issue with rtems-libbsd

2021-03-08 Thread Vijay Kumar Banerjee
On Mon, Mar 8, 2021 at 3:02 PM Chris Johns wrote: > > On 6/3/21 2:24 pm, Vijay Kumar Banerjee wrote: > > Hello, > > > > I'm getting the following error when trying to build rtems-libbsd from > > RSB. Is there anything that I'm missing? > > > > ``` > > ../source-builder/sb-set-builder --prefix=$RTE

Re: RSB build issue with rtems-libbsd

2021-03-08 Thread Vijay Kumar Banerjee
On Mon, Mar 8, 2021 at 3:14 PM Joel Sherrill wrote: > > > > > > On Mon, Mar 8, 2021, 4:02 PM Chris Johns wrote: >> >> On 6/3/21 2:24 pm, Vijay Kumar Banerjee wrote: >> > Hello, >> > >> > I'm getting the following error when trying to build rtems-libbsd from >> > RSB. Is there anything that I'm mi

Re: [PATCH RSB] Add recipe for building rtems-net-legacy

2021-03-08 Thread Chris Johns
Hi Vijay, Thank you for sorting this out. On 9/3/21 1:31 pm, Vijay Kumar Banerjee wrote: > --- > rtems/config/6/rtems-net-legacy.bset | 4 ++ > rtems/config/tools/rtems-net-legacy-6.cfg | 12 > .../config/tools/rtems-net-legacy-common.cfg | 65 +++ > 3 files c

Re: RSB build issue with rtems-libbsd

2021-03-08 Thread Chris Johns
On 9/3/21 1:44 pm, Vijay Kumar Banerjee wrote: > On Mon, Mar 8, 2021 at 3:14 PM Joel Sherrill wrote: >> On Mon, Mar 8, 2021, 4:02 PM Chris Johns wrote: >>> >>> On 6/3/21 2:24 pm, Vijay Kumar Banerjee wrote: Hello, I'm getting the following error when trying to build rtems-libbsd fr

Re: [PATCH RSB] Add recipe for building rtems-net-legacy

2021-03-08 Thread Vijay Kumar Banerjee
Hi Chris, Thanks for reviewing. On Mon, Mar 8, 2021 at 7:54 PM Chris Johns wrote: > > Hi Vijay, > > Thank you for sorting this out. > > On 9/3/21 1:31 pm, Vijay Kumar Banerjee wrote: > > --- > > rtems/config/6/rtems-net-legacy.bset | 4 ++ > > rtems/config/tools/rtems-net-legacy-6.cfg

Re: [PATCH RSB] Add recipe for building rtems-net-legacy

2021-03-08 Thread Chris Johns
On 9/3/21 2:03 pm, Vijay Kumar Banerjee wrote: > Hi Chris, > > Thanks for reviewing. > > On Mon, Mar 8, 2021 at 7:54 PM Chris Johns wrote: >> >> Hi Vijay, >> >> Thank you for sorting this out. >> >> On 9/3/21 1:31 pm, Vijay Kumar Banerjee wrote: >>> --- >>> rtems/config/6/rtems-net-legacy.bs

Re: [PATCH RSB] Add recipe for building rtems-net-legacy

2021-03-08 Thread Vijay Kumar Banerjee
On Mon, Mar 8, 2021 at 8:23 PM Chris Johns wrote: > > > > On 9/3/21 2:03 pm, Vijay Kumar Banerjee wrote: > > Hi Chris, > > > > Thanks for reviewing. > > > > On Mon, Mar 8, 2021 at 7:54 PM Chris Johns wrote: > >> > >> Hi Vijay, > >> > >> Thank you for sorting this out. > >> > >> On 9/3/21 1:31 pm,

Re: RSB build issue with rtems-libbsd

2021-03-08 Thread Vijay Kumar Banerjee
On Mon, Mar 8, 2021 at 7:57 PM Chris Johns wrote: > > On 9/3/21 1:44 pm, Vijay Kumar Banerjee wrote: > > On Mon, Mar 8, 2021 at 3:14 PM Joel Sherrill wrote: > >> On Mon, Mar 8, 2021, 4:02 PM Chris Johns wrote: > >>> > >>> On 6/3/21 2:24 pm, Vijay Kumar Banerjee wrote: > Hello, > >

Re: [PATCH 0/3] Fix Missing break in switch Coverity issues

2021-03-08 Thread Gedare Bloom
On Mon, Mar 8, 2021 at 7:21 PM Chris Johns wrote: > > On 6/3/21 6:04 am, Gedare Bloom wrote: > > On Fri, Mar 5, 2021 at 11:48 AM Sebastian Huber > > wrote: > >> > >> On 05/03/2021 19:40, Joel Sherrill wrote: > >> > >>> On Fri, Mar 5, 2021, 12:25 PM Sebastian Huber > >>> >>>

Re: [PATCH rtems-docs] networking: Rename to legacy networking

2021-03-08 Thread Gedare Bloom
On Mon, Mar 8, 2021 at 7:24 PM Vijay Kumar Banerjee wrote: > > --- > book/index_book.rst | 2 +- > {networking => legacy-networking}/command.rst | 0 > {networking => legacy-networking}/conf.py | 4 ++-- > {networking =

Re: [5 PATCH 0/2] Backport fixes to zynq uart to RTEMS5

2021-03-08 Thread Gedare Bloom
On Fri, Mar 5, 2021 at 11:59 AM Jan Sommer wrote: > > This patchset backports the commits of Kinsey Moore and myself, which > fix the stdin behavior for the zynq-uart based console driver. > I checked the behavior on hardware with the termios.exe application. > Before, the scanf and similar functi

Re: [PATCH 0/3] Fix Missing break in switch Coverity issues

2021-03-08 Thread Sebastian Huber
On 09/03/2021 06:47, Gedare Bloom wrote: I would just use a comment which is understood by GCC, clang, and Coverity. What does Linux use? That's fine, if there is a de facto standard to use, we can go for it. Looking at the option documentation gcc supports a lot of different possible ways an

Re: [PATCH 0/3] Fix Missing break in switch Coverity issues

2021-03-08 Thread Gedare Bloom
On Mon, Mar 8, 2021 at 11:04 PM Sebastian Huber wrote: > > On 09/03/2021 06:47, Gedare Bloom wrote: > > I would just use a comment which is understood by GCC, clang, and > Coverity. What does Linux use? > > >>> That's fine, if there is a de facto standard to use, we can go for it. >