Re: [rtems commit] getgrent.c: Fix Unchecked return value error (CID #1459004)

2021-02-27 Thread Gedare Bloom
The fix looks right, please push it to get the build working again. On Fri, Feb 26, 2021 at 11:11 PM Vijay Kumar Banerjee wrote: > > Hi, > > I'm getting build error after this commit. > ``` > /home/vijay/development/rtems/6/lib/gcc/i386-rtems6/10.2.1/../../../../i386-rtems6/bin/ld: > ./librtemscp

Re: [rtems commit] getgrent.c: Fix Unchecked return value error (CID #1459004)

2021-02-27 Thread Joel Sherrill
Sorry and thanks. On Sat, Feb 27, 2021, 8:35 AM Gedare Bloom wrote: > The fix looks right, please push it to get the build working again. > > On Fri, Feb 26, 2021 at 11:11 PM Vijay Kumar Banerjee > wrote: > > > > Hi, > > > > I'm getting build error after this commit. > > ``` > > > /home/vijay/d

Re: [rtems commit] getgrent.c: Fix Unchecked return value error (CID #1459004)

2021-02-27 Thread Vijay Kumar Banerjee
Pushed the fix. Thanks! On Sat, Feb 27, 2021 at 8:15 AM Joel Sherrill wrote: > > Sorry and thanks. > > On Sat, Feb 27, 2021, 8:35 AM Gedare Bloom wrote: >> >> The fix looks right, please push it to get the build working again. >> >> On Fri, Feb 26, 2021 at 11:11 PM Vijay Kumar Banerjee >> wrot

Re: [5 PATCH] powerpc/motorola_power: Place any common data in the .bss section

2021-02-27 Thread Joel Sherrill
Looks good. On Fri, Feb 26, 2021, 5:59 PM wrote: > From: Chris Johns > > - It seems the compiler how defaults to -fcommon and this means > some uninitialised data is ignored. > > Closes #4266 > --- > bsps/powerpc/motorola_powerpc/bootloader/ppcboot.lds | 8 +++- > 1 file changed, 7 inser

Re: [5 PATCH] powerpc/motorola_power: Place any common data in the .bss section

2021-02-27 Thread Chris Johns
On 28/2/21 3:15 am, Joel Sherrill wrote: > Looks good. Great. The patch has been independently tested. I will push a similar change to master without a review. I think it is safe to do that. Chris > > On Fri, Feb 26, 2021, 5:59 PM mailto:chr...@rtems.org>> > wrote: > > From: Chris Johns m