Pushed the fix. Thanks!
On Sat, Feb 27, 2021 at 8:15 AM Joel Sherrill <j...@rtems.org> wrote: > > Sorry and thanks. > > On Sat, Feb 27, 2021, 8:35 AM Gedare Bloom <ged...@rtems.org> wrote: >> >> The fix looks right, please push it to get the build working again. >> >> On Fri, Feb 26, 2021 at 11:11 PM Vijay Kumar Banerjee <vi...@rtems.org> >> wrote: >> > >> > Hi, >> > >> > I'm getting build error after this commit. >> > ``` >> > /home/vijay/development/rtems/6/lib/gcc/i386-rtems6/10.2.1/../../../../i386-rtems6/bin/ld: >> > ./librtemscpu.a(getgrent.c.57.o): in function `endgrent': >> > /home/vijay/rtems-class/rtems/build/i386/pc386/../../../cpukit/libcsupport/src/getgrent.c:109: >> > undefined reference to `_Assert_Unused_variable_equals' >> > collect2: error: ld returned 1 exit status >> > ``` >> > Looks like assert.h isn't included from getgrent.c . I have attached a >> > patch to add the header files and checked that it's building now. >> > >> > >> > Best regards, >> > Vijay >> > >> > On Fri, Feb 26, 2021 at 3:56 PM Joel Sherrill <j...@rtems.org> wrote: >> > > >> > > Module: rtems >> > > Branch: master >> > > Commit: e5e58da6dfbdfa78ad499c2f52ec53c88538aa1c >> > > Changeset: >> > > http://git.rtems.org/rtems/commit/?id=e5e58da6dfbdfa78ad499c2f52ec53c88538aa1c >> > > >> > > Author: Ryan Long <ryan.l...@oarcorp.com> >> > > Date: Fri Feb 19 17:30:13 2021 -0500 >> > > >> > > getgrent.c: Fix Unchecked return value error (CID #1459004) >> > > >> > > CID 1459004: Unchecked return value in endgrent(). >> > > >> > > Closes #4261 >> > > >> > > --- >> > > >> > > cpukit/libcsupport/src/getgrent.c | 4 +++- >> > > 1 file changed, 3 insertions(+), 1 deletion(-) >> > > >> > > diff --git a/cpukit/libcsupport/src/getgrent.c >> > > b/cpukit/libcsupport/src/getgrent.c >> > > index b358cb9..de56430 100644 >> > > --- a/cpukit/libcsupport/src/getgrent.c >> > > +++ b/cpukit/libcsupport/src/getgrent.c >> > > @@ -95,6 +95,7 @@ void setgrent(void) >> > > void endgrent(void) >> > > { >> > > grp_context *ctx = grp_get_context(); >> > > + int sc; >> > > >> > > if (ctx == NULL) >> > > return; >> > > @@ -104,5 +105,6 @@ void endgrent(void) >> > > } >> > > >> > > free(ctx); >> > > - pthread_setspecific(grp_key, NULL); >> > > + sc = pthread_setspecific(grp_key, NULL); >> > > + _Assert_Unused_variable_equals(sc, 0); >> > > } >> > > >> > > _______________________________________________ >> > > vc mailing list >> > > v...@rtems.org >> > > http://lists.rtems.org/mailman/listinfo/vc >> > _______________________________________________ >> > devel mailing list >> > devel@rtems.org >> > http://lists.rtems.org/mailman/listinfo/devel >> _______________________________________________ >> devel mailing list >> devel@rtems.org >> http://lists.rtems.org/mailman/listinfo/devel _______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
