[PATCH 23/29] vfs: make the string hashes salt the hash

From: Linus Torvalds We always mixed in the parent pointer into the dentry name hash, but we did it late at lookup time. It turns out that we can simplify that lookup-time action by salting the hash with the parent pointer early instead of late. A few other users of our string hashes also wante

[PATCH 22/29] mm, fs: get rid of PAGE_CACHE_* and page_cache_{get, release} macros

From: "Kirill A. Shutemov" PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} macros were introduced *long* time ago with promise that one day it will be possible to implement page cache with bigger chunks than PAGE_SIZE. This promise never materialized. And unlikely will. We have many places where PAGE_CACHE

[PATCH 19/29] jffs2: Fix page lock / f->sem deadlock

From: David Woodhouse With this fix, all code paths should now be obtaining the page lock before f->sem. Reported-by: Szabó Tamás Tested-by: Thomas Betker Signed-off-by: David Woodhouse Cc: sta...@vger.kernel.org 10 7 cpukit/libfs/src/jffs2/src/gc.c diff --git a/cpukit/libfs/src/

[PATCH 24/29] jffs2: Remove jffs2_{get,set,remove}xattr macros

From: Andreas Gruenbacher When CONFIG_JFFS2_FS_XATTR is off, jffs2_xattr_handlers is defined as NULL. With sb->s_xattr == NULL, the generic_{get,set,remove}xattr functions produce the same result as setting the {get,set,remove}xattr inode operations to NULL, so there is no need for these macros.

[PATCH 00/29] Update JFFS2 port to Linux v4.17

This patch series adds all JFFS2 changes made by the Linux upstream from Linux v3.11 to v4.17 to the RTEMS port. See also: https://devel.rtems.org/ticket/3465 Ajesh Kunhipurayil Vijayan (1): jffs2: Fix crash due to truncation of csize Al Viro (1): kill wbuf_queued/wbuf_dwork_lock Andreas G

[PATCH 07/29] jffs2: remove from wait queue after schedule()

From: Li Zefan @wait is a local variable, so if we don't remove it from the wait queue list, later wake_up() may end up accessing invalid memory. This was spotted by eyes. Signed-off-by: Li Zefan Cc: David Woodhouse Cc: Artem Bityutskiy Cc: Signed-off-by: Andrew Morton Signed-off-by: Brian

[PATCH 09/29] jffs2: Fix segmentation fault found in stress test

From: Kamlakant Patel Creating a large file on a JFFS2 partition sometimes crashes with this call trace: [ 306.476000] CPU 13 Unable to handle kernel paging request at virtual address c000dfff8002, epc == c03a80a8, ra == c03a8044 [ 306.488000] Oops[#1]: [ 306.488000] Cpu

[PATCH 21/29] jffs2: Improve post-mount CRC scan efficiency

From: David Woodhouse We need to finish doing the CRC checks before we can allow writes to happen, and we currently process the inodes in order. This means a call to jffs2_get_ino_cache() for each possible inode# up to c->highest_ino. There may be a lot of lookups which fail, if the inode# space

[PATCH 25/29] sched/headers: Prepare to move signal wakeup & sigpending methods from into

From: Ingo Molnar Fix up affected files that include this signal functionality via sched.h. Acked-by: Linus Torvalds Cc: Mike Galbraith Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: linux-ker...@vger.kernel.org Signed-off-by: Ingo Molnar 0 0 cpukit/libfs/src/jffs2/include/linux/sc

[PATCH 01/29] score: Add postorder tree iteration support

Update #3465. 66 0 cpukit/include/rtems/score/rbtree.h 1 0 cpukit/score/Makefile.am 81 0 cpukit/score/src/rbtreepostorder.c 184 0 testsuites/sptests/sprbtree01/init.c diff --git a/cpukit/include/rtems/score/rbtree.h b/cpukit/include/rtems/score/rbtree.

[PATCH 28/29] mtd: Unconditionally update ->fail_addr and ->addr in part_erase()

From: Boris Brezillon ->fail_addr and ->addr can be updated no matter the result of parent->_erase(), we just need to remove the code doing the same thing in mtd_erase_callback() to avoid adjusting those fields twice. Note that this can be done because all MTD users have been converted to not pa

[PATCH 02/29] linux: Install

This makes it possible to test this API. Update #3465. 1 0 cpukit/headers.am 0 0 cpukit/{libfs/src/jffs2 => }/include/linux/rbtree.h diff --git a/cpukit/headers.am b/cpukit/headers.am index 2315db1e7d..fb6e1fc009 100644 --- a/cpukit/headers.am +++ b/cpukit/headers.am @@ -

[PATCH 26/29] jffs2: fix spelling mistake: "requestied" -> "requested"

From: Colin Ian King trivial fix to spelling mistake in JFFS2_ERROR message Signed-off-by: Colin Ian King [Brian: also fix 'an' -> 'a'] Signed-off-by: Brian Norris 1 1 cpukit/libfs/src/jffs2/src/readinode.c diff --git a/cpukit/libfs/src/jffs2/src/readinode.c b/cpukit/libfs/src/j

[PATCH 11/29] initramfs: support initramfs that is bigger than 2GiB

From: Yinghai Lu Now with 64bit bzImage and kexec tools, we support ramdisk that size is bigger than 2g, as we could put it above 4G. Found compressed initramfs image could not be decompressed properly. It turns out that image length is int during decompress detection, and it will become < 0 wh

[PATCH 27/29] mtd: Stop assuming mtd_erase() is asynchronous

From: Boris Brezillon None of the mtd->_erase() implementations work in an asynchronous manner, so let's simplify MTD users that call mtd_erase(). All they need to do is check the value returned by mtd_erase() and assume that != 0 means failure. Signed-off-by: Boris Brezillon Reviewed-by: Richa

[PATCH 05/29] fs/jffs2: use rbtree postorder iteration helper instead of opencoding

From: Cody P Schafer Use rbtree_postorder_for_each_entry_safe() to destroy the rbtree instead of opencoding an alternate postorder iteration that modifies the tree Signed-off-by: Cody P Schafer Cc: Michel Lespinasse Cc: Jan Kara Cc: David Woodhouse Signed-off-by: Andrew Morton Signed-off-by

[PATCH 10/29] jffs2: Fix crash due to truncation of csize

From: Ajesh Kunhipurayil Vijayan mounting JFFS2 partition sometimes crashes with this call trace: [ 1322.24] Kernel bug detected[#1]: [ 1322.244000] Cpu 2 [ 1322.244000] $ 0 : 0018 3ff00070 0001 [ 1322.252000] $ 4 : c

[PATCH 13/29] jffs2: Drop bogus if in comment

From: Geert Uytterhoeven Signed-off-by: Geert Uytterhoeven Cc: David Woodhouse Cc: linux-...@lists.infradead.org Signed-off-by: Brian Norris 1 1 cpukit/libfs/src/jffs2/src/readinode.c diff --git a/cpukit/libfs/src/jffs2/src/readinode.c b/cpukit/libfs/src/jffs2/src/readinode.c in

[PATCH 17/29] jffs2: fix a memleak in read_direntry()

From: Wei Fang Need to free the memory allocated for 'fd' if failed to read all of the remainder name. Signed-off-by: Wei Fang Signed-off-by: Brian Norris 5 1 cpukit/libfs/src/jffs2/src/readinode.c diff --git a/cpukit/libfs/src/jffs2/src/readinode.c b/cpukit/libfs/src/jffs2/src/

[PATCH 16/29] jffs2: fix unbalanced locking

From: Brian Norris Li Zefan reported an unbalanced locking issue, found by his internal debugging feature on runtime. The particular case he was looking at doesn't lead to a deadlock, as the structure that this lock is embedded in is freed on error. But we should straighten out the error handling

[PATCH 12/29] kill wbuf_queued/wbuf_dwork_lock

From: Al Viro schedule_delayed_work() happening when the work is already pending is a cheap no-op. Don't bother with ->wbuf_queued logics - it's both broken (cancelling ->wbuf_dwork leaves it set, as spotted by Jeff Harris) and pointless. It's cheaper to let schedule_delayed_work() handle that

[PATCH 08/29] jffs2: avoid soft-lockup in jffs2_reserve_space_gc()

From: Li Zefan We triggered soft-lockup under stress test on 2.6.34 kernel. BUG: soft lockup - CPU#1 stuck for 60009ms! [lockf2.test:14488] ... [] (jffs2_do_reserve_space+0x420/0x440 [jffs2]) [] (jffs2_reserve_space_gc+0x34/0x78 [jffs2]) [] (jffs2_garbage_collect_dnode.isra.3+0x264/0x478 [jffs2]

[PATCH 14/29] jffs2: compr_rubin: Remove unused function

From: Rickard Strandqvist Remove the function pulledbits() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist Reviewed-by: Richard Weinberger Signed-off-by: Brian Norris 0 5 cpukit/libf

[PATCH 29/29] jffs2: Add README

Add README to document the corrspending Linux version and the update procedure. Close #3465. 35 0 cpukit/libfs/src/jffs2/README diff --git a/cpukit/libfs/src/jffs2/README b/cpukit/libfs/src/jffs2/README new file mode 100644 index 00..7d9c9f41b2 --- /dev/null +++ b/cpukit/libfs

[PATCH 06/29] jffs2: use generic posix ACL infrastructure

From: Christoph Hellwig Also don't bother to set up a .get_acl method for symlinks as we do not support access control (ACLs or even mode bits) for symlinks in Linux. Signed-off-by: Christoph Hellwig Signed-off-by: Al Viro 2 5 cpukit/libfs/src/jffs2/src/acl.h diff --git a/cpukit/

[PATCH 15/29] jffs2: fix handling of corrupted summary length

From: Chen Jie sm->offset maybe wrong but magic maybe right, the offset do not have CRC. Badness at c00c7580 [verbose debug info unavailable] NIP: c00c7580 LR: c00c718c CTR: 0014 REGS: df07bb40 TRAP: 0700 Not tainted (2.6.34.13-WR4.3.0.0_standard) MSR: 00029000 CR: 22084f84 XER: 00

[PATCH 18/29] tree wide: use kvfree() than conditional kfree()/vfree()

From: Tetsuo Handa There are many locations that do if (memory_was_allocated_by_vmalloc) vfree(ptr); else kfree(ptr); but kvfree() can handle both kmalloc()ed memory and vmalloc()ed memory using is_vmalloc_addr(). Unless callers have special reasons, we can replace this branch with

[PATCH 03/29] linux: Simplify

Remove the placeholder struct rb_node and use RBTree_Node directly via some C pre-processor defines to adjust the member names. Update #3465. 37 45 cpukit/include/linux/rbtree.h 2 2 cpukit/libfs/src/jffs2/src/readinode.c diff --git a/cpukit/include/linux/rbtree.h b/cpukit/i

[PATCH 04/29] linux: Add rbtree_postorder_for_each_entry_safe()

Update #3465. 16 0 cpukit/include/linux/rbtree.h 22 0 testsuites/sptests/sprbtree01/init.c diff --git a/cpukit/include/linux/rbtree.h b/cpukit/include/linux/rbtree.h index e1da2c7b9a..53c777e8c1 100644 --- a/cpukit/include/linux/rbtree.h +++ b/cpukit/include/linux/rbtree.h @

Properties of ChangeLog/Commit Messages

Hi Richard Kenner (old GCC maintainer) listed these in a post and I thought it was worth passing along: = In other words, there are three levels (of information in ChangeLog entries) here: (1) What the code currently does (2) How we changed the code from what it did to what i

jffs2 changes and Coverity issue in porting code

Hi By any chance, do any of the jffs2 updates pick up changes to that method in the porting layer which Coverity thought had an issue? I know the code is the same across multiple OSes and you didn't invent or modify it porting jffs2 to RTEMS. Just curious if the situation might have changed. --j

[GSoC - x86_64] Minimal BSP to review

Hi! I've made a pull-request that's nearly complete on Github: https://github.com/AmaanC/rtems-gsoc18/pull/1/ I'd appreciate a review before I squash it into 2 commits (1. minimal BSP reaching Init task, and 2. adding the NS16550 console driver) and submit the squashed patches to devel@ after thi

Re: [GSoC - x86_64] Minimal BSP to review

Hello Amaan, I think it is quite confusing to review the individual commit. I will review the final patch set. Just one thing: x86_64-rtems5-ld --verbose | head -n 20 GNU ld (GNU Binutils) 2.30   Supported emulations:    elf_x86_64    elf_i386    elf_iamcu    elf32_x86_64    elf_l1om    elf_k

Re: [GSoC - x86_64] Minimal BSP to review

Hi! Yeah, the individual commits aren't logical at all. I just thought we could review the actual code contents (in the "files changed" tab) on Github (https://github.com/AmaanC/rtems-gsoc18/pull/1/files). Is this what you meant by "final patchset"? Once this PR is polished up sufficiently, I can

Re: Gcov support in Covoar

I think that the whole gcov support needs to be reworked. I was looking into how llvm outputs their gcov data in gcda file format here https://github.com/llvm-mirror/compiler-rt/blob/master/lib/profile/GCDAProfiling.c I need some help in understanding the workflow of how covoar gets the trace inpu

Re: [PATCH v3] coverage : Add support to run coverage in supported bsp without extra options

Hello Chris, If you find some time, please review this patch. It's a small patch but it's important since it affects how the command will look like. please review if this patch is alright or we need to have a different approach. Thanks On 3 July 2018 at 20:30, Vijay Kumar Banerjee wrote: > Clo

Re: [GSoC - x86_64] Minimal BSP to review

On Thu, Jul 5, 2018 at 10:02 AM, Amaan Cheval wrote: > Hi! > > Yeah, the individual commits aren't logical at all. I just thought we > could review the actual code contents (in the "files changed" tab) on > Github (https://github.com/AmaanC/rtems-gsoc18/pull/1/files). Is this > what you meant by "

Re: [PATCH] Rework to minimize and eventually eliminate RTEMS use of bsp_specs

Hey, Joel! The x86_64 BSP currently uses an empty bsp_specs file contingent on (at least the x86-64 parts of) this email thread's patch making it upstream to GCC, and making their way into the RSB. 2 options: - 1. Make the upstream GCC commit (at least the parts adding rtemself64.h, editing confi

Re: jffs2 changes and Coverity issue in porting code

Hello Joel, On 05/07/18 17:52, Joel Sherrill wrote: Hi By any chance, do any of the jffs2 updates pick up changes to that method in the porting layer which Coverity thought had an issue? I know the code is the same across multiple OSes and you didn't invent or modify it porting jffs2 to RTEMS.