Hi!
Yeah, the individual commits aren't logical at all. I just thought we
could review the actual code contents (in the "files changed" tab) on
Github (https://github.com/AmaanC/rtems-gsoc18/pull/1/files). Is this
what you meant by "final patchset"?
Once this PR is polished up sufficiently, I can submit the squashed,
rebased commits to devel - that way we maintain the commit history for
how things progressed temporally, and still have the logical commits
we want upstream.
If you'd prefer, I can squash on Github too (it just means I'd then
for a brief period not have the "daily" commit branch we aim to have
for GSoC, as I'd have to rebase to make changes instead of adding new
commits to the daily branch to indicate more "work done"). Let me know
if you prefer this!
Thanks for catching the missing copyright in linkcmds!
On Thu, Jul 5, 2018 at 7:16 PM, Sebastian Huber
<sebastian.hu...@embedded-brains.de> wrote:
> Hello Amaan,
>
> I think it is quite confusing to review the individual commit. I will review
> the final patch set.
>
> Just one thing:
>
> x86_64-rtems5-ld --verbose | head -n 20
> GNU ld (GNU Binutils) 2.30
> Supported emulations:
> elf_x86_64
> elf_i386
> elf_iamcu
> elf32_x86_64
> elf_l1om
> elf_k1om
> using internal linker script:
> ==================================================
> /* Script for -z combreloc: combine and sort reloc sections */
> /* Copyright (C) 2014-2018 Free Software Foundation, Inc.
> Copying and distribution of this script, with or without modification,
> are permitted in any medium without royalty provided the copyright
> notice and this notice are preserved. */
> OUTPUT_FORMAT("elf64-x86-64", "elf64-x86-64",
> "elf64-x86-64")
> OUTPUT_ARCH(i386:x86-64)
> ENTRY(_start)
> SEARCH_DIR("/build/rtems/5/x86_64-rtems5/lib");
>
> Please add the FSF notice to your file if necessary.
>
> --
> Sebastian Huber, embedded brains GmbH
>
> Address : Dornierstr. 4, D-82178 Puchheim, Germany
> Phone : +49 89 189 47 41-16
> Fax : +49 89 189 47 41-09
> E-Mail : sebastian.hu...@embedded-brains.de
> PGP : Public key available on request.
>
> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
>
_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
