Sebastian.. anymore comments?
Liam.. try to stick to the top of file comments and grouping commands.
A comment that essentially is repetitive of the name of a method adds
no value or insight.
The commands that you will need to use are something like this sequence:
git checkout -b BRANCH
git add
On 23/12/15 01:17, Zaphod Beeblebrox wrote:
+/*
+@ingroup xilinx-zynq_i2c
+@brief Disable cadence interrupts
+*/
static void cadence_i2c_disable_interrupts(volatile cadence_i2c *regs)
{
regs->irqdisable = 0x;
}
Could we please not add trivial Doxygen comments like this.
--
Sebast
I screwed up and used an email address that wasn't allowed to send to the
list. Zaphod mentioned it was a GCI Doxygen task.
This doesn't look like a proper git patch. This link should help.
https://devel.rtems.org/wiki/Developer/Git#GitAccessforUsers
I am on my phone but it looks like too many l
Please explain what the purpose of this change is. You may also want to
read the RTEMS wiki instructions on submitting a patch. I think you just
did a git diff and didn't use the format-patch feature
On Dec 22, 2015 6:17 PM, "Zaphod Beeblebrox" wrote:
> -#ifndef _BSPABORT_H
> -#define _BSPABORT_H
-#ifndef _BSPABORT_H
-#define _BSPABORT_H
-
-#include
-#include
-#include
-
-#define INSN_MASK 0xc5
-
-#define INSN_STM1 0x80
-#define INSN_STM2 0x84
-#define INSN_STR 0x40
-#define INSN_STRB 0x44
-
-#define INSN_LDM1 0x81
-#define INSN_LDM23
