Sebastian.. anymore comments?
Liam.. try to stick to the top of file comments and grouping commands.
A comment that essentially is repetitive of the name of a method adds
no value or insight.
The commands that you will need to use are something like this sequence:
git checkout -b BRANCH
git add <FILES THAT CHANGED>
git commit
# editor will pop up so you can describe change
git checkout master
git pull
git checkout BRANCH
git rebase -i master
# the above makes sure you are up to date
git format-patch -o TMPDIR master
# generates patch files relative to master branch into TMPDIR
Email those patches.
I hope that sequence helps. I am adding more time to the GCI task.
On Tue, Dec 22, 2015 at 11:51 PM, Sebastian Huber <
sebastian.hu...@embedded-brains.de> wrote:
> On 23/12/15 01:17, Zaphod Beeblebrox wrote:
>
>> +/*
>> +@ingroup xilinx-zynq_i2c
>> +@brief Disable cadence interrupts
>> +*/
>> static void cadence_i2c_disable_interrupts(volatile cadence_i2c *regs)
>> {
>> regs->irqdisable = 0xffff;
>> }
>>
>
> Could we please not add trivial Doxygen comments like this.
>
> --
> Sebastian Huber, embedded brains GmbH
>
> Address : Dornierstr. 4, D-82178 Puchheim, Germany
> Phone : +49 89 189 47 41-16
> Fax : +49 89 189 47 41-09
> E-Mail : sebastian.hu...@embedded-brains.de
> PGP : Public key available on request.
>
> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
>
>
> _______________________________________________
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
>
_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
