On 2020-03-15 21:18 -0600, Gedare Bloom wrote:
>
> I found what I was thinking about:
> http://google.github.io/styleguide/pyguide.html#313-imports-formatting
>
> PEP has similar guidance:
> https://www.python.org/dev/peps/pep-0008/#imports
PEP8 is so old that even the Python project breaks man
On Sun, Mar 15, 2020 at 9:09 PM Gedare Bloom wrote:
>
> On Sun, Mar 15, 2020 at 5:54 PM Amar Takhar wrote:
> >
> > On 2020-03-15 17:26 -0600, Gedare Bloom wrote:
> >
> > > Make blank lines consistent, 1 or 2, between top-level definitions. (I
> > > know, we still haven't settled on a style, but l
On Sun, Mar 15, 2020 at 5:54 PM Amar Takhar wrote:
>
> On 2020-03-15 17:26 -0600, Gedare Bloom wrote:
>
> > Make blank lines consistent, 1 or 2, between top-level definitions. (I
> > know, we still haven't settled on a style, but let's aim for
> > consistency.)
>
> Okay.
>
>
> > I think all import
On 2020-03-16 11:48 +1100, Chris Johns wrote:
>
> That is understandable. Are the patches available in your personal repo?
They are not.
> I am fine with pieces being pushed after RTEMS 5 has branched. My concern is
> only related to the pending release. It is only a couple of weeks away if
>
On 16/3/20 11:02 am, Amar Takhar wrote:
> On 2020-03-16 09:30 +1100, Chris Johns wrote:
>> Hi,
>>
>> This looks good. Thank you for making the switch to pytest.
>>
>> Are you planning on moving all the exist "chris hacked" tests to pytest?
>
> I don't know probably not I don't have the time this w
On 2020-03-16 09:30 +1100, Chris Johns wrote:
> Hi,
>
> This looks good. Thank you for making the switch to pytest.
>
> Are you planning on moving all the exist "chris hacked" tests to pytest?
I don't know probably not I don't have the time this was to get someone started.
> If so I am wonder
On 2020-03-15 17:26 -0600, Gedare Bloom wrote:
> Make blank lines consistent, 1 or 2, between top-level definitions. (I
> know, we still haven't settled on a style, but let's aim for
> consistency.)
Okay.
> I think all imports should go at the top?
This is scoped it only runs under certain con
On 16/3/20 10:26 am, Gedare Bloom wrote:
> On Fri, Mar 13, 2020 at 5:28 PM Amar Takhar wrote:
>> +def test_label_error():
>> + from rtemstoolkit.error import general
> I think all imports should go at the top?
This is done in a number of places. It means the import only happens when the
cod
On Fri, Mar 13, 2020 at 5:28 PM Amar Takhar wrote:
>
> ---
> rtemstoolkit/darwin.py | 5 -
> rtemstoolkit/freebsd.py | 5 -
> rtemstoolkit/host.py| 14 --
> rtemstoolkit/linux.py | 5 -
> rtemstoolkit/netbsd.py | 5 -
Hi,
This looks good. Thank you for making the switch to pytest.
Are you planning on moving all the exist "chris hacked" tests to pytest?
If so I am wondering how you will stage the change? This size patch is perfect
but I am concerned we may have some done and others not when the release branch
10 matches
Mail list logo
