Re: [PATCH] record: Add wrappers for malloc() functions

2019-09-10 Thread Chris Johns
On 6/9/19 11:09 pm, Sebastian Huber wrote: > On 02/09/2019 08:00, Chris Johns wrote: >> On 2/9/19 3:37 pm, Sebastian Huber wrote: >>> On 01/09/2019 04:29, Chris Johns wrote: On 30/8/19 11:07 pm, Sebastian Huber wrote: > Introduce new library librtemsrecordwrap.a which contains wrappers for

Re: [PATCH] record: Add wrappers for malloc() functions

2019-09-06 Thread Sebastian Huber
On 02/09/2019 08:00, Chris Johns wrote: On 2/9/19 3:37 pm, Sebastian Huber wrote: On 01/09/2019 04:29, Chris Johns wrote: On 30/8/19 11:07 pm, Sebastian Huber wrote: Introduce new library librtemsrecordwrap.a which contains wrappers for operating system functions which produce entry/exit event

Re: [PATCH] record: Add wrappers for malloc() functions

2019-09-02 Thread Sebastian Huber
On 02/09/2019 09:00, Chris Johns wrote: Why not generate the call to `rtems_record_produce_2`? You should be able to determine this give you will know there in a single item plus the return address to record. In fact there is little need for `rtems_record_produce_n` if you have [1..n] already def

Re: [PATCH] record: Add wrappers for malloc() functions

2019-09-01 Thread Chris Johns
On 2/9/19 4:11 pm, Sebastian Huber wrote: > On 02/09/2019 08:00, Chris Johns wrote: I do not see any upside adding this library or wrapping specific functions this way. >>> The benefits are: >>> >>> * Slightly more compact (the event indicates the function and the data can >>> be >>> u

Re: [PATCH] record: Add wrappers for malloc() functions

2019-09-01 Thread Sebastian Huber
On 02/09/2019 08:00, Chris Johns wrote: I do not see any upside adding this library or wrapping specific functions this way. The benefits are: * Slightly more compact (the event indicates the function and the data can be used for the caller address instead, the generic function entry/exit needs

Re: [PATCH] record: Add wrappers for malloc() functions

2019-09-01 Thread Chris Johns
On 2/9/19 3:37 pm, Sebastian Huber wrote: > On 01/09/2019 04:29, Chris Johns wrote: >> On 30/8/19 11:07 pm, Sebastian Huber wrote: >>> Introduce new library librtemsrecordwrap.a which contains wrappers for >>> operating system functions which produce entry/exit events. >> >> Why not enhance the tra

Re: [PATCH] record: Add wrappers for malloc() functions

2019-09-01 Thread Sebastian Huber
On 01/09/2019 04:29, Chris Johns wrote: On 30/8/19 11:07 pm, Sebastian Huber wrote: Introduce new library librtemsrecordwrap.a which contains wrappers for operating system functions which produce entry/exit events. Why not enhance the trace linker to handle the recorder you have developed? It

Re: [PATCH] record: Add wrappers for malloc() functions

2019-08-31 Thread Chris Johns
On 30/8/19 11:07 pm, Sebastian Huber wrote: > Introduce new library librtemsrecordwrap.a which contains wrappers for > operating system functions which produce entry/exit events. Why not enhance the trace linker to handle the recorder you have developed? It has been able to wrap malloc and friends