Re: [PATCH] covoar: fixing the extension mismatch in trace file

2018-05-13 Thread Joel Sherrill
On Sun, May 13, 2018, 11:33 AM Cillian O'Donnell wrote: > > > On 13 May 2018 at 16:32, Vijay Kumar Banerjee > wrote: > >> On 13 May 2018 at 19:00, Cillian O'Donnell wrote: >> >>> Is there supposed to be a message there? >>> >>> Anyway just to clear this up, try this for me. >>> >>> 1. Grab a ne

Re: [PATCH] covoar: fixing the extension mismatch in trace file

2018-05-13 Thread Cillian O'Donnell
On 13 May 2018 at 16:32, Vijay Kumar Banerjee wrote: > On 13 May 2018 at 19:00, Cillian O'Donnell wrote: > >> Is there supposed to be a message there? >> >> Anyway just to clear this up, try this for me. >> >> 1. Grab a new branch of >> >> https://github.com/cillianodonnell/rtems-tools/tree/test

Re: [PATCH] covoar: fixing the extension mismatch in trace file

2018-05-13 Thread Vijay Kumar Banerjee
On 13 May 2018 at 21:05, Gedare Bloom wrote: > Probably this is because rtems-sparc5 does not have a . in it like > rtems-sparc4.11 > > > Does that really make the difference ? it is parsed by covoar/DesiredSymbols.cc , it just simply replaces the @BUILD-TARGET@ with the buildTarget _

Re: [PATCH] covoar: fixing the extension mismatch in trace file

2018-05-13 Thread Vijay Kumar Banerjee
On 13 May 2018 at 21:02, Vijay Kumar Banerjee wrote: > On 13 May 2018 at 19:00, Cillian O'Donnell wrote: > >> Is there supposed to be a message there? >> >> Anyway just to clear this up, try this for me. >> >> 1. Grab a new branch of >> >> https://github.com/cillianodonnell/rtems-tools/tree/test

Re: [PATCH] covoar: fixing the extension mismatch in trace file

2018-05-13 Thread Gedare Bloom
On Sun, May 13, 2018 at 11:32 AM, Vijay Kumar Banerjee wrote: > On 13 May 2018 at 19:00, Cillian O'Donnell wrote: >> >> Is there supposed to be a message there? >> >> Anyway just to clear this up, try this for me. >> >> 1. Grab a new branch of >> >> https://github.com/cillianodonnell/rtems-tools/

Re: [PATCH] covoar: fixing the extension mismatch in trace file

2018-05-13 Thread Vijay Kumar Banerjee
On 13 May 2018 at 19:00, Cillian O'Donnell wrote: > Is there supposed to be a message there? > > Anyway just to clear this up, try this for me. > > 1. Grab a new branch of > > https://github.com/cillianodonnell/rtems-tools/tree/tester-support > > which is the current master plus one patch with th

Re: [PATCH] covoar: fixing the extension mismatch in trace file

2018-05-13 Thread Cillian O'Donnell
Is there supposed to be a message there? Anyway just to clear this up, try this for me. 1. Grab a new branch of https://github.com/cillianodonnell/rtems-tools/tree/tester-support which is the current master plus one patch with the tester support in progress. 2. Apply your patch to that and mak

Re: [PATCH] covoar: fixing the extension mismatch in trace file

2018-05-13 Thread Vijay Kumar Banerjee
On Sun, 13 May 2018, 18:24 Cillian O'Donnell, wrote: > > > On 13 May 2018 at 13:47, Vijay Kumar Banerjee > wrote: > >> >> On Sun, 13 May 2018, 18:14 Cillian O'Donnell, >> wrote: >> >>> >>> >>> On 13 May 2018 at 13:35, Vijay Kumar Banerjee >>> wrote: >>> On Sun, 13 May 2018, 17:32 Cil

Re: [PATCH] covoar: fixing the extension mismatch in trace file

2018-05-13 Thread Vijay Kumar Banerjee
On Sun, 13 May 2018, 18:24 Cillian O'Donnell, wrote: > > > On 13 May 2018 at 13:47, Vijay Kumar Banerjee > wrote: > >> >> On Sun, 13 May 2018, 18:14 Cillian O'Donnell, >> wrote: >> >>> >>> >>> On 13 May 2018 at 13:35, Vijay Kumar Banerjee >>> wrote: >>> On Sun, 13 May 2018, 17:32 Cil

Re: [PATCH] covoar: fixing the extension mismatch in trace file

2018-05-13 Thread Cillian O'Donnell
On 13 May 2018 at 13:47, Vijay Kumar Banerjee wrote: > > On Sun, 13 May 2018, 18:14 Cillian O'Donnell, > wrote: > >> >> >> On 13 May 2018 at 13:35, Vijay Kumar Banerjee >> wrote: >> >>> >>> On Sun, 13 May 2018, 17:32 Cillian O'Donnell, >>> wrote: >>> I understand but that's a separate iss

Re: [PATCH] covoar: fixing the extension mismatch in trace file

2018-05-13 Thread Vijay Kumar Banerjee
On Sun, 13 May 2018, 18:14 Cillian O'Donnell, wrote: > > > On 13 May 2018 at 13:35, Vijay Kumar Banerjee > wrote: > >> >> On Sun, 13 May 2018, 17:32 Cillian O'Donnell, >> wrote: >> >>> I understand but that's a separate issue. I can do a full coverage run >>> from the top of the build tree by c

Re: [PATCH] covoar: fixing the extension mismatch in trace file

2018-05-13 Thread Cillian O'Donnell
On 13 May 2018 at 13:35, Vijay Kumar Banerjee wrote: > > On Sun, 13 May 2018, 17:32 Cillian O'Donnell, > wrote: > >> I understand but that's a separate issue. I can do a full coverage run >> from the top of the build tree by changing hello.exe.cov to hello.cov >> manually using current master. T

Re: [PATCH] covoar: fixing the extension mismatch in trace file

2018-05-13 Thread Vijay Kumar Banerjee
On Sun, 13 May 2018, 17:32 Cillian O'Donnell, wrote: > I understand but that's a separate issue. I can do a full coverage run > from the top of the build tree by changing hello.exe.cov to hello.cov > manually using current master. Then I add your patch which is supposed to > fix the problem of ha

Re: [PATCH] covoar: fixing the extension mismatch in trace file

2018-05-13 Thread Cillian O'Donnell
I understand but that's a separate issue. I can do a full coverage run from the top of the build tree by changing hello.exe.cov to hello.cov manually using current master. Then I add your patch which is supposed to fix the problem of having to change those manually so it looks for hello.exe.cov ins

Re: [PATCH] covoar: fixing the extension mismatch in trace file

2018-05-13 Thread Vijay Kumar Banerjee
On Sun, 13 May 2018, 17:02 Cillian O'Donnell, wrote: > But you see the thing is that if you remove the changes you made and run > the tester from the top of the build tree it makes it past those checks and > does full coverage analysis runs for all trace files that end in only .cov. > So only hel

Re: [PATCH] covoar: fixing the extension mismatch in trace file

2018-05-13 Thread Cillian O'Donnell
But you see the thing is that if you remove the changes you made and run the tester from the top of the build tree it makes it past those checks and does full coverage analysis runs for all trace files that end in only .cov. So only hello.cov here because I've changed it manually. warning: Unable

Re: [PATCH] covoar: fixing the extension mismatch in trace file

2018-05-13 Thread Vijay Kumar Banerjee
On 13 May 2018 at 16:16, Vijay Kumar Banerjee wrote: > > > On Sun, 13 May 2018, 16:15 Vijay Kumar Banerjee, > wrote: > >> >> >> On Sun, 13 May 2018, 16:09 Cillian O'Donnell, >> wrote: >> >>> It does seem to be having some knock on effect. Covoar made it past >>> these checks before. >>> >>> ---

Re: [PATCH] covoar: fixing the extension mismatch in trace file

2018-05-13 Thread Vijay Kumar Banerjee
On Sun, 13 May 2018, 16:15 Vijay Kumar Banerjee, wrote: > > > On Sun, 13 May 2018, 16:09 Cillian O'Donnell, > wrote: > >> It does seem to be having some knock on effect. Covoar made it past these >> checks before. >> >> - >> Total: 13 >> Average test time: 0:00:03.178923

Re: [PATCH] covoar: fixing the extension mismatch in trace file

2018-05-13 Thread Vijay Kumar Banerjee
On Sun, 13 May 2018, 16:09 Cillian O'Donnell, wrote: > It does seem to be having some knock on effect. Covoar made it past these > checks before. > > - > Total: 13 > Average test time: 0:00:03.178923 > Testing time : 0:00:41.326000 > Running covoar for score > covoar r

Re: [PATCH] covoar: fixing the extension mismatch in trace file

2018-05-13 Thread Cillian O'Donnell
It does seem to be having some knock on effect. Covoar made it past these checks before. - Total: 13 Average test time: 0:00:03.178923 Testing time : 0:00:41.326000 Running covoar for score covoar results directory: /home/cpod/development/rtems/leon3/coverage/score ERRO

Re: [PATCH] covoar: fixing the extension mismatch in trace file

2018-05-12 Thread Vijay Kumar Banerjee
On 13 May 2018 at 10:50, Chris Johns wrote: > On 13/5/18 4:44 pm, Vijay Kumar Banerjee wrote: > > On Sun, 13 May 2018, 10:09 Chris Johns, > > wrote: > > > > > >Coverage::CoverageFormats_t coverageFormat = > > > Coverage::COVERAGE_FORMAT_QEMU; >

Re: [PATCH] covoar: fixing the extension mismatch in trace file

2018-05-12 Thread Chris Johns
On 13/5/18 4:44 pm, Vijay Kumar Banerjee wrote: > On Sun, 13 May 2018, 10:09 Chris Johns, > wrote: > > > >        Coverage::CoverageFormats_t   coverageFormat = > >     Coverage::COVERAGE_FORMAT_QEMU; > >        Coverage::CoverageReaderBase* coverageReader

Re: [PATCH] covoar: fixing the extension mismatch in trace file

2018-05-12 Thread Vijay Kumar Banerjee
On Sun, 13 May 2018, 10:09 Chris Johns, wrote: > Sorry for the post in the other thread. I did not see this one. > > On 13/5/18 9:28 am, Joel Sherrill wrote: > > > > > > On Sat, May 12, 2018 at 2:42 PM, thelunatic > > wrote: > > > > --- > > > > > > Every patc

Re: [PATCH] covoar: fixing the extension mismatch in trace file

2018-05-12 Thread Chris Johns
Sorry for the post in the other thread. I did not see this one. On 13/5/18 9:28 am, Joel Sherrill wrote: > > > On Sat, May 12, 2018 at 2:42 PM, thelunatic > wrote: > > --- > > > Every patch needs an explanation/log message.  Look back through  > "git log"

Re: [PATCH] covoar: fixing the extension mismatch in trace file

2018-05-12 Thread Joel Sherrill
On Sat, May 12, 2018 at 2:42 PM, thelunatic wrote: > --- > Every patch needs an explanation/log message. Look back through "git log" for examples. > tester/covoar/covoar.cc | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/tester/covoar/covoar.cc b/tester/covoar