Re: [PATCH] bsp/raspberrypi: Updated the console API.

2020-01-04 Thread Christian Mauderer
On 03/01/2020 16:54, Vijay Kumar Banerjee wrote: > > > On Fri, Jan 3, 2020, 8:53 PM Niteesh > wrote: > > On Fri, Jan 3, 2020 at 7:32 PM Vijay Kumar Banerjee > mailto:vijaykumar9...@gmail.com>> wrote: > > Hi Niteesh, > A few formatting suggestio

Re: [PATCH] bsp/raspberrypi: Updated the console API.

2020-01-03 Thread Vijay Kumar Banerjee
On Fri, Jan 3, 2020, 8:53 PM Niteesh wrote: > On Fri, Jan 3, 2020 at 7:32 PM Vijay Kumar Banerjee < > vijaykumar9...@gmail.com> wrote: > >> Hi Niteesh, >> A few formatting suggestions: >> >>> >>> diff --git a/bsps/arm/raspberrypi/console/console-config.c >>> b/bsps/arm/raspberrypi/console/console

Re: [PATCH] bsp/raspberrypi: Updated the console API.

2020-01-03 Thread Niteesh
On Fri, Jan 3, 2020 at 7:32 PM Vijay Kumar Banerjee < vijaykumar9...@gmail.com> wrote: > Hi Niteesh, > A few formatting suggestions: > >> >> diff --git a/bsps/arm/raspberrypi/console/console-config.c >> b/bsps/arm/raspberrypi/console/console-config.c >> index d2186c918b..4000fd1c50 100644 >> --- a

Re: [PATCH] bsp/raspberrypi: Updated the console API.

2020-01-03 Thread Vijay Kumar Banerjee
Hi Niteesh, A few formatting suggestions: > > diff --git a/bsps/arm/raspberrypi/console/console-config.c > b/bsps/arm/raspberrypi/console/console-config.c > index d2186c918b..4000fd1c50 100644 > --- a/bsps/arm/raspberrypi/console/console-config.c > +++ b/bsps/arm/raspberrypi/console/console-config

Re: [PATCH] bsp/raspberrypi: Updated the console API.

2020-01-03 Thread Christian Mauderer
On 03/01/2020 13:31, Niteesh wrote: > On Fri, Jan 3, 2020 at 3:48 PM Christian Mauderer > wrote: > > On 03/01/2020 11:11, Niteesh wrote: > > Great, please do have a look at the FDT patch I sent today. > > The FDT patch looks OK too. I thought it's clear whe

Re: [PATCH] bsp/raspberrypi: Updated the console API.

2020-01-03 Thread Niteesh
qemu-system-aarch64 doesn't support elf formats too. I tried running them but the qemu is stuck at 0x200. Should I change the cpu type to armv7, but by default Rpi3 should run 32bit applications, but not sure about qemu. On Fri, Jan 3, 2020 at 6:01 PM Niteesh wrote: > On Fri, Jan 3, 2020 at 3:48

Re: [PATCH] bsp/raspberrypi: Updated the console API.

2020-01-03 Thread Niteesh
On Fri, Jan 3, 2020 at 3:48 PM Christian Mauderer wrote: > On 03/01/2020 11:11, Niteesh wrote: > > Great, please do have a look at the FDT patch I sent today. > > The FDT patch looks OK too. I thought it's clear when I said that I'll > push it together with this one in a few days. > Sorry, I was

Re: [PATCH] bsp/raspberrypi: Updated the console API.

2020-01-03 Thread Christian Mauderer
On 03/01/2020 11:11, Niteesh wrote: > Great, please do have a look at the FDT patch I sent today. The FDT patch looks OK too. I thought it's clear when I said that I'll push it together with this one in a few days. > I would like to work on something else now, do you have something > interesting

Re: [PATCH] bsp/raspberrypi: Updated the console API.

2020-01-03 Thread Niteesh
Great, please do have a look at the FDT patch I sent today. I would like to work on something else now, do you have something interesting for me to do? On Fri, Jan 3, 2020 at 3:39 PM Christian Mauderer wrote: > Hello Niteesh, > > looks good to me. The UART works for a Pi1 and a Pi2. The Framebuf

Re: [PATCH] bsp/raspberrypi: Updated the console API.

2020-01-03 Thread Christian Mauderer
Hello Niteesh, looks good to me. The UART works for a Pi1 and a Pi2. The Framebuffer console doesn't but it doesn't work either before this patch and as far as I can tell you took over the logic correctly. So I don't think this patch will break anything that isn't already broken. I'll give the pa