On Fri, Jan 3, 2020 at 7:32 PM Vijay Kumar Banerjee < vijaykumar9...@gmail.com> wrote:
> Hi Niteesh, > A few formatting suggestions: > >> >> diff --git a/bsps/arm/raspberrypi/console/console-config.c >> b/bsps/arm/raspberrypi/console/console-config.c >> index d2186c918b..4000fd1c50 100644 >> --- a/bsps/arm/raspberrypi/console/console-config.c >> +++ b/bsps/arm/raspberrypi/console/console-config.c >> @@ -19,50 +19,132 @@ >> */ >> >> #include <rtems/bspIo.h> >> - >> -#include <libchip/serial.h> >> > You removed it here and added it below > >> +#include <rtems/console.h> >> +#include <rtems/sysinit.h> >> >> #include <bspopts.h> >> -#include <bsp/irq.h> >> -#include <bsp/usart.h> >> > same here > >> +#include <bsp.h> >> #include <bsp/raspberrypi.h> >> +#include <bsp/usart.h> >> > added here ^ > >> +#include <bsp/arm-pl011.h> >> #include <bsp/fbcons.h> >> +#include <bsp/console-termios.h> >> +#include <bsp/fdt.h> >> +#include <bsp/fatal.h> >> + >> +#include <libfdt.h> >> +#include <libchip/serial.h> > > here > Is there any particular reason for doing it, or is it just a preference? > This is just a small change and I would suggest you wait for at least a day > before sending a v2 of the patch so that you can add changes suggested > by other people (if any). Congrats on getting it working ;-) > Thank you. > Best, > Vijay > >> + >> +#define UART0 "/dev/ttyS0" >> +#define FBCONS "/dev/fbcons" >> + >> >
_______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
