Re: [PATCH v2 4/6] dhcpcd: Remove unused dhcpcd shell command

2018-05-03 Thread Chris Johns
On 03/05/2018 17:42, Sebastian Huber wrote: > On 03/05/18 09:27, Chris Johns wrote: >> On 03/05/2018 17:20, Sebastian Huber wrote: >>> On 03/05/18 09:13, Chris Johns wrote: On 03/05/2018 16:49, Sebastian Huber wrote: > -extern rtems_shell_cmd_t rtems_shell_DHCPCD_Command; -1. I am not

Re: [PATCH v2 4/6] dhcpcd: Remove unused dhcpcd shell command

2018-05-03 Thread Chris Johns
I oppose this change. On 03/05/2018 16:49, Sebastian Huber wrote: > --- > libbsd.py | 6 - > rtemsbsd/include/rtems/netcmds-config.h | 2 -- > rtemsbsd/rtems/rtems-bsd-shell-dhcpcd.c | 40 > - > 3 files changed, 48 deletions(-)

Re: [PATCH v2 4/6] dhcpcd: Remove unused dhcpcd shell command

2018-05-03 Thread Sebastian Huber
On 03/05/18 09:27, Chris Johns wrote: On 03/05/2018 17:20, Sebastian Huber wrote: On 03/05/18 09:13, Chris Johns wrote: On 03/05/2018 16:49, Sebastian Huber wrote: -extern rtems_shell_cmd_t rtems_shell_DHCPCD_Command; -1. I am not bothering to review the remainder of this patch. This comma

Re: [PATCH v2 4/6] dhcpcd: Remove unused dhcpcd shell command

2018-05-03 Thread Chris Johns
On 03/05/2018 17:20, Sebastian Huber wrote: > On 03/05/18 09:13, Chris Johns wrote: >> On 03/05/2018 16:49, Sebastian Huber wrote: >>> -extern rtems_shell_cmd_t rtems_shell_DHCPCD_Command; >> -1. I am not bothering to review the remainder of this patch. >> >> This command is useful. I have used it

Re: [PATCH v2 4/6] dhcpcd: Remove unused dhcpcd shell command

2018-05-03 Thread Sebastian Huber
On 03/05/18 09:13, Chris Johns wrote: On 03/05/2018 16:49, Sebastian Huber wrote: -extern rtems_shell_cmd_t rtems_shell_DHCPCD_Command; -1. I am not bothering to review the remainder of this patch. This command is useful. I have used it in the past when working with dhcpd. It is like running a

Re: [PATCH v2 4/6] dhcpcd: Remove unused dhcpcd shell command

2018-05-03 Thread Chris Johns
On 03/05/2018 16:49, Sebastian Huber wrote: > -extern rtems_shell_cmd_t rtems_shell_DHCPCD_Command; -1. I am not bothering to review the remainder of this patch. This command is useful. I have used it in the past when working with dhcpd. It is like running a daemon on the command in Unix to debug

[PATCH v2 4/6] dhcpcd: Remove unused dhcpcd shell command

2018-05-02 Thread Sebastian Huber
--- libbsd.py | 6 - rtemsbsd/include/rtems/netcmds-config.h | 2 -- rtemsbsd/rtems/rtems-bsd-shell-dhcpcd.c | 40 - 3 files changed, 48 deletions(-) delete mode 100644 rtemsbsd/rtems/rtems-bsd-shell-dhcpcd.c diff --git a/libbsd