On 03/05/2018 17:42, Sebastian Huber wrote: > On 03/05/18 09:27, Chris Johns wrote: >> On 03/05/2018 17:20, Sebastian Huber wrote: >>> On 03/05/18 09:13, Chris Johns wrote: >>>> On 03/05/2018 16:49, Sebastian Huber wrote: >>>>> -extern rtems_shell_cmd_t rtems_shell_DHCPCD_Command; >>>> -1. I am not bothering to review the remainder of this patch. >>>> >>>> This command is useful. I have used it in the past when working with >>>> dhcpd. It >>>> is like running a daemon on the command in Unix to debug a problem. This >>>> change >>>> hides that. >>> This command is not useful. >> It is for debugging. >> >> Doing this makes debugging harder. In time we may solve the global issue >> however >> until then it is still useful. >> >>> I guess it worked only by accident. >> User beware. >> >>> The dhcpcd uses >>> several global variables which are not cleaned up or properly >>> re-initialized. >> A patch to let it only be used once would fix that. >> >> It works on a first pass time and if debugging we have no ^C so it does not >> matter. >> > > I can keep the command and simply call rtems_dhcpcd_start() in it. >
Keeping the command is important, making it better is good. It is useful playing with the options and settings for the client which I have done a few times. Chris _______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
