Re: [PATCH 05/13] posix: Remove superfluous check

2021-02-19 Thread Gedare Bloom
On Fri, Feb 19, 2021 at 9:46 AM Joel Sherrill wrote: > > > > On Fri, Feb 19, 2021, 10:31 AM Gedare Bloom wrote: >> >> On Thu, Feb 18, 2021 at 11:56 PM Sebastian Huber >> wrote: >> > >> > On 18/02/2021 20:25, Joel Sherrill wrote: >> > >> > > > - /* >> > > > - * api may be NULL in case

Re: [PATCH 05/13] posix: Remove superfluous check

2021-02-19 Thread Joel Sherrill
On Fri, Feb 19, 2021, 10:31 AM Gedare Bloom wrote: > On Thu, Feb 18, 2021 at 11:56 PM Sebastian Huber > wrote: > > > > On 18/02/2021 20:25, Joel Sherrill wrote: > > > > > > - /* > > > > - * api may be NULL in case of a thread close in progress > > > > - */ > > > > - if ( !a

Re: [PATCH 05/13] posix: Remove superfluous check

2021-02-19 Thread Gedare Bloom
On Thu, Feb 18, 2021 at 11:56 PM Sebastian Huber wrote: > > On 18/02/2021 20:25, Joel Sherrill wrote: > > > > - /* > > > - * api may be NULL in case of a thread close in progress > > > - */ > > > - if ( !api ) > > > -return; > > > - > > I believe you, but shou

Re: [PATCH 05/13] posix: Remove superfluous check

2021-02-18 Thread Sebastian Huber
On 18/02/2021 20:25, Joel Sherrill wrote: > -  /* > -   * api may be NULL in case of a thread close in progress > -   */ > -  if ( !api ) > -    return; > - I believe you, but should we replace this with an assert for now? And a comment explaining why it can't be NU

Re: [PATCH 05/13] posix: Remove superfluous check

2021-02-18 Thread Joel Sherrill
On Thu, Feb 18, 2021 at 11:21 AM Gedare Bloom wrote: > On Wed, Feb 17, 2021 at 12:31 PM Sebastian Huber > wrote: > > > > The api pointer is never NULL. > > > > Update #4244. > > --- > > cpukit/posix/src/psignalunblockthread.c | 6 -- > > 1 file changed, 6 deletions(-) > > > > diff --git a/c

Re: [PATCH 05/13] posix: Remove superfluous check

2021-02-18 Thread Gedare Bloom
On Wed, Feb 17, 2021 at 12:31 PM Sebastian Huber wrote: > > The api pointer is never NULL. > > Update #4244. > --- > cpukit/posix/src/psignalunblockthread.c | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/cpukit/posix/src/psignalunblockthread.c > b/cpukit/posix/src/psignalunblockth

[PATCH 05/13] posix: Remove superfluous check

2021-02-17 Thread Sebastian Huber
The api pointer is never NULL. Update #4244. --- cpukit/posix/src/psignalunblockthread.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/cpukit/posix/src/psignalunblockthread.c b/cpukit/posix/src/psignalunblockthread.c index 63ed823ab3..a1af20a5af 100644 --- a/cpukit/posix/src/psignalun