Re: [PATCH] rtems_termios_puts: Copy and write more than one char at once

2014-08-18 Thread Joel Sherrill
I committed this. Thanks. If there is something I missed, please let me know. --joel On 8/14/2014 10:02 AM, Kolja Waschk wrote: > Renamed startXmit(), nToSend is unsigned, just check FL_ORCVXOF, no (void) > cast anymore, compute nToSend in single if/else if/else. > > > --- > cpukit/libcsuppor

Re: [PATCH] rtems_termios_puts: Copy and write more than one char at once

2014-08-14 Thread Kolja Waschk
Renamed startXmit(), nToSend is unsigned, just check FL_ORCVXOF, no (void) cast anymore, compute nToSend in single if/else if/else. --- cpukit/libcsupport/src/termios.c | 135 --- 1 file changed, 85 insertions(+), 50 deletions(-) diff --git a/cpukit/libcsupp

Re: [PATCH] rtems_termios_puts: Copy and write more than one char at once

2014-08-14 Thread Sebastian Huber
On 14/08/14 15:58, Kolja Waschk wrote: Hi Sebastian, + int nToSend; Integer type is wrong. Yes, just what the original refill_transmitter uses and expects: nToSend is passed as return value to rtems_refill_transmitter, which also returns it to its caller as an int... Ok, rtems_termios_ref

Re: [PATCH] rtems_termios_puts: Copy and write more than one char at once

2014-08-14 Thread Kolja Waschk
Hi Sebastian, + int nToSend; Integer type is wrong. Yes, just what the original refill_transmitter uses and expects: nToSend is passed as return value to rtems_refill_transmitter, which also returns it to its caller as an int... + (void)rtems_termios_start_xmit (tty, tty->rawOutBuf.Tail

Re: [PATCH] rtems_termios_puts: Copy and write more than one char at once

2014-08-14 Thread Sebastian Huber
Hello Kolja, looks good, but I have some minor stuff. On 14/08/14 13:10, Kolja Waschk wrote: Beside copying more than one char at once, rtems_termios_refill_transmitter() and rtems_termios_puts() now use a common helper that (after checking ORCVXOF) calls write() with as much chars as are avail

Re: [PATCH] rtems_termios_puts: Copy and write more than one char at once

2014-08-14 Thread Kolja Waschk
Beside copying more than one char at once, rtems_termios_refill_transmitter() and rtems_termios_puts() now use a common helper that (after checking ORCVXOF) calls write() with as much chars as are available consecutively in rawOutBuf. Integer types used in new rtems_termios_start_xmit might not be

Re: [PATCH] rtems_termios_puts: Copy and write more than one char at once

2014-08-08 Thread Sebastian Huber
On 08/07/2014 09:38 PM, Kolja Waschk wrote: --- cpukit/libcsupport/src/termios.c | 74 +++- 1 file changed, 51 insertions(+), 23 deletions(-) diff --git a/cpukit/libcsupport/src/termios.c b/cpukit/libcsupport/src/termios.c index 2448ea1..d32ab74 100644 ---

[PATCH] rtems_termios_puts: Copy and write more than one char at once

2014-08-07 Thread Kolja Waschk
Hi, I'd like to send some work upstream that I've made for a Blackfin BF537 based device. The following patch was necessary for a DMA-based high speed UART driver(*) for Blackfin - it allows to start transmission on serial interfaces with more than just one char at a time. Notes: This already

[PATCH] rtems_termios_puts: Copy and write more than one char at once

2014-08-07 Thread Kolja Waschk
--- cpukit/libcsupport/src/termios.c | 74 +++- 1 file changed, 51 insertions(+), 23 deletions(-) diff --git a/cpukit/libcsupport/src/termios.c b/cpukit/libcsupport/src/termios.c index 2448ea1..d32ab74 100644 --- a/cpukit/libcsupport/src/termios.c +++ b/cpukit/