Re: [PATCH] rtems-tools/covoar: Wrong coverage computed

2019-01-25 Thread Vijay Kumar Banerjee
On Sat, 26 Jan 2019 at 01:46, Joel Sherrill wrote: > > > On Fri, Jan 25, 2019 at 12:50 PM Vijay Kumar Banerjee < > vijaykumar9...@gmail.com> wrote: > >> >> >> On Fri, 25 Jan 2019 at 23:39, Joel Sherrill wrote: >> >>> Sorry for the duplicate email. I didn't use the right email address and >>> the

Re: [PATCH] rtems-tools/covoar: Wrong coverage computed

2019-01-25 Thread Joel Sherrill
On Fri, Jan 25, 2019 at 12:50 PM Vijay Kumar Banerjee < vijaykumar9...@gmail.com> wrote: > > > On Fri, 25 Jan 2019 at 23:39, Joel Sherrill wrote: > >> Sorry for the duplicate email. I didn't use the right email address and >> the response did not go to devel@ >> >> On Fri, Jan 25, 2019 at 8:43 AM

Re: [PATCH] rtems-tools/covoar: Wrong coverage computed

2019-01-25 Thread Vijay Kumar Banerjee
On Fri, 25 Jan 2019 at 23:39, Joel Sherrill wrote: > Sorry for the duplicate email. I didn't use the right email address and > the response did not go to devel@ > > On Fri, Jan 25, 2019 at 8:43 AM Jiri Gaisler wrote: > >> Sorry for the noise, but I have a better patch that actually solves the >>

Re: [PATCH] rtems-tools/covoar: Wrong coverage computed

2019-01-25 Thread Joel Sherrill
Sorry for the duplicate email. I didn't use the right email address and the response did not go to devel@ On Fri, Jan 25, 2019 at 8:43 AM Jiri Gaisler wrote: > Sorry for the noise, but I have a better patch that actually solves the > root problem. I ran the full testsuite on sis and covoar again

Re: [PATCH] rtems-tools/covoar: Wrong coverage computed

2019-01-25 Thread Joel Sherrill
On Fri, Jan 25, 2019 at 8:10 AM Jiri Gaisler wrote: > Here is a final fix that also corrects the coverage computations. The > parsing of the symbol table made all symbols 2 bytes too large, hence the > wrong annotations. I have manually verified the correlation between sis > coverage output and t

Re: [PATCH] rtems-tools/covoar: Wrong coverage computed

2019-01-25 Thread Jiri Gaisler
Sorry for the noise, but I have a better patch that actually solves the root problem. I ran the full testsuite on sis and covoar against libscore.a like this: $ sparc-rtems5-ar -rcs sparc-rtems5/c/leon3/cpukit/score/libscore.a sparc-rtems5/c/leon3/cpukit/score/src/*.o $ rtems-test --rtems-bsp=

[PATCH] rtems-tools/covoar: Wrong coverage computed

2019-01-25 Thread Jiri Gaisler
couple of RTEMS tests programs, and there is now a 100% match. Please review and let me know if I can push this. Jiri. From 919cc2dbb9faf1c2ce8ba659e27f3335dbdf014c Mon Sep 17 00:00:00 2001 From: Jiri Gaisler Date: Thu, 24 Jan 2019 09:44:48 +0100 Subject: [PATCH] rtems-tools/covoar: Wrong coverage