On Fri, Jan 25, 2019 at 8:10 AM Jiri Gaisler <j...@gaisler.se> wrote:

> Here is a final fix that also corrects the coverage computations. The
> parsing of the symbol table made all symbols 2 bytes too large, hence the
> wrong annotations. I have manually verified the correlation between sis
> coverage output and the covoar coverage calculations and annotations for a
> couple of RTEMS tests programs, and there is now a 100% match.
>
> Please review and let me know if I can push this.
>

This looks good except it combines the change to allow selecting the format
from the command line with the "+1 / -1" fix. They should be separate
patches.

They are technically good. Just push them as separate patches.

>
> Jiri.
>
>
> _______________________________________________
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Reply via email to