Re: [PATCH] record: Add support for interrupt handlers

2019-09-05 Thread Peter Dufault
Don’t take it too far off-line, I want to follow. But do take it out of “support for interrupt handlers…”. > On Sep 5, 2019, at 01:29 , Chris Johns wrote: > > I think we can take C++ development styles offline and chat personally, maybe > in > person soon. :) Peter - Peter Du

Re: [PATCH] record: Add support for interrupt handlers

2019-09-05 Thread Chris Johns
On 5/9/19 5:53 pm, Sebastian Huber wrote: > - Am 5. Sep 2019 um 7:29 schrieb Chris Johns chr...@rtems.org: >> On 5/9/19 2:42 pm, Sebastian Huber wrote: >>> - Am 5. Sep 2019 um 0:28 schrieb Chris Johns chr...@rtems.org: >>> On 4/9/19 9:46 pm, Sebastian Huber wrote: > [...] Also it

Re: [PATCH] record: Add support for interrupt handlers

2019-09-05 Thread Sebastian Huber
- Am 5. Sep 2019 um 7:29 schrieb Chris Johns chr...@rtems.org: > On 5/9/19 2:42 pm, Sebastian Huber wrote: >> - Am 5. Sep 2019 um 0:28 schrieb Chris Johns chr...@rtems.org: >> >>> On 4/9/19 9:46 pm, Sebastian Huber wrote: [...] >>> Also it should be `std::fwrite`. >> >> Ok, it seems

Re: [PATCH] record: Add support for interrupt handlers

2019-09-04 Thread Chris Johns
On 5/9/19 2:42 pm, Sebastian Huber wrote: > - Am 5. Sep 2019 um 0:28 schrieb Chris Johns chr...@rtems.org: > >> On 4/9/19 9:46 pm, Sebastian Huber wrote: >>> On 04/09/2019 08:06, Chris Johns wrote: > +void LTTNGClient::WriteIRQHandlerExit(PerCPUContext* pcpu, const > ClientItem& >

Re: [PATCH] record: Add support for interrupt handlers

2019-09-04 Thread Sebastian Huber
- Am 5. Sep 2019 um 0:28 schrieb Chris Johns chr...@rtems.org: > On 4/9/19 9:46 pm, Sebastian Huber wrote: >> On 04/09/2019 08:06, Chris Johns wrote: +void LTTNGClient::WriteIRQHandlerExit(PerCPUContext* pcpu, const ClientItem& item) { +  pcpu->content_size += kEventIRQHan

Re: [PATCH] record: Add support for interrupt handlers

2019-09-04 Thread Chris Johns
On 4/9/19 9:46 pm, Sebastian Huber wrote: > On 04/09/2019 08:06, Chris Johns wrote: >>> +void LTTNGClient::WriteIRQHandlerExit(PerCPUContext* pcpu, const >>> ClientItem& >>> item) { >>> +  pcpu->content_size += kEventIRQHandlerExitBits; >>> +  pcpu->packet_size += kEventIRQHandlerExitBits; >>> + >

Re: [PATCH] record: Add support for interrupt handlers

2019-09-04 Thread Sebastian Huber
On 04/09/2019 08:06, Chris Johns wrote: +void LTTNGClient::WriteIRQHandlerExit(PerCPUContext* pcpu, const ClientItem& item) { + pcpu->content_size += kEventIRQHandlerExitBits; + pcpu->packet_size += kEventIRQHandlerExitBits; + + EventIRQHandlerExit& ih = pcpu->irq_handler_exit; + ih.header.n

Re: [PATCH] record: Add support for interrupt handlers

2019-09-04 Thread Chris Johns
On 4/9/19 5:37 pm, Sebastian Huber wrote: > On 04/09/2019 08:44, Chris Johns wrote: >> On 4/9/19 4:27 pm, Sebastian Huber wrote: >>> On 04/09/2019 08:06, Chris Johns wrote: > +} > + >    void LTTNGClient::AddThreadName(PerCPUContext* pcpu, const ClientItem& > item) { > if

Re: [PATCH] record: Add support for interrupt handlers

2019-09-04 Thread Sebastian Huber
On 04/09/2019 08:44, Chris Johns wrote: On 4/9/19 4:27 pm, Sebastian Huber wrote: On 04/09/2019 08:06, Chris Johns wrote: +} +   void LTTNGClient::AddThreadName(PerCPUContext* pcpu, const ClientItem& item) {     if (pcpu->thread_name_index >= THREAD_NAME_SIZE) {   return; @@ -286,6 +339

Re: [PATCH] record: Add support for interrupt handlers

2019-09-03 Thread Chris Johns
On 4/9/19 4:27 pm, Sebastian Huber wrote: > On 04/09/2019 08:06, Chris Johns wrote: >>> +} >>> + >>>   void LTTNGClient::AddThreadName(PerCPUContext* pcpu, const ClientItem& >>> item) { >>>     if (pcpu->thread_name_index >= THREAD_NAME_SIZE) { >>>   return; >>> @@ -286,6 +339,12 @@ void LTTNG

Re: [PATCH] record: Add support for interrupt handlers

2019-09-03 Thread Sebastian Huber
On 04/09/2019 08:06, Chris Johns wrote: +} + void LTTNGClient::AddThreadName(PerCPUContext* pcpu, const ClientItem& item) { if (pcpu->thread_name_index >= THREAD_NAME_SIZE) { return; @@ -286,6 +339,12 @@ void LTTNGClient::PrintItem(const ClientItem& item) { pcpu.thread_ns = it

Re: [PATCH] record: Add support for interrupt handlers

2019-09-03 Thread Chris Johns
On 4/9/19 3:55 pm, Sebastian Huber wrote: > Update #3665. > --- > trace/record/record-main-lttng.cc | 86 > +-- > 1 file changed, 82 insertions(+), 4 deletions(-) > > diff --git a/trace/record/record-main-lttng.cc > b/trace/record/record-main-lttng.cc > index

[PATCH] record: Add support for interrupt handlers

2019-09-03 Thread Sebastian Huber
Update #3665. --- trace/record/record-main-lttng.cc | 86 +-- 1 file changed, 82 insertions(+), 4 deletions(-) diff --git a/trace/record/record-main-lttng.cc b/trace/record/record-main-lttng.cc index 55ac294..340c511 100644 --- a/trace/record/record-main-lttng