On 04/09/2019 08:06, Chris Johns wrote:
+}
+
  void LTTNGClient::AddThreadName(PerCPUContext* pcpu, const ClientItem& item) {
    if (pcpu->thread_name_index >= THREAD_NAME_SIZE) {
      return;
@@ -286,6 +339,12 @@ void LTTNGClient::PrintItem(const ClientItem& item) {
        pcpu.thread_ns = item.ns;
        pcpu.thread_name_index = 0;
        break;
+    case RTEMS_RECORD_INTERRUPT_ENTRY:
+      WriteIRQHandlerEntry(&pcpu, item);
+      break;
+    case RTEMS_RECORD_INTERRUPT_EXIT:
+      WriteIRQHandlerExit(&pcpu, item);
... then take the address of? I prefer to see references being used where 
possible.

This is the Google style:

https://google.github.io/styleguide/cppguide.html#Reference_Arguments

I think it makes sense. You see right at the calling place, that a parameter may be modified.

--
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.hu...@embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Reply via email to