Re: [PATCH] libio: Remove special-case reference count

2017-09-13 Thread Gedare Bloom
On Tue, Sep 12, 2017 at 1:04 AM, Sebastian Huber wrote: > > > On 11/09/17 20:34, Gedare Bloom wrote: >> >> On Fri, Sep 8, 2017 at 1:04 AM, Sebastian Huber >> wrote: >>> >>> On 08/09/17 00:08, Gedare Bloom wrote: >>> I understand the motivation. I need to look carefully at whether this

Re: [PATCH] libio: Remove special-case reference count

2017-09-11 Thread Sebastian Huber
On 11/09/17 20:34, Gedare Bloom wrote: The mmap() implementation has some other problems. It contains too many conditionals. It doesn't follow the object oriented design of the file system layer. The mmap() is basically a factory. The mmap_h handler should construct a mapping object. A destructo

Re: [PATCH] libio: Remove special-case reference count

2017-09-11 Thread Sebastian Huber
On 11/09/17 20:34, Gedare Bloom wrote: On Fri, Sep 8, 2017 at 1:04 AM, Sebastian Huber wrote: On 08/09/17 00:08, Gedare Bloom wrote: I understand the motivation. I need to look carefully at whether this breaks the special case, and how to otherwise fix it. The change didn't introduce test

Re: [PATCH] libio: Remove special-case reference count

2017-09-11 Thread Gedare Bloom
On Fri, Sep 8, 2017 at 1:04 AM, Sebastian Huber wrote: > On 08/09/17 00:08, Gedare Bloom wrote: > >> I understand the motivation. I need to look carefully at whether this >> breaks the special case, and how to otherwise fix it. > > > The change didn't introduce test suite failures. > Yeah, I negle

Re: [PATCH] libio: Remove special-case reference count

2017-09-07 Thread Sebastian Huber
On 08/09/17 00:08, Gedare Bloom wrote: I understand the motivation. I need to look carefully at whether this breaks the special case, and how to otherwise fix it. The change didn't introduce test suite failures. The mmap() implementation has some other problems. It contains too many conditio

Re: [PATCH] libio: Remove special-case reference count

2017-09-07 Thread Gedare Bloom
I understand the motivation. I need to look carefully at whether this breaks the special case, and how to otherwise fix it. On Wed, Sep 6, 2017 at 2:27 AM, Sebastian Huber wrote: > The top-level IO library structures should contain no special-case data. > > Update #2859. > --- > cpukit/libcsuppo

[PATCH] libio: Remove special-case reference count

2017-09-05 Thread Sebastian Huber
The top-level IO library structures should contain no special-case data. Update #2859. --- cpukit/libcsupport/include/rtems/libio.h| 1 - cpukit/libcsupport/include/rtems/libio_.h | 41 - cpukit/libcsupport/src/libio.c | 32 ++ c