On 08/09/17 00:08, Gedare Bloom wrote:
I understand the motivation. I need to look carefully at whether this
breaks the special case, and how to otherwise fix it.
The change didn't introduce test suite failures.
The mmap() implementation has some other problems. It contains too many
conditionals. It doesn't follow the object oriented design of the file
system layer. The mmap() is basically a factory. The mmap_h handler
should construct a mapping object. A destructor is currently missing.
Maybe the mmap_h handler should use a flag to deal with construction and
destruction.
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.hu...@embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
