Re: [PATCH] improved error checking in ticks per timeslice

On 18.03.24 21:31, Kinsey Moore wrote: Sorry, I didn't realize I had tests turned off in my local build when I checked this. The test is now gated behind NEEDS_CLOCK_DRIVER as well. This is fine for fixing the build, but I would rather fix the tests. Applications may have there own clock drive

Re: [PATCH] improved error checking in ticks per timeslice

No. Just a lesson to remember -- Everyone along the path should have built rtems with all tests enabled. This is something that should never happen after the upcoming transition to GitLab. It definitely shows we need to build at least one BSP with tests enabled. On Mon, Mar 18, 2024, 7:45 PM zac

Re: [PATCH] improved error checking in ticks per timeslice

Do I need to do anything? On Mon, 18 Mar 2024 at 16:38, Kinsey Moore wrote: > Sorry, I didn't realize I had tests turned off in my local build when I > checked this. The test is now gated behind NEEDS_CLOCK_DRIVER as well. > > Kinsey > > On Mon, Mar 18, 2024 at 4:15 AM Sebastian Huber < > seba

Re: [PATCH] improved error checking in ticks per timeslice

Sorry, I didn't realize I had tests turned off in my local build when I checked this. The test is now gated behind NEEDS_CLOCK_DRIVER as well. Kinsey On Mon, Mar 18, 2024 at 4:15 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > This patch breaks the build: > > In file included f

Re: [PATCH] improved error checking in ticks per timeslice

This patch breaks the build: In file included from ../../../cpukit/include/rtems/confdefs.h:64, from ../../../testsuites/rhealstone/rhdeadlockbrk/deadlockbrk.c:215: ../../../cpukit/include/rtems/confdefs/clock.h:74:4: error: #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greate

Re: [PATCH] improved error checking in ticks per timeslice

It should be in the repo now. On Thu, Mar 14, 2024 at 12:50 PM zack leung wrote: > Did you check in the code? > > Il mar 12 mar 2024, 21:55 Kinsey Moore ha > scritto: > >> Sorry, I missed this in the deluge of emails. Looks good to me. >> >> Kinsey >> >> On Tue, Mar 12, 2024 at 8:17 PM zack leu

Re: [PATCH] improved error checking in ticks per timeslice

Did you check in the code? Il mar 12 mar 2024, 21:55 Kinsey Moore ha scritto: > Sorry, I missed this in the deluge of emails. Looks good to me. > > Kinsey > > On Tue, Mar 12, 2024 at 8:17 PM zack leung > wrote: > >> ping >> >> On Fri, 8 Mar 2024 at 22:03, wrote: >> >>> From: Zack leung >>> >>

Re: [PATCH] improved error checking in ticks per timeslice

Sorry, I missed this in the deluge of emails. Looks good to me. Kinsey On Tue, Mar 12, 2024 at 8:17 PM zack leung wrote: > ping > > On Fri, 8 Mar 2024 at 22:03, wrote: > >> From: Zack leung >> >> --- >> cpukit/doxygen/appl-config.h | 3 +-- >> cpukit/include/rtems/confdefs/clock.h |

Re: [PATCH] improved error checking in ticks per timeslice

ping On Fri, 8 Mar 2024 at 22:03, wrote: > From: Zack leung > > --- > cpukit/doxygen/appl-config.h | 3 +-- > cpukit/include/rtems/confdefs/clock.h | 4 > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/cpukit/doxygen/appl-config.h b/cpukit/doxygen/appl-config.h

[PATCH] improved error checking in ticks per timeslice

From: Zack leung --- cpukit/doxygen/appl-config.h | 3 +-- cpukit/include/rtems/confdefs/clock.h | 4 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/cpukit/doxygen/appl-config.h b/cpukit/doxygen/appl-config.h index bd7cde628f..f843ebbd39 100644 --- a/cpukit/doxygen/

Re: [PATCH] improved error checking in ticks per timeslice

Hey Zack, Sebastian posted exactly what he thought those lines should be to match the surrounding coding style: #if defined(CONFIGURE_TICKS_PER_TIMESLICE) && CONFIGURE_TICKS_PER_TIMESLICE <= 0 It should just be a single #if like that and with that order of conditionals. You'll of course need to

Re: [PATCH] improved error checking in ticks per timeslice

Hey i've replied with another patch :) On Tue, 5 Mar 2024 at 10:42, Kinsey Moore wrote: > Zack, > It looks like there's been a little confusion here. Sebastian was > requesting that you condense the pair of #ifs into a single #if with && and > the defined check still coming first. It is mostly t

[PATCH] improved error checking in ticks per timeslice

From: Zack leung diff --git a/cpukit/doxygen/appl-config.h b/cpukit/doxygen/appl-config.h index bd7cde628f..d480eb3971 100644 --- a/cpukit/doxygen/appl-config.h +++ b/cpukit/doxygen/appl-config.h @@ -3312,7 +3312,7 @@ * @parblock * The following constraints apply to this configuration option:

Re: [PATCH] improved error checking in ticks per timeslice

Zack, It looks like there's been a little confusion here. Sebastian was requesting that you condense the pair of #ifs into a single #if with && and the defined check still coming first. It is mostly trivial in this instance, but virtually every other example in the related files is of a multi-condi

Re: [PATCH] improved error checking in ticks per timeslice

ping On Tue, 27 Feb 2024 at 21:33, zack leung wrote: > > joel said: >+#if CONFIGURE_TICKS_PER_TIMESLICE <= 0 && > > defined(CONFIGURE_TICKS_PER_TIMESLICE) > > + #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero" > > +#endif > > + > > > > > > This is modifying

Re: [PATCH] improved error checking in ticks per timeslice

joel said: +#if CONFIGURE_TICKS_PER_TIMESLICE <= 0 && > defined(CONFIGURE_TICKS_PER_TIMESLICE) > + #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero" > +#endif > + > > > This is modifying the right file but I think it is safer to check that > it is defined > befor

Re: [PATCH] improved error checking in ticks per timeslice

On 19.02.24 03:13, zakthertems...@gmail.com wrote: +#if defined(CONFIGURE_TICKS_PER_TIMESLICE) + #if CONFIGURE_TICKS_PER_TIMESLICE <= 0 +#error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero" + #endif +#endif This should be #if defined(CONFIGURE_TICKS_PER_TIMESLICE) && CONFIG

Re: [PATCH] improved error checking in ticks per timeslice

ping On Tue, 20 Feb 2024 at 20:25, zack leung wrote: > ping > > On Sun, 18 Feb 2024 at 21:15, wrote: > >> --- >> cpukit/doxygen/appl-config.h | 2 +- >> cpukit/include/rtems/confdefs/clock.h | 6 ++ >> 2 files changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/cpukit/doxy

Re: [PATCH] improved error checking in ticks per timeslice

ping On Sun, 18 Feb 2024 at 21:15, wrote: > --- > cpukit/doxygen/appl-config.h | 2 +- > cpukit/include/rtems/confdefs/clock.h | 6 ++ > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/cpukit/doxygen/appl-config.h b/cpukit/doxygen/appl-config.h > index bd7cde628f..

Re: [PATCH] improved error checking in ticks per timeslice

On Sun, Feb 18, 2024 at 3:31 PM Chris Johns wrote: > > On 18/2/2024 4:42 am, Gedare Bloom wrote: > > Is there a simple way we can add some checks for modification of > > generated files into a commit hook? And then, point to a documentation > > that helps explain where to go for more guidance depe

[PATCH] improved error checking in ticks per timeslice

--- cpukit/doxygen/appl-config.h | 2 +- cpukit/include/rtems/confdefs/clock.h | 6 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/cpukit/doxygen/appl-config.h b/cpukit/doxygen/appl-config.h index bd7cde628f..d480eb3971 100644 --- a/cpukit/doxygen/appl-config.h +++ b

Re: [PATCH] improved error checking in ticks per timeslice

On 18/2/2024 4:42 am, Gedare Bloom wrote: > Is there a simple way we can add some checks for modification of > generated files into a commit hook? And then, point to a documentation > that helps explain where to go for more guidance depending on the code > generation source? We are moving to GitLa

[PATCH] improved error checking in ticks per timeslice

From: Zack leung diff --git a/cpukit/doxygen/appl-config.h b/cpukit/doxygen/appl-config.h index bd7cde628f..d480eb3971 100644 --- a/cpukit/doxygen/appl-config.h +++ b/cpukit/doxygen/appl-config.h @@ -3312,7 +3312,7 @@ * @parblock * The following constraints apply to this configuration option:

Re: [PATCH] improved error checking in ticks per timeslice

On Sat, Feb 17, 2024 at 10:35 AM Sebastian Huber wrote: > > On 17.02.24 18:11, Joel Sherrill wrote: > > > > On Wed, Feb 14, 2024, 9:54 PM zack leung > > wrote: > > > > > This file is generated from something in rtems-central. This was at > > the > > > top

Re: [PATCH] improved error checking in ticks per timeslice

On 17.02.24 18:11, Joel Sherrill wrote: On Wed, Feb 14, 2024, 9:54 PM zack leung > wrote: > This file is generated from something in rtems-central. This was at the > top of the file: > >   * This file is part of the RTEMS quality process and w

Re: [PATCH] improved error checking in ticks per timeslice

On Wed, Feb 14, 2024, 9:54 PM zack leung wrote: > > This file is generated from something in rtems-central. This was at the > > top of the file: > > > > * This file is part of the RTEMS quality process and was automatically > > * generated. If you find something that needs to be fixed or > >

Re: [PATCH] improved error checking in ticks per timeslice

> This file is generated from something in rtems-central. This was at the > top of the file: > > * This file is part of the RTEMS quality process and was automatically > * generated. If you find something that needs to be fixed or > * worded better please post a report or patch to an RTEMS

Re: [PATCH] improved error checking in ticks per timeslice

On 14.02.24 15:18, Joel Sherrill wrote: I'm cc'ing Sebastian because you edited the text in a generated file. He should be able to point us to the right place to fix it. On Mon, Feb 12, 2024 at 8:26 PM > wrote: From: Zack leung mailto:z.liang...@gmail.co

Re: [PATCH] improved error checking in ticks per timeslice

I'm cc'ing Sebastian because you edited the text in a generated file. He should be able to point us to the right place to fix it. On Mon, Feb 12, 2024 at 8:26 PM wrote: > From: Zack leung > > diff --git a/cpukit/doxygen/appl-config.h b/cpukit/doxygen/appl-config.h > index bd7cde628f..d480eb3971

[PATCH] improved error checking in ticks per timeslice

From: Zack leung diff --git a/cpukit/doxygen/appl-config.h b/cpukit/doxygen/appl-config.h index bd7cde628f..d480eb3971 100644 --- a/cpukit/doxygen/appl-config.h +++ b/cpukit/doxygen/appl-config.h @@ -3312,7 +3312,7 @@ * @parblock * The following constraints apply to this configuration option:

[PATCH] improved error checking in ticks per timeslice

From: Zack leung diff --git a/cpukit/doxygen/appl-config.h b/cpukit/doxygen/appl-config.h index bd7cde628f..d480eb3971 100644 --- a/cpukit/doxygen/appl-config.h +++ b/cpukit/doxygen/appl-config.h @@ -3312,7 +3312,7 @@ * @parblock * The following constraints apply to this configuration option: