Re: Subject: [PATCH] improve the format error reporting on i386

2021-09-10 Thread Joel Sherrill
I have chatted with Zack a fair amount about this series of patches. I wanted to get on the mailing list to make sure some things got done as intended. hex numbers (%x) should be preceded by 0x. The format string would be like 0x%x Many hex numbers (e.g. task IDs, registers, etc) should be print

Re: Subject: [PATCH] improve the format error reporting on i386

2021-09-10 Thread Gedare Bloom
Hi Zack, Use git-rebase --interactive option, and reword the commit message. The email comes through with an additional subject line, I'm not sure if that is intended. You don't need to repeat the first line of the commit message. It seems like the commit message you have used is: --- improve the

Re: Subject: [PATCH] improve the format error reporting on i386

2021-09-10 Thread zack leung
Where are the duplicates been trying to fix the commit messages? Thanks zack Il gio 9 set 2021, 22:30 Gedare Bloom ha scritto: > Hi Zack, > > It looks like something got a little messed up with your commit > message. Please see if you can fix it to remove the duplication(s). > > On Thu, Sep 9,

Re: Subject: [PATCH] improve the format error reporting on i386

2021-09-09 Thread Gedare Bloom
Hi Zack, It looks like something got a little messed up with your commit message. Please see if you can fix it to remove the duplication(s). On Thu, Sep 9, 2021 at 6:00 PM zack leung wrote: > > score/i386: improve the format of exception reporting > > Updates #4203."Updates #4203." > --- > cpuki

Subject: [PATCH] improve the format error reporting on i386

2021-09-09 Thread zack leung
score/i386: improve the format of exception reporting Updates #4203."Updates #4203." --- cpukit/score/cpu/i386/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/score/cpu/i386/cpu.c b/cpukit/score/cpu/i386/cpu.c index 77b7a7161c..06af57418d 100644 --- a/cpukit/score/c

Re: [PATCH] improve the format error reporting on i386

2021-09-08 Thread Gedare Bloom
On Tue, Sep 7, 2021 at 6:17 PM Zacchaeus Leung wrote: > > --- > cpukit/score/cpu/i386/cpu.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/cpukit/score/cpu/i386/cpu.c b/cpukit/score/cpu/i386/cpu.c > index 77b7a7161c..3c5b7db316 100644 > --- a/cpukit/score/cpu/i386/

Re: [PATCH] improve the format error reporting on i386

2021-09-07 Thread zack leung
- thread id is printed as a hex value - EBP ESP is now printed as a address pointer %p - Program counter is printed as a pinter Part of ticket #4203 On Wed, 8 Sept 2021 at 00:17, Zacchaeus Leung wrote: > --- > cpukit/score/cpu/i386/cpu.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletion

[PATCH] improve the format error reporting on i386

2021-09-07 Thread Zacchaeus Leung
--- cpukit/score/cpu/i386/cpu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cpukit/score/cpu/i386/cpu.c b/cpukit/score/cpu/i386/cpu.c index 77b7a7161c..3c5b7db316 100644 --- a/cpukit/score/cpu/i386/cpu.c +++ b/cpukit/score/cpu/i386/cpu.c @@ -215,7 +215,7 @@ void _CPU_