I have chatted with Zack a fair amount about this series of patches. I wanted to get on the mailing list to make sure some things got done as intended.
hex numbers (%x) should be preceded by 0x. The format string would be like 0x%x Many hex numbers (e.g. task IDs, registers, etc) should be printed in hex with leading zeros. This would be like 0x%08x or 0x%08 PRIx I think. Exception numbers should be printed along with a short string explanation. For the x86, I think (emphasis that someone should check a real manual) that this page includes a table with numbers and fault names: https://en.wikipedia.org/wiki/Interrupt_descriptor_table Some of the exception handler output will be bespoke to the architecture but the part about the task Id, RTEMS version, etc should be identical across all architectures and possibly should be a helper method to ensure this. Zack. Did your hit those points? --joel On Fri, Sep 10, 2021 at 9:20 AM Gedare Bloom <ged...@rtems.org> wrote: > > Hi Zack, > > Use git-rebase --interactive option, and reword the commit message. > The email comes through with an additional subject line, I'm not sure > if that is intended. You don't need to repeat the first line of the > commit message. It seems like the commit message you have used is: > --- > improve the format error reporting on i386 > score/i386: improve the format of exception reporting > > Updates #4203."Updates #4203." > --- > You should modify that commit message, and regenerate the patch/email. > > -Gedare > > On Fri, Sep 10, 2021 at 7:07 AM zack leung <zakthertems...@gmail.com> wrote: > > > > Where are the duplicates been trying to fix the commit messages? > > > > Thanks zack > > Il gio 9 set 2021, 22:30 Gedare Bloom <ged...@rtems.org> ha scritto: > >> > >> Hi Zack, > >> > >> It looks like something got a little messed up with your commit > >> message. Please see if you can fix it to remove the duplication(s). > >> > >> On Thu, Sep 9, 2021 at 6:00 PM zack leung <zakthertems...@gmail.com> wrote: > >> > > >> > score/i386: improve the format of exception reporting > >> > > >> > Updates #4203."Updates #4203." > >> > --- > >> > cpukit/score/cpu/i386/cpu.c | 2 +- > >> > 1 file changed, 1 insertion(+), 1 deletion(-) > >> > > >> > diff --git a/cpukit/score/cpu/i386/cpu.c b/cpukit/score/cpu/i386/cpu.c > >> > index 77b7a7161c..06af57418d 100644 > >> > --- a/cpukit/score/cpu/i386/cpu.c > >> > +++ b/cpukit/score/cpu/i386/cpu.c > >> > @@ -215,7 +215,7 @@ void _CPU_Exception_frame_print (const > >> > CPU_Exception_frame *ctx) > >> > { > >> > unsigned int faultAddr = 0; > >> > printk("----------------------------------------------------------\n"); > >> > - printk("Exception %" PRIu32 " caught at PC %" PRIx32 " by thread %" > >> > PRId32 "\n", > >> > + printk("Exception %" PRIu32 " caught at PC %" PRIx32 " by thread %" > >> > PRIx32 "\n", > >> > ctx->idtIndex, > >> > ctx->eip, > >> > _Thread_Executing->Object.id); > >> > -- > >> > 2.33.0 > >> > _______________________________________________ > >> > devel mailing list > >> > devel@rtems.org > >> > http://lists.rtems.org/mailman/listinfo/devel > _______________________________________________ > devel mailing list > devel@rtems.org > http://lists.rtems.org/mailman/listinfo/devel _______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
