Re: [PATCH] covoar: Add symbol set reader and ELF data parser to covoar.

2018-04-29 Thread Chris Johns
On 30/04/2018 15:38, Cillian O'Donnell wrote: > On Sun, 29 Apr 2018, 23:30 Chris Johns, > wrote: > > On 29/04/2018 20:50, Cillian O'Donnell wrote: > > On 28 April 2018 at 08:08, Chris Johns > >

Re: [PATCH] covoar: Add symbol set reader and ELF data parser to covoar.

2018-04-29 Thread Cillian O'Donnell
On Sun, 29 Apr 2018, 23:30 Chris Johns, wrote: > On 29/04/2018 20:50, Cillian O'Donnell wrote: > > On 28 April 2018 at 08:08, Chris Johns > > wrote: > > + for (const std::string set : sets) { > > +if (verbose) > > + std::cerr << " Symbol

Re: [PATCH] covoar: Add symbol set reader and ELF data parser to covoar.

2018-04-29 Thread Chris Johns
On 29/04/2018 20:50, Cillian O'Donnell wrote: > On 28 April 2018 at 08:08, Chris Johns > wrote: > +      for (const std::string set : sets) { > +        if (verbose) > +          std::cerr << " Symbol set: " << set << std::endl; > +        const rld::config

Re: [PATCH] covoar: Add symbol set reader and ELF data parser to covoar.

2018-04-29 Thread Cillian O'Donnell
On 28 April 2018 at 08:08, Chris Johns wrote: > From: Cillian O'Donnell > > Add ability to organize symbol sets of libraries in INI file > and then read them with covoar and load the symbols directly from the > libraries. > > rtems-tools/../testing: Add configuration files for coverage analysis.

Re: [PATCH] covoar: Add symbol set reader and ELF data parser to covoar.

2018-04-28 Thread Chris Johns
On 29/4/18 10:24 am, Joel Sherrill wrote: > On Sat, Apr 28, 2018, 6:31 PM Chris Johns > wrote: > > On 29/4/18 8:27 am, Cillian O'Donnell wrote: > > > > > > On Sat, 28 Apr 2018, 20:39 Vijay Kumar Banerjee, > > > <

Re: [PATCH] covoar: Add symbol set reader and ELF data parser to covoar.

2018-04-28 Thread Joel Sherrill
On Sat, Apr 28, 2018, 6:31 PM Chris Johns wrote: > On 29/4/18 8:27 am, Cillian O'Donnell wrote: > > > > > > On Sat, 28 Apr 2018, 20:39 Vijay Kumar Banerjee, < > vijaykumar9...@gmail.com > > > wrote: > > > > > > This is the log file that I'm getting after runni

Re: [PATCH] covoar: Add symbol set reader and ELF data parser to covoar.

2018-04-28 Thread Chris Johns
On 29/4/18 2:24 am, Cillian O'Donnell wrote: > On 28 April 2018 at 08:08, Chris Johns > wrote: > > --- a/tester/rtems/testing/qemu.cfg > +++ b/tester/rtems/testing/qemu.cfg > @@ -54,14 +54,23 @@ >  #%define qemu_opts_base   -no-reboot -monitor none -serial

Re: [PATCH] covoar: Add symbol set reader and ELF data parser to covoar.

2018-04-28 Thread Chris Johns
On 29/4/18 8:27 am, Cillian O'Donnell wrote: > > > On Sat, 28 Apr 2018, 20:39 Vijay Kumar Banerjee, > wrote: > > > This is the log file that I'm getting after running the test > > I'm getting  a lot of 'invalid' results , am I missing something ? > >

Re: [PATCH] covoar: Add symbol set reader and ELF data parser to covoar.

2018-04-28 Thread Vijay Kumar Banerjee
On Sun, 29 Apr 2018, 03:57 Cillian O'Donnell, wrote: > > > On Sat, 28 Apr 2018, 20:39 Vijay Kumar Banerjee, > wrote: > >> >> This is the log file that I'm getting after running the test >> >> I'm getting a lot of 'invalid' results , am I missing something ? >> > > What we had in coverage.py and

Re: [PATCH] covoar: Add symbol set reader and ELF data parser to covoar.

2018-04-28 Thread Cillian O'Donnell
On Sat, 28 Apr 2018, 20:39 Vijay Kumar Banerjee, wrote: > > This is the log file that I'm getting after running the test > > I'm getting a lot of 'invalid' results , am I missing something ? > What we had in coverage.py and test.py will need to be updated with Chris' change to covoar. It's prob

Re: [PATCH] covoar: Add symbol set reader and ELF data parser to covoar.

2018-04-28 Thread Vijay Kumar Banerjee
This is the log file that I'm getting after running the test I'm getting a lot of 'invalid' results , am I missing something ? after this patch along with with the c++ cleanup patch, we have to start working on parsing the coverage right? RTEMS Testing - Tester, 5 (0e93af6a88b8 modified) Comman

Re: [PATCH] covoar: Add symbol set reader and ELF data parser to covoar.

2018-04-28 Thread Vijay Kumar Banerjee
On 29 April 2018 at 00:04, Cillian O'Donnell wrote: > > > On 28 April 2018 at 17:29, Vijay Kumar Banerjee > wrote: > >> I'm getting the following error after applying the patch: >> > > Did you apply it to the current rtems-tools master? It's building fine for > me. > >> >> oh , it wasn't the cur

Re: [PATCH] covoar: Add symbol set reader and ELF data parser to covoar.

2018-04-28 Thread Cillian O'Donnell
On 28 April 2018 at 17:29, Vijay Kumar Banerjee wrote: > I'm getting the following error after applying the patch: > Did you apply it to the current rtems-tools master? It's building fine for me. > > - > ./waf build install > Waf: Entering directory `/home/lunatic/development/ > rtems/test/

Re: [PATCH] covoar: Add symbol set reader and ELF data parser to covoar.

2018-04-28 Thread Vijay Kumar Banerjee
I'm getting the following error after applying the patch: - ./waf build install Waf: Entering directory `/home/lunatic/development/rtems/test/rtems-tools/build' Traceback (most recent call last): File "/home/lunatic/development/rtems/test/rtems-tools/.waf-1.9.9-75529a659e4f06cb4254801e52405e

Re: [PATCH] covoar: Add symbol set reader and ELF data parser to covoar.

2018-04-28 Thread Cillian O'Donnell
On 28 April 2018 at 08:08, Chris Johns wrote: > From: Cillian O'Donnell > > Add ability to organize symbol sets of libraries in INI file > and then read them with covoar and load the symbols directly from the > libraries. > > rtems-tools/../testing: Add configuration files for coverage analysis.

[PATCH] covoar: Add symbol set reader and ELF data parser to covoar.

2018-04-28 Thread Chris Johns
From: Cillian O'Donnell Add ability to organize symbol sets of libraries in INI file and then read them with covoar and load the symbols directly from the libraries. rtems-tools/../testing: Add configuration files for coverage analysis. A number of covoar options are not required and are defaul