Re: [PATCH] Add low level event recording support

2019-01-29 Thread Chris Johns
On 29/1/19 7:40 pm, Sebastian Huber wrote: > On 29/01/2019 09:27, Chris Johns wrote: >> On 28/1/19 9:55 pm, Sebastian Huber wrote: >>> how do we want to proceed with this? >>> >> You have answered my concerns and I am happy with what you are doing and this >> piece of code. > > Thanks for your rev

Re: [PATCH] Add low level event recording support

2019-01-29 Thread Sebastian Huber
On 29/01/2019 09:27, Chris Johns wrote: On 28/1/19 9:55 pm, Sebastian Huber wrote: how do we want to proceed with this? You have answered my concerns and I am happy with what you are doing and this piece of code. Thanks for your review and comments. I look forward to seeing the trace code

Re: [PATCH] Add low level event recording support

2019-01-29 Thread Chris Johns
On 28/1/19 9:55 pm, Sebastian Huber wrote: > > how do we want to proceed with this? > You have answered my concerns and I am happy with what you are doing and this piece of code. I look forward to seeing the trace code being moved into libtrace or something like this and seeing it grow as a uni

Re: [PATCH] Add low level event recording support

2019-01-28 Thread Sebastian Huber
Hello Chris, how do we want to proceed with this? -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47 41-09 E-Mail : sebastian.hu...@embedded-brains.de PGP : Public key available on request. Dies

Re: [PATCH] Add low level event recording support

2019-01-22 Thread Sebastian Huber
On 23/01/2019 08:23, Chris Johns wrote: I am OK with something new and better but we need to make sure what we offer is consistent and makes sense to users. I am concerned users will become confused if we have multiple approaches with separate code, set up, post processing and documentation. I am

Re: [PATCH] Add low level event recording support

2019-01-22 Thread Chris Johns
On 23/1/19 6:13 pm, Sebastian Huber wrote: > On 23/01/2019 07:49, Chris Johns wrote: >> On 23/1/19 12:34 am, Sebastian Huber wrote: >>> Hello Chris, >>> >>> On 20/12/2018 07:46, Sebastian Huber wrote: > Sorry but I have no time to review this and consider it until next year. No problem, ta

Re: [PATCH] Add low level event recording support

2019-01-22 Thread Sebastian Huber
On 23/01/2019 07:49, Chris Johns wrote: On 23/1/19 12:34 am, Sebastian Huber wrote: Hello Chris, On 20/12/2018 07:46, Sebastian Huber wrote: Sorry but I have no time to review this and consider it until next year. No problem, take your time. I work on this since April this year from time to t

Re: [PATCH] Add low level event recording support

2019-01-22 Thread Chris Johns
On 23/1/19 12:34 am, Sebastian Huber wrote: > Hello Chris, > > On 20/12/2018 07:46, Sebastian Huber wrote: >>> >>> Sorry but I have no time to review this and consider it until next year. >> >> No problem, take your time. I work on this since April this year from time to >> time, so it can wait a

Re: [PATCH] Add low level event recording support

2019-01-22 Thread Sebastian Huber
Hello Chris, On 20/12/2018 07:46, Sebastian Huber wrote: Sorry but I have no time to review this and consider it until next year. No problem, take your time. I work on this since April this year from time to time, so it can wait a couple of more weeks. had you time to look at this? The f

Re: [PATCH] Add low level event recording support

2018-12-20 Thread Chris Johns
On 20/12/2018 17:46, Sebastian Huber wrote: > My use case for this is a nasty bug. The capture engine was the result of a bug a long time ago. :) > No problem, take your time. I work on this since April this year from time to > time, so it can wait a couple of more weeks. Thank you, I appreciate

Re: [PATCH] Add low level event recording support

2018-12-19 Thread Sebastian Huber
On 20/12/2018 01:46, Chris Johns wrote: I have read the ticket and not the patch. On 20/12/2018 08:00, Joel Sherrill wrote: How does this relate.to the existing infrastructure for the capture engine? It seems duplicative. Yes it is confusing. With this change we would have 3

Re: [PATCH] Add low level event recording support

2018-12-19 Thread Chris Johns
I have read the ticket and not the patch. On 20/12/2018 08:00, Joel Sherrill wrote: > How does this relate.to the existing infrastructure for the > capture engine? It seems duplicative. Yes it is confusing. With this change we would have 3 possible trace systems, the capture en

[PATCH] Add low level event recording support

2018-12-19 Thread Sebastian Huber
Add low level event recording infrastructure for system and user defined events. The infrastructure is able to record high frequency events such as * SMP lock acquire/release, * interrupt entry/exit, * thread switches, * UMA zone allocate/free, and * Ethernet packet input/output, etc. It al