Re: GSOC student question

2017-05-26 Thread Ben Gras
Dear all, On 05/22/2017 11:56 AM, Joel Sherrill wrote: > > > On Mon, May 22, 2017 at 10:11 AM, Gedare Bloom > wrote: > > I think the i2c was developed and tested only on the BeagleBone Black. > I don't think anyone has used the xm yet, though I could be mistaken.

Re: [PATCH] modify punitvara's works on BBB i2c, and now can read the eeprom info.

2017-03-20 Thread Ben Gras
Dear all, SZ, great initiative. Gedare and Sebastian have commented. For my part, can I just check - the implementation is supposed to be generic to i2c devices, correct? If so, can you explain what read_eeprom is for? Is it just as demo? Is the code generic otherwise? Cheers, Ben On 03/14/2

Re: Building toolset for Beaglebone with RSB fails (for me).

2017-02-10 Thread Ben Gras
All, I see, yes. Noted. I will try to find time for this soon but it may be a little while. Ben On 02/10/2017 03:24 PM, Joel Sherrill wrote: > GCC does not keep snapshots forever. Ben's instructions and git repo > must be behind the master at git.rtems.org . > clone the re

Re: I2C testcase linking error

2016-07-24 Thread Ben Gras
once I saw this does link :-) On 24-07-16 09:06, punit vara wrote: > https://github.com/punitvara/rtems/tree/new > > You can reproduce linking error from this new branch. > > On Sat, Jul 23, 2016 at 11:57 PM, Ben Gras <mailto:b...@shrike-systems.com>> wrote: > >

Re: I2C testcase linking error

2016-07-23 Thread Ben Gras
All, I tried to reproduce this. The I2C branch of your repo doesn't build because of struct i2c not being defined. So I #if 0'd out all the function bodies in i2c.c, and then everything builds, without linker errors. What is your state now? Are you blocked on this (or anything else) still? If so

[PATCH] beagle: pwm polishing

2016-07-17 Thread Ben Gras
From: Punit Vara . added a README to pwm . added select_pwmss() to select pwmss-generic registers, as opposed to PWM-specific registers . added pwmss_clock_en_status() and pwmss_tb_clock_check() . other API improvements . style improvements --- c

Re: [PATCH v3 2/2] Subject: Update PWM driver imported from BBBIO

2016-07-04 Thread Ben Gras
All, On Mon, Jul 4, 2016 at 8:58 PM, Martin Galvan wrote: > Tested and built successfully, so I pushed both patches: > > https://git.rtems.org/rtems/commit/?id=6dc5c03fad3ddd51423d21b5d60d24b62bb653e9 > https://git.rtems.org/rtems/commit/?id=5e3096db5a1d766ece4068fbfe625c8a3db31b23 > > Congratula

Re: [PATCH v3 2/2] Subject: Update PWM driver imported from BBBIO

2016-07-02 Thread Ben Gras
All, On Fri, Jul 1, 2016 at 11:12 PM, Martin Galvan wrote: > Hi Punit, thanks for the patch. As we spoke in the group chat with the other > mentors, this seems to > be good for a first version. I'll be pointing out the required changes for > the next version, but > unless somebody sees anything

Re: [PATCH] Beaglebone: Fix the IRQ handling code

2016-02-27 Thread Ben Gras
All, I tested this on current HEAD and verified it fixes a case I'd ran into trouble with before, namely gpio-triggered irqs. Great to see. I pushed your change with a commit message based on your original email, Martin. I hope you like it. Thank you! On Sat, Feb 27, 2016 at 10:16 PM, Ben

Re: [PATCH] Beaglebone: Fix the IRQ handling code

2016-02-27 Thread Ben Gras
e: >> Thanks Ben! Indeed, any further testing is more than welcome :) >> >> On Thu, Feb 11, 2016 at 7:55 PM, Ben Gras wrote: >>> This looks like great work. Please let me test it (I'll try the GPIO >>> interrupt trigger) & I'll merge it as soon as

Re: [PATCH] Beaglebone: Fix the IRQ handling code

2016-02-11 Thread Ben Gras
This looks like great work. Please let me test it (I'll try the GPIO interrupt trigger) & I'll merge it as soon as I have time. Thank you! Cheers, Ben On Thu, Feb 11, 2016 at 3:27 PM, Martin Galvan wrote: > This patch makes the following changes to the Beaglebone IRQ handling code: > > - Disab

[PATCH] fail gracefully when pax is not found

2015-10-22 Thread Ben Gras
https://devel.rtems.org/ticket/2437 Attachment to that ticket is a clean fix for: If pax is not found by configure, the empty PAX variable is used in e.g. this line: $(PAX) -w -f $@ $< Causing the 'w' command to be invoked: 21:37:25 up 6 min, 3 users, load average: 1,90, 1,14, 0,49 USER TTY L

Re: [PATCH] Fixes GPIO APIs Naming Convention and Comments

2015-10-21 Thread Ben Gras
o I copied the contents of the patch to this mail message. >> Could you try using the patch attached in my first mail? >> >> Also, does this require a ticket? >> >> Thanks and Regards, >> Sudarshan >> >> >>> >>> On Tue, Oct 13, 2

Re: [PATCH] Fixes GPIO APIs Naming Convention and Comments

2015-10-13 Thread Ben Gras
All, This change renames these gpio-specific functions: rtems_bsp_enable_interrupt rtems_bsp_disable_interrupt rtems_bsp_select_specific_io to rtems_gpio_bsp_enable_interrupt rtems_gpio_bsp_disable_interrupt rtems_gpio_bsp_select_specific_io +1, Definitely an improvement. On Mon, Oct 12, 20

BBB GPIO status

2015-08-18 Thread Ben Gras
All, I built & tested & pushed Ketul's GPIO BBB implementation, it's working nicely with the generic GPIO layer. Remaining to get working: - IRQ-triggering in digital in - pullup configuration Well done Ketul! ___ devel mailing list devel@rtems.org

Re: [PATCH] Temporary fix for ethernet rx intr hang issue and Disable cache

2015-06-28 Thread Ben Gras
All, I really don't want to merge a line like: +if ( ! ( irq == 40 || irq == 41 || irq == 42 || irq == 43 ) ) in the generic interrupt dispatch function. At minimum, replace the IRQ numbers with descriptive macro names and comment on why it's needed and that it's temporary. On Sun, Jun 2

Re: RTC patch for BBB

2015-05-28 Thread Ben Gras
This changed is now merged. Congratulations & thank you Ragunath! On Sun, May 3, 2015 at 1:02 PM, ragu nath wrote: > Hi All, > > I have attached the RTC patch for BBB. I have addressed the comments > given for my earlier submission. > > I am having problems with sending patch using git send-email

Re: RTC patch for BBB

2015-05-17 Thread Ben Gras
All, I am happy to merge this. On May 3, 2015 1:02 PM, "ragu nath" wrote: > Hi All, > > I have attached the RTC patch for BBB. I have addressed the comments > given for my earlier submission. > > I am having problems with sending patch using git send-email. I > understand this is the preferred w

Re: [PATCH] Beagle BSP Improvements (GPIO driver)

2015-04-26 Thread Ben Gras
h out the whole thing. On Fri, Apr 24, 2015 at 7:11 PM, Joel Sherrill wrote: > > > On 4/24/2015 11:48 AM, Ben Gras wrote: >> All, >> >> Big improvement. The video shows that the bit logic for setting & >> clearing is likely sound - for the first byte at least ;

Re: [PATCH] Beagle BSP Improvements (GPIO driver)

2015-04-24 Thread Ben Gras
ic info) is more internal to the BSP, and the app would have to actively subvert the api (look in the gpio_pin struct) and is less prone to be written badly by accident (hardcoding hardware addresses in the app). Thoughts anyone? On Thu, Apr 23, 2015 at 8:35 PM, Ketul Shah wrote: > Hi all, &

Re: [PATCH] Beagle BSP Improvements (GPIO driver)

2015-04-20 Thread Ben Gras
All, Good contribution, thank you. For GSOC, this is good proof of being able to progress and get something real working based on documentation. Great! If you want this merged with mainline - which I fully encourage! - then I suggest the following should be added to/changed first: - make the

Re: Beagle bsp improvements RTC driver for beaglebone black

2015-04-04 Thread Ben Gras
All, I built & tested the change based on current master. Looks great, ragunath! I agree it's worth addressing Joel's comments. I have two more: - please check in the device read/write functions that you're getting the 'minor' argument that you expect (0), and not return valid data otherwise. -

Re: [PATCH] autoconf changes

2015-03-14 Thread Ben Gras
Ok reverted. Sorry for the noise everyone. On Sat, Mar 14, 2015 at 10:05 PM, Joel Sherrill wrote: > > > On 3/14/2015 3:44 PM, Ben Gras wrote: >> I accidentally also merged this commti when I meant to just merge the >> beagle one.e >> >> Should I revert it or is

Re: [PATCH] beagle bsp: delete TIMER_FREQ, TIMER_COUNT

2015-03-14 Thread Ben Gras
Ok done. On Sat, Mar 14, 2015 at 8:08 PM, Gedare Bloom wrote: > OK to commit. > > On Sat, Mar 14, 2015 at 1:45 PM, Ben Gras wrote: >> unused and poorly named (no prefix) and colliding with sp68. >> >> Closes #2302. >> --- >> c/src/lib/libbsp/arm/b

Re: [PATCH] autoconf changes

2015-03-14 Thread Ben Gras
I accidentally also merged this commti when I meant to just merge the beagle one. Should I revert it or is this ok to leave in? On Sat, Mar 14, 2015 at 8:08 PM, Gedare Bloom wrote: > Me too. I'm not sure why.. > > On Sat, Mar 14, 2015 at 1:44 PM, Ben Gras wrote: >> Eve

[PATCH] beagle bsp: delete TIMER_FREQ, TIMER_COUNT

2015-03-14 Thread Ben Gras
unused and poorly named (no prefix) and colliding with sp68. Closes #2302. --- c/src/lib/libbsp/arm/beagle/include/bsp.h | 4 1 file changed, 4 deletions(-) diff --git a/c/src/lib/libbsp/arm/beagle/include/bsp.h b/c/src/lib/libbsp/arm/beagle/include/bsp.h index e235efa..0e7a5ff 100644 ---

[PATCH] autoconf changes

2015-03-14 Thread Ben Gras
Everytime I ./bootstrap && ./bootstrap -p, I get these changes w.r.t. mainline. Just tried again with a new tools build. (With the prefix/bin dir first in $PATH of course.) Or is it just me? --- c/src/lib/libbsp/bfin/acinclude.m4| 4 ++-- c/src/lib/libbsp/powerpc/acinclude.m4 | 4 ++-- 2 fil

Re: I was confused

2014-12-25 Thread Ben Gras
BTW merry xmas everyone :-) On Thu, Dec 25, 2014 at 9:59 AM, Ben Gras wrote: > All, > > About qemu starting x86 executables: as Gedare said you will need some > sort of loader to load the ELF into memory (load segments to the right > place & jump into it at the right place)

Re: I was confused

2014-12-25 Thread Ben Gras
All, About qemu starting x86 executables: as Gedare said you will need some sort of loader to load the ELF into memory (load segments to the right place & jump into it at the right place). Interestingly, qemu has a multiboot-compatible (see e.g. http://www.gnu.org/software/grub/manual/multiboot/m

Re: [PATCH] fix warnings found when building beagle bsp

2014-12-15 Thread Ben Gras
Okay. On Mon, Dec 15, 2014 at 6:39 PM, Gedare Bloom wrote: > In the future try to use git-send-email if you can. Inline patches > especially this small are much easier to review. > > Go ahead and apply. > -Gedare > > On Mon, Dec 15, 2014 at 11:34 AM, Ben Gras wrote: &g

Re: [PATCH] fix warnings found when building beagle bsp

2014-12-15 Thread Ben Gras
gah. On Mon, Dec 15, 2014 at 1:48 PM, Ben Gras wrote: > The extra includes in console_*.c are to solve a 'no previous prototype' > warning. > > Solves #2212 in trac. From 5104e9abb8205394996e060669c4ce05a4d33aaf Mon Sep 17 00:00:00 2001 From: Ben Gras Date: Mon, 15 D

[PATCH] fix warnings found when building beagle bsp

2014-12-15 Thread Ben Gras
The extra includes in console_*.c are to solve a 'no previous prototype' warning. Solves #2212 in trac. ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

[PATCH] beagle bsp - disable watchdog

2014-12-04 Thread Ben Gras
From: Ben Gras Date: Thu, 4 Dec 2014 18:21:11 +0100 Subject: [PATCH] beagle bsp: disable watchdog on am335x On recent u-boots, the watchdog is turned on / left enabled. The Beaglebone Black rev. C ships with such a u-boot internally so any application booting from it must disable the watchdog

Re: [PATCH] more data structures public in mongoose.h

2014-12-02 Thread Ben Gras
15 AM, Nick Withers wrote: > On Wed, 2014-11-19 at 19:16 +0100, Ben Gras wrote: >> The attached patch is a proposed solution to a problem I am having >> with interfacing with the mongoose httpd for which I've found no >> canonical (or any other) clean solution. >>

[PATCH] fix for default configuration for pc386 bsp

2014-12-02 Thread Ben Gras
All, If USE_VBE_RM is not on, vesa_realmode_bootup_init shouldn't be referenced, but it's always defined, so the test shoudl be #if instead of #ifdef. From 97c14a7558671826bf21f323f7ee593f3e311e15 Mon Sep 17 00:00:00 2001 From: Ben Gras Date: Tue, 2 Dec 2014 23:36:59 +0100 Subject: [PA

Re: [PATCH] more data structures public in mongoose.h

2014-11-19 Thread Ben Gras
for now. I don't know if anyone is > maintaining a fork with an appropriate license. > > Moving the struct definitions to the header file is sensible, although > the usual caveat is that users might have namespace conflicts. > > Gedare > > > > On Wed, Nov 19, 2014

[PATCH] more data structures public in mongoose.h

2014-11-19 Thread Ben Gras
the changes __rtems__-conditional so it's clear where the divergence is. From 60e135fcc6ae74aa334211046b8f8cc6dd413041 Mon Sep 17 00:00:00 2001 From: Ben Gras Date: Tue, 18 Nov 2014 17:29:36 +0100 Subject: [PATCH] mongoose.h --- cpukit/mghttpd/mongoose.c | 21

Re: [PATCH] (2 commits squashed into one) Beagle BSP for review

2014-11-04 Thread Ben Gras
I just checked, it runs on the bbxm hardware too, not just the emulator. On Mon, Nov 3, 2014 at 1:20 PM, Ben Gras wrote: > All, > > Ok, as promised, I rebased and re-tested and have found & included a > portable way of making the SD card image (included in sdcard.sh), to be &

Re: [PATCH] (2 commits squashed into one) Beagle BSP for review

2014-11-03 Thread Ben Gras
Good idea, I did it. On Mon, Nov 3, 2014 at 10:32 PM, Gedare Bloom wrote: > Please send a note to rtems-users, some may be interested to hear this > addition. -Gedare > > On Mon, Nov 3, 2014 at 4:28 PM, Ben Gras wrote: > > Indeed. I did right away verify I can build & run

Re: [PATCH] (2 commits squashed into one) Beagle BSP for review

2014-11-03 Thread Ben Gras
11/3/2014 3:06 PM, Ben Gras wrote: > > All, > > > Joel merged these and I updated my blog post to reflect the mainline > repo. Thanks Joel! > > Thank you Ben for the nice submission!!! > > Now to make sure it is reproducible from here and we have merged > all t

Re: [PATCH] (2 commits squashed into one) Beagle BSP for review

2014-11-03 Thread Ben Gras
All, Joel merged these and I updated my blog post to reflect the mainline repo. Thanks Joel! On Mon, Nov 3, 2014 at 8:40 PM, Ben Gras wrote: > All, > > I have new patches with some last-minute smoothings added; removed > obsolete beagle.cfg, TODO, and separated the more generic

Re: [PATCH] (2 commits squashed into one) Beagle BSP for review

2014-08-30 Thread Ben Gras
f my comments can be done as > a follow-on commit. -Gedare > > On Thu, Jul 24, 2014 at 4:28 PM, Ben Gras wrote: > > Thanks for the fast & detailed review. Let me get back to it/you. > > > > In the meantime, any other feedback? From anyone I mean. > > > &g

Re: We should release 4.11

2014-08-21 Thread Ben Gras
All, Yes, it was posted for initial review and got some fast comments from Gedare I still have to address, then re-test. I will try to get to it ASAP. On Wed, Aug 20, 2014 at 1:23 PM, Joel Sherrill wrote: > > > On August 20, 2014 2:09:01 AM CDT, Ben Gras > wrote: > >Al

Re: We should release 4.11

2014-08-20 Thread Ben Gras
All, I'd love the Beagle BSP. I am fighting to find time to polish it, re-test it, and re-submit the patches. To decide whether that's feasible, is freezing the code for the release 'any day now' or more like 'any week now'? On Tue, Aug 19, 2014 at 11:43 PM, Joel Sherrill wrote: > > On 8/19/

Re: [PATCH] (2 commits squashed into one) Beagle BSP for review

2014-07-24 Thread Ben Gras
ribute__((aligned > (1024*16))); > commented-out.. delete it? > > +BSP_START_TEXT_SECTION void beagle_setup_mmu_and_cache(void) > __attribute__ ((weak)); > More than 80 characters. > > diff --git a/c/src/lib/libbsp/bfin/acinclude.m4 > b/c/src/lib/libbsp/bfin/acinclude.m4 >

[PATCH] Common ARM A8 code.

2014-07-15 Thread Ben Gras
From: Chris Johns --- .../libbsp/arm/shared/include/arm-a8core-start.h | 55 ++ 1 file changed, 55 insertions(+) create mode 100644 c/src/lib/libbsp/arm/shared/include/arm-a8core-start.h diff --git a/c/src/lib/libbsp/arm/shared/include/arm-a8core-start.h b/c/src/lib/libb

Re: Beagle bsp submit question

2014-07-14 Thread Ben Gras
Ok great. Yes it was gsoc and the commit mentions it. On Jul 14, 2014 8:10 PM, "Joel Sherrill" wrote: > > On Jul 14, 2014 12:27 PM, Ben Gras wrote: > > > > Dear all, > > > > I'm pretty close to be able to submit an initial version of the Beagle* &g

Beagle bsp submit question

2014-07-14 Thread Ben Gras
Dear all, I'm pretty close to be able to submit an initial version of the Beagle* bsp. I'm doing last-minute testing and commit cleanup and that's going really well. It is technically based on Claas Ziemke's GSOC BSP for the Beagleboard. Long story short, I rebased it and started hacking on it.

[PATCH] uart-output-char.h: extra offset definition.

2014-07-12 Thread Ben Gras
All, This patch is submitted as its values are used in my to-be-submitted beagle bsp. --- c/src/lib/libbsp/shared/include/uart-output-char.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/c/src/lib/libbsp/shared/include/uart-output-char.h b/c/src/lib/libbsp/shared/include/uart-output-cha

[PATCH] capture01 build broken?

2014-07-12 Thread Ben Gras
All, After a rebase of my tree capture01 didn't build (see build-error.txt). Adding #include (see assert-patch.txt) fixed it. commit abadcbfda5117f96c489ed96c98bc199c2ce8d4a Author: Ben Gras Date: Sat Jul 12 16:35:23 2014 +0200 capture01 needs assert() diff --git a/testsuites/lib