Re: [PATCH 1/2] cpukit/jffs2: Set extracted nodes off-chain

2023-09-21 Thread Sebastian Huber
On 21.09.23 18:48, Kinsey Moore wrote: On Thu, Sep 21, 2023 at 10:23 AM Sebastian Huber > wrote: On 21.09.23 17:06, Kinsey Moore wrote: > On Thu, Sep 21, 2023 at 10:01 AM Sebastian Huber > mailto:sebastian.hu...@embedded-brains.de> >

Re: [PATCH 1/1] trace: build with c++17 if building against llvm 16+

2023-09-21 Thread Sebastian Huber
On 22.09.23 04:36, Joel Sherrill wrote: Are we doing something that particularly requires C++17? AFAIK we haven't needed it yet and why wouldn't it also be needed with gcc? If the default on recent gcc versions is that, ok but we should be precise in case an older gcc with a different default i

Re: [PATCH 1/1] trace: build with c++17 if building against llvm 16+

2023-09-21 Thread Joel Sherrill
Are we doing something that particularly requires C++17? AFAIK we haven't needed it yet and why wouldn't it also be needed with gcc? If the default on recent gcc versions is that, ok but we should be precise in case an older gcc with a different default is used. This may also eliminate some hoats.

[PATCH 0/1] trace: Build with C++17 if using LLVM 16+

2023-09-21 Thread JJL772
Build trace with C++17 if LLVM-16+ is present. Headers provided by LLVM may use C++17 features as of 16.0. JJL772 (1): trace: build with c++17 if building against llvm 16+ trace/wscript | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) -- 2.40.1 __

[PATCH 1/1] trace: build with c++17 if building against llvm 16+

2023-09-21 Thread JJL772
--- trace/wscript | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/trace/wscript b/trace/wscript index a3dd5d5..0ae90f8 100644 --- a/trace/wscript +++ b/trace/wscript @@ -33,11 +33,14 @@ def options(opt): def configure(conf): conf.load('compiler_c') conf.load('

Re: [PATCH] bsd/ntpq: Use the correct address length

2023-09-21 Thread Kinsey Moore
Yes, sorry about that. I apparently haven't added the subject tweak to this repo yet. Thanks, Kinsey On Thu, Sep 21, 2023 at 7:02 PM Chris Johns wrote: > I assume this is in the network services repo? > > OK and thanks > > Chris > > On 22/9/2023 4:38 am, Kinsey Moore wrote: > > lwIP includes mo

Re: [PATCH 1/2] bsps/xqspipsu: Break out RDID

2023-09-21 Thread Chris Johns
OK to 1 and 2 Thanks Chris On 22/9/2023 7:31 am, Kinsey Moore wrote: > Expose a function to read the NOR flash chip ID information beyond the > minimum 3 bytes for the lookup table. > --- > bsps/include/dev/spi/xqspipsu-flash-helper.h | 15 +++ > bsps/shared/dev/spi/xqspipsu-flash-helper.c

Re: [PATCH] bsd/ntpq: Use the correct address length

2023-09-21 Thread Chris Johns
I assume this is in the network services repo? OK and thanks Chris On 22/9/2023 4:38 am, Kinsey Moore wrote: > lwIP includes more than the bare address structures in its accounting of > the total addrinfo struct size. Ensure that lwIP gets the correct > address size. > --- > bsd/freebsd/contrib

[PATCH 1/2] bsps/xqspipsu: Break out RDID

2023-09-21 Thread Kinsey Moore
Expose a function to read the NOR flash chip ID information beyond the minimum 3 bytes for the lookup table. --- bsps/include/dev/spi/xqspipsu-flash-helper.h | 15 +++ bsps/shared/dev/spi/xqspipsu-flash-helper.c | 45 +--- 2 files changed, 44 insertions(+), 16 deletions(-) di

[PATCH 2/2] bsps/xqspipsu: Add SFDP config space read ability

2023-09-21 Thread Kinsey Moore
This adds a function to allow reading of the SFDP configuration space that describes attributes of NOR flash chips. --- bsps/include/dev/spi/xqspipsu-flash-helper.h | 20 bsps/include/dev/spi/xqspipsu_flash_config.h | 1 + bsps/shared/dev/spi/xqspipsu-flash-helper.c | 48 +++

[PATCH] bsd/ntpq: Use the correct address length

2023-09-21 Thread Kinsey Moore
lwIP includes more than the bare address structures in its accounting of the total addrinfo struct size. Ensure that lwIP gets the correct address size. --- bsd/freebsd/contrib/ntp/ntpq/ntpq.c | 8 1 file changed, 8 insertions(+) diff --git a/bsd/freebsd/contrib/ntp/ntpq/ntpq.c b/bsd/fr

Re: [PATCH 1/2] cpukit/jffs2: Set extracted nodes off-chain

2023-09-21 Thread Kinsey Moore
On Thu, Sep 21, 2023 at 10:23 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 21.09.23 17:06, Kinsey Moore wrote: > > On Thu, Sep 21, 2023 at 10:01 AM Sebastian Huber > > > > wrote: > > > > On 21.09.23 16:52, Kinsey Moore wrote:

Re: Add Formal Verification chapter v4

2023-09-21 Thread andrew.butterfi...@scss.tcd.ie
On 21/09/2023, 16:42, "Sebastian Huber" mailto:sebastian.hu...@embedded-brains.de>> wrote: On 21.09.23 17:41, Gedare Bloom wrote: >> On Thu, Sep 21, 2023 at 9:36 AM Sebastian Huber >> > > wrote: >>> On 21.09.23 17:28, Gedare Bloom wrote: I've taken

Re: Add Formal Verification chapter v4

2023-09-21 Thread Sebastian Huber
On 21.09.23 17:41, Gedare Bloom wrote: On Thu, Sep 21, 2023 at 9:36 AM Sebastian Huber wrote: On 21.09.23 17:28, Gedare Bloom wrote: I've taken a look and resolved / commented. We can leave some of the `sis` specific bits, with the understanding that hopefully the simulation target can be m

Re: Add Formal Verification chapter v4

2023-09-21 Thread Gedare Bloom
On Thu, Sep 21, 2023 at 9:36 AM Sebastian Huber wrote: > > On 21.09.23 17:28, Gedare Bloom wrote: > > I've taken a look and resolved / commented. We can leave some of the > > `sis` specific bits, with the understanding that hopefully the > > simulation target can be made more generic in the future

Re: Add Formal Verification chapter v4

2023-09-21 Thread Sebastian Huber
On 21.09.23 17:28, Gedare Bloom wrote: I've taken a look and resolved / commented. We can leave some of the `sis` specific bits, with the understanding that hopefully the simulation target can be made more generic in the future. This could be a potential GSoC project for Prequalification to hoo

Re: Add Formal Verification chapter v4

2023-09-21 Thread Gedare Bloom
I've taken a look and resolved / commented. We can leave some of the `sis` specific bits, with the understanding that hopefully the simulation target can be made more generic in the future. This could be a potential GSoC project for Prequalification to hook it up to `rtems-tools.git/tester` to make

[PATCH v2 8/9] bsps/leon3: leon3_counter_use_irqamp_timestamp()

2023-09-21 Thread Sebastian Huber
Simplify leon3_counter_use_irqamp_timestamp(). Update #4954. --- bsps/sparc/leon3/start/cpucounter.c | 4 1 file changed, 4 deletions(-) diff --git a/bsps/sparc/leon3/start/cpucounter.c b/bsps/sparc/leon3/start/cpucounter.c index dcf8d15a65..db4f566021 100644 --- a/bsps/sparc/leon3/start/c

[PATCH v2 9/9] bsps/leon3: Use DSU time tag for GR712RC

2023-09-21 Thread Sebastian Huber
Update #4954. --- bsps/sparc/leon3/start/cpucounter.c| 62 -- spec/build/bsps/sparc/leon3/grp.yml| 2 + spec/build/bsps/sparc/leon3/optdsubase.yml | 24 + 3 files changed, 84 insertions(+), 4 deletions(-) create mode 100644 spec/build/bsps/sparc/leon3/

[PATCH v2 6/9] bsps/leon3: Move code blocks

2023-09-21 Thread Sebastian Huber
Move code blocks to simplify C preprocessor usage. Update #4954. --- bsps/sparc/leon3/start/cpucounter.c | 110 ++-- 1 file changed, 57 insertions(+), 53 deletions(-) diff --git a/bsps/sparc/leon3/start/cpucounter.c b/bsps/sparc/leon3/start/cpucounter.c index 71262ff210.

[PATCH v2 7/9] bsps/leon3: Statically initialize get timecount

2023-09-21 Thread Sebastian Huber
Update #4954. --- bsps/sparc/leon3/include/bsp/leon3.h | 2 +- bsps/sparc/leon3/start/cpucounter.c | 30 +--- 2 files changed, 19 insertions(+), 13 deletions(-) diff --git a/bsps/sparc/leon3/include/bsp/leon3.h b/bsps/sparc/leon3/include/bsp/leon3.h index 4ee5531941..93

[PATCH v2 2/9] sparc: Move CPU counter implementation

2023-09-21 Thread Sebastian Huber
Enable a BSP-specific CPU counter implementation. Update #4954. --- bsps/sparc/erc32/clock/ckinit.c | 8 +-- .../sparc/include/bsp/sparc-counter.h | 64 +-- bsps/sparc/leon2/clock/ckinit.c | 8 +-- bsps/sparc/leon3/clock/ckinit.c

[PATCH v2 5/9] bsps/leon3: Use custom CPU counter implementation

2023-09-21 Thread Sebastian Huber
Merge the timecounter and CPU counter support for the leon3 BSP family. Remove now unused functions from the CPU counter support of the erc32 and leon3 BSPs. Update #4954. --- bsps/sparc/include/bsp/sparc-counter.h | 12 -- bsps/sparc/leon3/clock/ckinit.c | 2 +- bsps/sparc/le

[PATCH v2 3/9] bsps/leon3: Make GPTIMER fall back mandatory

2023-09-21 Thread Sebastian Huber
Using the auto reload counter which generates the clock ticks for the timecounter or CPU counter is quite difficult and only works in uniprocessor configurations. Update #4954. --- bsps/sparc/leon3/clock/ckinit.c | 35 ++-- bsps/sparc/leon3/include/bsp/leon3.h | 4 --

[PATCH v2 4/9] bsps/leon3: Simplify clock and CPU counter

2023-09-21 Thread Sebastian Huber
Share the timecounter instance between the clock and the CPU counter. This greatly simplifies the clock driver since we have to do the device selection only in one place, the CPU counter support. Update #4954. --- bsps/sparc/leon3/clock/ckinit.c | 130 +-- bsps/sparc/

[PATCH v2 0/9] sparc: Simplify clock drivers and CPU counter

2023-09-21 Thread Sebastian Huber
This patch set simplifies the clock drivers and CPU counter implementations of the sparc BSPs. For the GR712RC the Debug Support Unit (DSU) is used as a performance optimization. v2: Improve code clarity. Sebastian Huber (9): bsps/leon3: Optional IRQ(A)MP timestamp support sparc: Move CPU c

[PATCH v2 1/9] bsps/leon3: Optional IRQ(A)MP timestamp support

2023-09-21 Thread Sebastian Huber
This is necessary to run the tests on SIS with profiling enabled. Update #4954. --- bsps/include/bsp/fatal.h| 1 - bsps/sparc/leon3/clock/ckinit.c | 6 ++ 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/bsps/include/bsp/fatal.h b/bsps/include/bsp/fatal.h index 4b7d0f6ce

Re: [PATCH 1/2] cpukit/jffs2: Set extracted nodes off-chain

2023-09-21 Thread Sebastian Huber
On 21.09.23 17:06, Kinsey Moore wrote: On Thu, Sep 21, 2023 at 10:01 AM Sebastian Huber > wrote: On 21.09.23 16:52, Kinsey Moore wrote: > On Thu, Sep 21, 2023 at 9:47 AM Sebastian Huber > mailto:sebastian.hu...@embedded-brains.de> >

Re: [PATCH 1/2] cpukit/jffs2: Set extracted nodes off-chain

2023-09-21 Thread Kinsey Moore
On Thu, Sep 21, 2023 at 10:01 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 21.09.23 16:52, Kinsey Moore wrote: > > On Thu, Sep 21, 2023 at 9:47 AM Sebastian Huber > > > > wrote: > > > > On 20.09.23 20:35, Kinsey Moore wrote: >

Re: [PATCH 1/2] cpukit/jffs2: Set extracted nodes off-chain

2023-09-21 Thread Sebastian Huber
On 21.09.23 16:52, Kinsey Moore wrote: On Thu, Sep 21, 2023 at 9:47 AM Sebastian Huber > wrote: On 20.09.23 20:35, Kinsey Moore wrote: [...] > @@ -1306,8 +1307,22 @@ static void process_delayed_work(void) >       while (!rtems_chain

Re: [PATCH] validation: Check stack of interrupted context

2023-09-21 Thread Kinsey Moore
On Thu, Sep 21, 2023 at 9:56 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > Hello Kinsey, > > I added a test case for > > https://devel.rtems.org/ticket/4955 > > which started as a sparc-specific bug. The test case should also work on > aarch64. In uniprocessor configurations, i

Re: [PATCH] validation: Check stack of interrupted context

2023-09-21 Thread Sebastian Huber
Hello Kinsey, I added a test case for https://devel.rtems.org/ticket/4955 which started as a sparc-specific bug. The test case should also work on aarch64. In uniprocessor configurations, it is fine: qemu-system-aarch64 -no-reboot -nographic -serial mon:stdio -machine xlnx-zcu102 -m 4096 -k

Re: [PATCH 1/2] cpukit/jffs2: Set extracted nodes off-chain

2023-09-21 Thread Kinsey Moore
On Thu, Sep 21, 2023 at 9:47 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 20.09.23 20:35, Kinsey Moore wrote: > [...] > > @@ -1306,8 +1307,22 @@ static void process_delayed_work(void) > > while (!rtems_chain_is_tail(&process_work_chain, node)) { > > work

Re: [PATCH 2/2] cpukit/jffs2: Use unprotected chain calls

2023-09-21 Thread Sebastian Huber
On 20.09.23 20:35, Kinsey Moore wrote: Use unprotected chain calls for delayed write workqueues since these calls are either protected by locks or only operate on local chains and are never accessed from interrupt context. Updates #4956 This change is all right, if you fix the chain operations

Re: [PATCH 1/2] cpukit/jffs2: Set extracted nodes off-chain

2023-09-21 Thread Sebastian Huber
On 20.09.23 20:35, Kinsey Moore wrote: [...] @@ -1306,8 +1307,22 @@ static void process_delayed_work(void) while (!rtems_chain_is_tail(&process_work_chain, node)) { work = (struct delayed_work*) node; rtems_chain_node* next_node = rtems_chain_next(node); +

[PATCH] validation: Check stack of interrupted context

2023-09-21 Thread Sebastian Huber
Check the stack of the interrupted context during the multitasking start. Update #4955. --- .../testsuites/validation/validation-intr.yml | 3 + testsuites/validation/tc-score-isr.c | 225 ++ 2 files changed, 228 insertions(+) create mode 100644 testsuites/validation/t

Re: Add Formal Verification chapter v4

2023-09-21 Thread andrew.butterfi...@scss.tcd.ie
Hi Gedare, I've made some changes and raised some further queries - I don't know if you get any notifications from github PR: (https://github.com/RTEMS/rtems-docs/pull/6) Regards, Andrew Andrew Butterfield Tel: +353-1-89