Re: [PATCH] MAINTAINERS: Add myself to write after approval

2021-03-03 Thread Chris Johns
Approved. Welcome and congratulations on your commit access. Chris On 4/3/21 6:32 pm, jan.som...@dlr.de wrote: > Could someone approve this patch, please? > > Best regards, > > Jan > >> -Original Message- >> From: Sommer, Jan >> Sent: Thursday, February 25, 2021 2:05 PM >> To: dev

RE: [PATCH] MAINTAINERS: Add myself to write after approval

2021-03-03 Thread Jan.Sommer
Could someone approve this patch, please? Best regards, Jan > -Original Message- > From: Sommer, Jan > Sent: Thursday, February 25, 2021 2:05 PM > To: devel@rtems.org > Cc: Sommer, Jan > Subject: [PATCH] MAINTAINERS: Add myself to write after approval > > --- > MAINTAINERS | 1 + >

Re: [6-freebsd-12 PATCH 1/2] rtemsbsd/bus: Add PCI support to the nexus bus

2021-03-03 Thread Chris Johns
On 4/3/21 5:53 pm, Sebastian Huber wrote: > On 04/03/2021 00:18, Chris Johns wrote: >> On 3/3/21 7:48 pm, Sebastian Huber wrote: >>> On 03/03/2021 08:52, Chris Johns wrote: Then I hit minimum and some validation tests and they failed because I had removed bsp/default-initial-extension.h a

[PATCH] aarch64: Fix context switch

2021-03-03 Thread Sebastian Huber
The Per_CPU_Control::isr_dispatch_disable is a 32-bit integer. Close #4206. --- cpukit/score/cpu/aarch64/cpu_asm.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cpukit/score/cpu/aarch64/cpu_asm.S b/cpukit/score/cpu/aarch64/cpu_asm.S index 6c4da04628..9e609e06bd 100644 -

Re: [6-freebsd-12 PATCH 1/2] rtemsbsd/bus: Add PCI support to the nexus bus

2021-03-03 Thread Sebastian Huber
On 04/03/2021 00:18, Chris Johns wrote: On 3/3/21 7:48 pm, Sebastian Huber wrote: On 03/03/2021 08:52, Chris Johns wrote: Then I hit minimum and some validation tests and they failed because I had removed bsp/default-initial-extension.h and I suppose it needs to come via bsp.h however it inclu

Re: [PATCH v8] Confstr support for RTEMS

2021-03-03 Thread Gedare Bloom
This is reduced/modified from the upstream, I see a little bit of style problems where neither RTEMS nor BSD style are used. I suggest double checking the style and consider the maintenance burden, whether we think this would need an update in the future or not. I did not open freebsd to compare th

Re: [PATCH rtems 5] powerpc/beatnik/net: Remove unused files

2021-03-03 Thread Vijay Kumar Banerjee
On Wed, Mar 3, 2021 at 7:34 PM Chris Johns wrote: > > On 4/3/21 6:36 am, Gedare Bloom wrote: > > yes, all changes to release branches need a ticket > > OK from me to push to 5 with a ticket. > Thanks. Pushed. > Chris ___ devel mailing list devel@rtems.or

Re: [PATCH 0/3] tester: Fix RLD classes for covoar

2021-03-03 Thread Chris Johns
On 4/3/21 4:01 am, Alex White wrote: > This patch set contains changes to RLD classes necessary for covoar. > > Alex White (3): > rld-dwarf: Add function::has_entry_pc > rld-dwarf: Fix file::get_source > rld-process: Add named tempfile constructor > > rtemstoolkit/rld-dwarf.cpp | 13

Re: [PATCH rtems 5] powerpc/beatnik/net: Remove unused files

2021-03-03 Thread Chris Johns
On 4/3/21 6:36 am, Gedare Bloom wrote: > yes, all changes to release branches need a ticket OK from me to push to 5 with a ticket. Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

Re: Announcement: Legacy libnetworking will be removed from RTEMS and will be placed in a separate repository

2021-03-03 Thread Vijay Kumar Banerjee
On Wed, Mar 3, 2021 at 5:46 PM Chris Johns wrote: > > Hi, > > Well done on the hardware testing. > > On 4/3/21 9:15 am, Vijay Kumar Banerjee wrote: > > On Wed, Mar 3, 2021 at 2:32 PM Joel Sherrill wrote: > >> > >> On Wed, Mar 3, 2021, 2:49 PM Heinz Junkes wrote: > >>> > >>> Hallo Vijay, > >>> I

Re: Announcement: Legacy libnetworking will be removed from RTEMS and will be placed in a separate repository

2021-03-03 Thread Chris Johns
Hi, Well done on the hardware testing. On 4/3/21 9:15 am, Vijay Kumar Banerjee wrote: > On Wed, Mar 3, 2021 at 2:32 PM Joel Sherrill wrote: >> >> On Wed, Mar 3, 2021, 2:49 PM Heinz Junkes wrote: >>> >>> Hallo Vijay, >>> I still have to ask a question ;-) >>> >>> When building EPICS, we distingu

Re: [PATCH v8] Confstr support for RTEMS

2021-03-03 Thread Joel Sherrill
Does anyone object to this? There were no comments and I will shortly merge this if no one speaks up On Mon, Feb 8, 2021 at 10:26 AM Eshan Dhawan wrote: > From: Eshan dhawan > > Closes #3373 > > Signed-off-by: Eshan Dhawan > --- > cpukit/Makefile.am| 1 + > cpuki

Updating Newlib was Fwd: [PATCH] FTW Port for Newlib

2021-03-03 Thread Joel Sherrill
This patch has been merged into newlib as of Feb 10 but the RSB for the newlib for rtems6 tools is from Jan 22. Any issues with updating newlib to pick this up so I can begin to merge Eshan's ftw tests? commit bebb25961c1ed29d217b1a40fc69c77ebdc18bcd Author: Corinna Vinschen Date: Sun Feb 10 1

Re: [6-freebsd-12 PATCH 1/2] rtemsbsd/bus: Add PCI support to the nexus bus

2021-03-03 Thread Chris Johns
On 3/3/21 7:48 pm, Sebastian Huber wrote: > On 03/03/2021 08:52, Chris Johns wrote: >> Then I hit minimum and some validation tests and they failed because I had >> removed bsp/default-initial-extension.h and I suppose it needs to come via >> bsp.h >> however it includes rtems.h because it needs t

[PATCH rtems 5 v2] powerpc/beatnik/net: Remove unused files

2021-03-03 Thread Vijay Kumar Banerjee
Close #4293 --- .../beatnik/net/if_mve/mve_smallbuf_tst.c | 145 bsps/powerpc/beatnik/net/if_mve/testing.c | 324 -- .../beatnik/net/porting/if_xxx.modini.c | 34 -- 3 files changed, 503 deletions(-) delete mode 100644 bsps/powerpc/beatnik/net/if_mve/mve_sm

Re: Announcement: Legacy libnetworking will be removed from RTEMS and will be placed in a separate repository

2021-03-03 Thread Vijay Kumar Banerjee
Hi Heinz, Thanks for the hardware tests. It's great to see the tests running successfully on hardware! Best regards, Vijay On Wed, Mar 3, 2021 at 1:34 PM junkes wrote: > > Hallo Vijay, > You don't have to apologize. I am glad that you are doing this. And now > it works perfectly. > > Even on th

Re: Announcement: Legacy libnetworking will be removed from RTEMS and will be placed in a separate repository

2021-03-03 Thread Vijay Kumar Banerjee
On Wed, Mar 3, 2021 at 2:32 PM Joel Sherrill wrote: > > > > On Wed, Mar 3, 2021, 2:49 PM Heinz Junkes wrote: >> >> Hallo Vijay, >> I still have to ask a question ;-) >> >> When building EPICS, we distinguish legacy stack or libbsd with the help of >> the target.cfg file. (e.g. powerpc-rtems6/beat

Re: [PATCH 4/4] score: Ensure stack alignment requirement

2021-03-03 Thread Gedare Bloom
On Wed, Mar 3, 2021 at 12:38 PM Sebastian Huber wrote: > > On 03/03/2021 19:31, Gedare Bloom wrote: > > >> Is there no guarantee that stack_size == config->stack_size? > >> > > Suppose an application requests a stack size with > > config->stack_area = m*CPU_STACK_ALIGNMENT > > config->stack_size =

Re: Announcement: Legacy libnetworking will be removed from RTEMS and will be placed in a separate repository

2021-03-03 Thread Joel Sherrill
On Wed, Mar 3, 2021, 2:49 PM Heinz Junkes wrote: > Hallo Vijay, > I still have to ask a question ;-) > > When building EPICS, we distinguish legacy stack or libbsd with the help of > the target.cfg file. (e.g. powerpc-rtems6/beatnik/make/target.cfg). > > Earlier in it was > RTEMS_HAS_NETWORKING =

[PATCH 3/3] pci_cfg_read.c: Fix Missing break in switch (CID #1399723)

2021-03-03 Thread Ryan Long
CID 1399723: Missing break in switch in pci_read_addressable(). Closes #4279 --- cpukit/libpci/pci_cfg_read.c | 1 + 1 file changed, 1 insertion(+) diff --git a/cpukit/libpci/pci_cfg_read.c b/cpukit/libpci/pci_cfg_read.c index 0783743..3cb6f86 100644 --- a/cpukit/libpci/pci_cfg_read.c +++ b/cpuk

[PATCH 2/3] cpuusagetop.c: Fix three Missing break in switch Coverity errors

2021-03-03 Thread Ryan Long
CID 1399726: Missing break in switch in task_usage(). CID 1399728: Missing break in switch in task_usage(). CID 1399742: Missing break in switch in task_usage(). Closes #4278 --- cpukit/libmisc/cpuuse/cpuusagetop.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/cpukit/libmisc/cpuuse/cpuus

[PATCH 0/3] Fix Missing break in switch Coverity issues

2021-03-03 Thread Ryan Long
Hi, To fix these Coverity issues, I just needed to add a comment to tell Coverity to ignore the error. I did this using the same method as shown in this article https://www.synopsys.com/blogs/software-security/gimme-a-break/. Thanks, Ryan Ryan Long (3): grtc.c: Fix four Missing break in switch

[PATCH 1/3] grtc.c: Fix four Missing break in switch Coverity errors

2021-03-03 Thread Ryan Long
CID 1399761: Missing break in switch in process_dma(). CID 1399765: Missing break in switch in process_dma(). CID 1399766: Missing break in switch in process_dma(). CID 1399777: Missing break in switch in process_dma(). Closes #4277 --- bsps/shared/grlib/tmtc/grtc.c | 4 1 file changed, 4 in

Re: Announcement: Legacy libnetworking will be removed from RTEMS and will be placed in a separate repository

2021-03-03 Thread Heinz Junkes
Hallo Vijay, I still have to ask a question ;-) When building EPICS, we distinguish legacy stack or libbsd with the help of the target.cfg file. (e.g. powerpc-rtems6/beatnik/make/target.cfg). Earlier in it was RTEMS_HAS_NETWORKING = yes (for legacy stack) and no (for new bsd stack). Now this f

Re: Announcement: Legacy libnetworking will be removed from RTEMS and will be placed in a separate repository

2021-03-03 Thread junkes
Hallo Vijay, You don't have to apologize. I am glad that you are doing this. And now it works perfectly. Even on the Hardware: Copyright(C)2008-2009,Emerson Network Power-Embedded Computing,Inc. All Rights Reserved Copyright Motorola Inc. 1999-2007, All Rights Reserved MOTLoad RTOS Version 2.0

Re: Announcement: Legacy libnetworking will be removed from RTEMS and will be placed in a separate repository

2021-03-03 Thread Vijay Kumar Banerjee
On Wed, Mar 3, 2021 at 12:37 PM junkes wrote: > > Hi Vijay, > I tried it again: > Hi Heinz, I'm really sorry that the build crashed again. I missed the telnetd.h file probably because it was somewhere in my build prefix from one of the rtems builds. I have pushed a fix on the rtems repo and the r

RE: [PATCH 1/4] score: Enforce CPU_STACK_ALIGNMENT requirements

2021-03-03 Thread Kinsey Moore
Looks good. Kinsey -Original Message- From: devel On Behalf Of Sebastian Huber Sent: Wednesday, March 3, 2021 02:40 To: devel@rtems.org Subject: [PATCH 1/4] score: Enforce CPU_STACK_ALIGNMENT requirements Clarify CPU_STACK_ALIGNMENT requirements in no_cpu port. Add static assertion to

RE: [PATCH 4/4] score: Ensure stack alignment requirement

2021-03-03 Thread Kinsey Moore
-Original Message- From: devel On Behalf Of Sebastian Huber Sent: Wednesday, March 3, 2021 02:40 To: devel@rtems.org Subject: [PATCH 4/4] score: Ensure stack alignment requirement > diff --git a/cpukit/score/src/tlsallocsize.c b/cpukit/score/src/tlsallocsize.c > index e7854c677a..cba5bdcf

Re: [PATCH 4/4] score: Ensure stack alignment requirement

2021-03-03 Thread Sebastian Huber
On 03/03/2021 19:31, Gedare Bloom wrote: Is there no guarantee that stack_size == config->stack_size? Suppose an application requests a stack size with config->stack_area = m*CPU_STACK_ALIGNMENT config->stack_size = (n*CPU_STACK_ALIGNMENT - 1) Then, you will get stack_begin = config->stac

Re: Announcement: Legacy libnetworking will be removed from RTEMS and will be placed in a separate repository

2021-03-03 Thread junkes
Hi Vijay, I tried it again: # building kernel #git clone git://git.rtems.org/rtems.git kernel git clone git://git.rtems.org/vijay/rtems.git kernel cd kernel git checkout devel-no-libnet # build and install bsp # 1. Test with waf #-e "s|RTEMS_NETWORKING = False|RTEMS_NETWORKING = True|" \ ./waf b

Re: [PATCH rtems 5] powerpc/beatnik/net: Remove unused files

2021-03-03 Thread Gedare Bloom
yes, all changes to release branches need a ticket On Wed, Mar 3, 2021 at 12:35 PM Gedare Bloom wrote: > > I think you can also remove beatnik/net/if_mve/testing.c? > > On Wed, Mar 3, 2021 at 11:13 AM Vijay Kumar Banerjee wrote: > > > > --- > > .../beatnik/net/if_mve/mve_smallbuf_tst.c | 14

Re: [PATCH rtems 5] powerpc/beatnik/net: Remove unused files

2021-03-03 Thread Gedare Bloom
I think you can also remove beatnik/net/if_mve/testing.c? On Wed, Mar 3, 2021 at 11:13 AM Vijay Kumar Banerjee wrote: > > --- > .../beatnik/net/if_mve/mve_smallbuf_tst.c | 145 -- > .../beatnik/net/porting/if_xxx.modini.c | 34 > 2 files changed, 179 deletions(-)

Re: [PATCH 4/4] score: Ensure stack alignment requirement

2021-03-03 Thread Gedare Bloom
On Wed, Mar 3, 2021 at 11:20 AM Gedare Bloom wrote: > > On Wed, Mar 3, 2021 at 10:56 AM Sebastian Huber > wrote: > > > > > > On 03/03/2021 17:04, Gedare Bloom wrote: > > >> +#if CPU_STACK_ALIGNMENT > CPU_HEAP_ALIGNMENT > > >> + stack_align = CPU_STACK_ALIGNMENT; > > >> + stack_begin = (char *)

Re: [PATCH 4/4] score: Ensure stack alignment requirement

2021-03-03 Thread Gedare Bloom
On Wed, Mar 3, 2021 at 10:56 AM Sebastian Huber wrote: > > > On 03/03/2021 17:04, Gedare Bloom wrote: > >> +#if CPU_STACK_ALIGNMENT > CPU_HEAP_ALIGNMENT > >> + stack_align = CPU_STACK_ALIGNMENT; > >> + stack_begin = (char *) RTEMS_ALIGN_UP( (uintptr_t) stack_begin, > >> stack_align ); > >> + s

Re: [PATCH rtems 5] powerpc/beatnik/net: Remove unused files

2021-03-03 Thread Vijay Kumar Banerjee
On Wed, Mar 3, 2021 at 11:13 AM Vijay Kumar Banerjee wrote: > > --- > .../beatnik/net/if_mve/mve_smallbuf_tst.c | 145 -- > .../beatnik/net/porting/if_xxx.modini.c | 34 > 2 files changed, 179 deletions(-) > delete mode 100644 bsps/powerpc/beatnik/net/if_mve/mve_s

[PATCH rtems 5] powerpc/beatnik/net: Remove unused files

2021-03-03 Thread Vijay Kumar Banerjee
--- .../beatnik/net/if_mve/mve_smallbuf_tst.c | 145 -- .../beatnik/net/porting/if_xxx.modini.c | 34 2 files changed, 179 deletions(-) delete mode 100644 bsps/powerpc/beatnik/net/if_mve/mve_smallbuf_tst.c delete mode 100644 bsps/powerpc/beatnik/net/porting/if_xxx

Re: [PATCH 00/22] tester: Update covoar for new build system

2021-03-03 Thread Chris Johns
On 4/3/21 2:08 am, Alexander White wrote: > I have only tested it on Ubuntu 20.10. I am working on getting it tested on > FreeBSD 12.2 as well. Excellent. Could you please make sure covoar builds on Windows under MSYS2 and cygwin (we have a user on cygwin)? Actual testing on Windows is up to you

Re: Announcement: Legacy libnetworking will be removed from RTEMS and will be placed in a separate repository

2021-03-03 Thread Gedare Bloom
On Wed, Mar 3, 2021 at 10:38 AM Joel Sherrill wrote: > > > > On Wed, Mar 3, 2021 at 11:14 AM Vijay Kumar Banerjee wrote: >> >> Hello Heinz, Joel, >> >> >> On Wed, Mar 3, 2021 at 7:03 AM Joel Sherrill wrote: >> > >> > >> > >> > On Wed, Mar 3, 2021 at 3:39 AM junkes wrote: >> >> >> >> Dear Vijay,

Re: Announcement: Legacy libnetworking will be removed from RTEMS and will be placed in a separate repository

2021-03-03 Thread Vijay Kumar Banerjee
On Wed, Mar 3, 2021 at 10:38 AM Joel Sherrill wrote: > > > > On Wed, Mar 3, 2021 at 11:14 AM Vijay Kumar Banerjee wrote: >> >> Hello Heinz, Joel, >> >> >> On Wed, Mar 3, 2021 at 7:03 AM Joel Sherrill wrote: >> > >> > >> > >> > On Wed, Mar 3, 2021 at 3:39 AM junkes wrote: >> >> >> >> Dear Vijay,

Re: [PATCH 4/4] score: Ensure stack alignment requirement

2021-03-03 Thread Sebastian Huber
On 03/03/2021 17:04, Gedare Bloom wrote: +#if CPU_STACK_ALIGNMENT > CPU_HEAP_ALIGNMENT + stack_align = CPU_STACK_ALIGNMENT; + stack_begin = (char *) RTEMS_ALIGN_UP( (uintptr_t) stack_begin, stack_align ); + stack_end = (char *) RTEMS_ALIGN_DOWN( (uintptr_t) stack_end, stack_align ); Why ali

[PATCH v2] CONFIGURE_MAXIMUM_THREAD_LOCAL_STORAGE_SIZE

2021-03-03 Thread Sebastian Huber
Ensure that CONFIGURE_MAXIMUM_THREAD_LOCAL_STORAGE_SIZE meets the task storage alignment requirement. --- cpukit/doxygen/appl-config.h| 14 +++--- cpukit/include/rtems/confdefs/threads.h | 5 + 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/cpukit/doxygen/

Re: Announcement: Legacy libnetworking will be removed from RTEMS and will be placed in a separate repository

2021-03-03 Thread Joel Sherrill
On Wed, Mar 3, 2021 at 11:14 AM Vijay Kumar Banerjee wrote: > Hello Heinz, Joel, > > > On Wed, Mar 3, 2021 at 7:03 AM Joel Sherrill wrote: > > > > > > > > On Wed, Mar 3, 2021 at 3:39 AM junkes wrote: > >> > >> Dear Vijay, > >> thank you very much for your effort to bring some order here ;-) > >

Re: Announcement: Legacy libnetworking will be removed from RTEMS and will be placed in a separate repository

2021-03-03 Thread Vijay Kumar Banerjee
Hello Heinz, Joel, On Wed, Mar 3, 2021 at 7:03 AM Joel Sherrill wrote: > > > > On Wed, Mar 3, 2021 at 3:39 AM junkes wrote: >> >> Dear Vijay, >> thank you very much for your effort to bring some order here ;-) >> >> I am currently trying to get EPICS to work on RTEMS6 as well. >> >> I already f

Re: Announcement: Legacy libnetworking will be removed from RTEMS and will be placed in a separate repository

2021-03-03 Thread junkes
In file included from ../../bsps/powerpc/beatnik/net/porting/if_xxx_rtems.c:1: ../../bsps/powerpc/beatnik/net/porting/rtemscompat.h:164:2: error: #error rtemscompat_defs.h must define either NET_CHIP_LE or NET_CHIP_BE 164 | #error rtemscompat_defs.h must define either NET_CHIP_LE or NET_CHIP_BE

[PATCH 3/3] rld-process: Add named tempfile constructor

2021-03-03 Thread Alex White
This adds a new tempfile constructor for creating a named tempfile rather than generating the name. --- rtemstoolkit/rld-process.cpp | 11 +++ rtemstoolkit/rld-process.h | 7 +++ 2 files changed, 18 insertions(+) diff --git a/rtemstoolkit/rld-process.cpp b/rtemstoolkit/rld-process.

[PATCH 1/3] rld-dwarf: Add function::has_entry_pc

2021-03-03 Thread Alex White
--- rtemstoolkit/rld-dwarf.cpp | 8 +++- rtemstoolkit/rld-dwarf.h | 5 + 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/rtemstoolkit/rld-dwarf.cpp b/rtemstoolkit/rld-dwarf.cpp index d9ac6f3..acb4fd4 100644 --- a/rtemstoolkit/rld-dwarf.cpp +++ b/rtemstoolkit/rld-dwarf.cpp

[PATCH 2/3] rld-dwarf: Fix file::get_source

2021-03-03 Thread Alex White
The file::get_source method was giving "unknown:-1" for valid addresses. This has been fixed. --- rtemstoolkit/rld-dwarf.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/rtemstoolkit/rld-dwarf.cpp b/rtemstoolkit/rld-dwarf.cpp index acb4fd4..2fce0e4 100644 --- a/rtemstoo

[PATCH 0/3] tester: Fix RLD classes for covoar

2021-03-03 Thread Alex White
This patch set contains changes to RLD classes necessary for covoar. Alex White (3): rld-dwarf: Add function::has_entry_pc rld-dwarf: Fix file::get_source rld-process: Add named tempfile constructor rtemstoolkit/rld-dwarf.cpp | 13 + rtemstoolkit/rld-dwarf.h | 5 + r

Re: About HEAP error

2021-03-03 Thread Gedare Bloom
On Wed, Mar 3, 2021 at 9:49 AM Gedare Bloom wrote: > > On Wed, Mar 3, 2021 at 9:28 AM Joel Sherrill wrote: > > > > > > > > On Wed, Mar 3, 2021 at 9:50 AM Gedare Bloom wrote: > >> > >> On Wed, Mar 3, 2021 at 12:08 AM Richi Dubey wrote: > >> > > >> > What's the element written after the free? I s

Re: About HEAP error

2021-03-03 Thread Gedare Bloom
On Wed, Mar 3, 2021 at 9:28 AM Joel Sherrill wrote: > > > > On Wed, Mar 3, 2021 at 9:50 AM Gedare Bloom wrote: >> >> On Wed, Mar 3, 2021 at 12:08 AM Richi Dubey wrote: >> > >> > What's the element written after the free? I set a watch at the exact >> > block location, but it doesn't work: >> >

Re: [PATCH 3/4] CONFIGURE_MAXIMUM_THREAD_LOCAL_STORAGE_SIZE

2021-03-03 Thread Gedare Bloom
On Wed, Mar 3, 2021 at 9:06 AM Sebastian Huber wrote: > > On 03/03/2021 16:56, Gedare Bloom wrote: > > >> diff --git a/cpukit/include/rtems/confdefs/threads.h > >> b/cpukit/include/rtems/confdefs/threads.h > >> index 97508068e2..a9c8a271b5 100644 > >> --- a/cpukit/include/rtems/confdefs/threads.h

Re: About HEAP error

2021-03-03 Thread Joel Sherrill
On Wed, Mar 3, 2021 at 9:50 AM Gedare Bloom wrote: > On Wed, Mar 3, 2021 at 12:08 AM Richi Dubey wrote: > > > > What's the element written after the free? I set a watch at the exact > block location, but it doesn't work: > > > > Hardware watchpoint 7: *0x202ba8 > > (gdb) watch *0x206fec > > Hard

Re: [PATCH 3/4] CONFIGURE_MAXIMUM_THREAD_LOCAL_STORAGE_SIZE

2021-03-03 Thread Sebastian Huber
On 03/03/2021 16:56, Gedare Bloom wrote: diff --git a/cpukit/include/rtems/confdefs/threads.h b/cpukit/include/rtems/confdefs/threads.h index 97508068e2..a9c8a271b5 100644 --- a/cpukit/include/rtems/confdefs/threads.h +++ b/cpukit/include/rtems/confdefs/threads.h @@ -138,8 +138,14 @@ typedef un

Re: [PATCH 4/4] score: Ensure stack alignment requirement

2021-03-03 Thread Gedare Bloom
On Wed, Mar 3, 2021 at 1:40 AM Sebastian Huber wrote: > > Make sure we meet the stack aligment requirement also for CPU ports with > CPU_STACK_ALIGNMENT > CPU_HEAP_ALIGNMENT. > --- > cpukit/include/rtems/score/context.h | 3 +-- > cpukit/include/rtems/score/stackimpl.h | 9 + > cpukit

Re: [PATCH 18/22] covoar: Add option to create named objdumps

2021-03-03 Thread Alexander White
On Tue, Mar 2, 2021 at 5:37 PM Chris Johns wrote: > On 2/3/21 7:01 am, Alex White wrote: > > This adds a new macro USE_TEMPLFILE which allows the creation of named > > objdump outputs in the /tmp directory. This allows the outputs to be > > reused on subsequent runs of covoar rather than running

Re: [PATCH 3/4] CONFIGURE_MAXIMUM_THREAD_LOCAL_STORAGE_SIZE

2021-03-03 Thread Gedare Bloom
On Wed, Mar 3, 2021 at 1:40 AM Sebastian Huber wrote: > > Ensure that CONFIGURE_MAXIMUM_THREAD_LOCAL_STORAGE_SIZE meets the task > storage alignment requirement. > --- > cpukit/doxygen/appl-config.h| 14 +++--- > cpukit/include/rtems/confdefs/threads.h | 8 +++- > 2 files

Re: About HEAP error

2021-03-03 Thread Gedare Bloom
On Wed, Mar 3, 2021 at 12:08 AM Richi Dubey wrote: > > What's the element written after the free? I set a watch at the exact block > location, but it doesn't work: > > Hardware watchpoint 7: *0x202ba8 > (gdb) watch *0x206fec > Hardware watchpoint 8: *0x206fec That's just the first byte in the blo

Re: Need help in deciding GSoC project also want to know project Scope

2021-03-03 Thread Gedare Bloom
On Tue, Mar 2, 2021 at 4:36 PM Prateek Pardeshi wrote: > > Hi Gedare, > > On Tue, 02 Mar 2021 22:19:26 +0530 Gedare Bloom wrote > > > > Hi Prateek, > > > > On Mon, Mar 1, 2021 at 10:31 PM Prateek Pardeshi > wrote: > > > > > > Hi everyone, > > > I have decided following projects

Re: [PATCH 00/22] tester: Update covoar for new build system

2021-03-03 Thread Alexander White
I have only tested it on Ubuntu 20.10. I am working on getting it tested on FreeBSD 12.2 as well. Alex On Mon, Mar 1, 2021 at 6:14 PM Chris Johns wrote: > On 2/3/21 7:01 am, Alex White wrote: > > This patch set updates the covoar tool to allow it to work with the > > outputs of the current buil

Re: Announcement: Legacy libnetworking will be removed from RTEMS and will be placed in a separate repository

2021-03-03 Thread Joel Sherrill
On Wed, Mar 3, 2021 at 3:39 AM junkes wrote: > Dear Vijay, > thank you very much for your effort to bring some order here ;-) > I am currently trying to get EPICS to work on RTEMS6 as well. > > I already failed with the legacy stack because configuration variables like > RTEMS_HAS_NETWORK are not

[PATCH v3 2/2] bsps/aarch64: Resolve usage of SUBALIGN()

2021-03-03 Thread Kinsey Moore
Remove usage of SUBALIGN() in aarch64 linkcmds which works around a difference in behavior on AArch64 platforms. This is no longer necessary since alignment is now enforced explicitly. Closes #4178. --- bsps/aarch64/shared/start/linkcmds.base | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[PATCH v3 1/2] cpukit: Explicitly enforce alignment requirements

2021-03-03 Thread Kinsey Moore
According to commentary on GCC bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99143, the alignment behavior of linker sections on which RTEMS has relied was never guaranteed to be consistent across platforms and any alignment requirements for linker sections needs to be enforced explicitly. This

RE: [PATCH v2 1/3] score: Enforce stack and TLS alignment

2021-03-03 Thread Kinsey Moore
-Original Message- From: Sebastian Huber Sent: Wednesday, March 3, 2021 02:44 To: Kinsey Moore ; devel@rtems.org Subject: Re: [PATCH v2 1/3] score: Enforce stack and TLS alignment > On 02/03/2021 23:35, Kinsey Moore wrote: >> I don't see that _Stack_Extend_size() does any overflow handli

Re: Announcement: Legacy libnetworking will be removed from RTEMS and will be placed in a separate repository

2021-03-03 Thread junkes
Dear Vijay, thank you very much for your effort to bring some order here ;-) I am currently trying to get EPICS to work on RTEMS6 as well. I already failed with the legacy stack because configuration variables like RTEMS_HAS_NETWORK are not set with the waf-builder. That's why I quite happily

[PATCH] validation: Fix for 64-bit targets

2021-03-03 Thread Sebastian Huber
--- testsuites/validation/tc-message-construct-errors.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/testsuites/validation/tc-message-construct-errors.c b/testsuites/validation/tc-message-construct-errors.c index e1b36091b4..0a98a52f43 100644 --- a/testsuites/

Re: [PATCH v2] tests/validation: Fix 64bit test failure

2021-03-03 Thread Sebastian Huber
On 24/02/2021 18:30, Gedare Bloom wrote: On Wed, Feb 24, 2021 at 9:58 AM Sebastian Huber wrote: On 24/02/2021 17:54, Gedare Bloom wrote: On Wed, Feb 24, 2021 at 2:52 AM Sebastian Huber wrote: On 16/02/2021 06:51, Sebastian Huber wrote: The issue can be fixed in two ways. 1. We change

Re: [PATCH v2 2/3] cpukit: Explicitly enforce alignment requirements

2021-03-03 Thread Sebastian Huber
On 02/03/2021 21:00, Gedare Bloom wrote: #define RTEMS_LINKER_ROSET_ITEM_REFERENCE( set, type, item ) \ - static type const * const_Set_reference_##set##_##item \ + RTEMS_LINKER_SET_ALIGN( type ) static type const * const_Set_reference_##set##_##item \ RTEMS_SECTION( ".rtemsroset.refere

Re: [PATCH v2 2/3] cpukit: Explicitly enforce alignment requirements

2021-03-03 Thread Sebastian Huber
On 02/03/2021 21:00, Gedare Bloom wrote: +/* + * The use of explicit alignment is necessary below due to behavioral + * expectations of GCC on which RTEMS has relied in the past. These + * behaviors were consistent, but never guaranteed. Some newer platforms + * violate this previous consistency

Re: [6-freebsd-12 PATCH 1/2] rtemsbsd/bus: Add PCI support to the nexus bus

2021-03-03 Thread Sebastian Huber
On 03/03/2021 08:52, Chris Johns wrote: Then I hit minimum and some validation tests and they failed because I had removed bsp/default-initial-extension.h and I suppose it needs to come via bsp.h however it includes rtems.h because it needs to have access to rtems_fatal_source etc. It seems the

Re: [PATCH v2 1/3] score: Enforce stack and TLS alignment

2021-03-03 Thread Sebastian Huber
On 02/03/2021 23:35, Kinsey Moore wrote: -Original Message- From: Sebastian Huber Sent: Tuesday, March 2, 2021 15:09 To: Kinsey Moore ; devel@rtems.org Subject: Re: [PATCH v2 1/3] score: Enforce stack and TLS alignment On 02/03/2021 20:47, Kinsey Moore wrote: Enforce alignment of th

Re: [PATCH rtems-libbsd 1/2] racoon/session: Honor file descriptor maximum

2021-03-03 Thread Christian MAUDERER
Hello Chris, Am 03.03.21 um 02:17 schrieb Chris Johns: On 2/3/21 7:26 pm, Christian MAUDERER wrote: Hello Chris, Am 02.03.21 um 01:03 schrieb Chris Johns: On 1/3/21 7:24 pm, Christian MAUDERER wrote: Hello Chris, thanks for the review. Am 26.02.21 um 19:04 schrieb Chris Johns: On 26/2/21

[PATCH 0/4] Ensure the stack alignment requirement

2021-03-03 Thread Sebastian Huber
This patch set addresses issues with the stack alignment for CPU ports with CPU_STACK_ALIGNMENT > CPU_HEAP_ALIGNMENT. Sebastian Huber (4): score: Enforce CPU_STACK_ALIGNMENT requirements rtems: Fix RTEMS_TASK_STORAGE_ALIGNMENT CONFIGURE_MAXIMUM_THREAD_LOCAL_STORAGE_SIZE score: Ensure stack

[PATCH 1/4] score: Enforce CPU_STACK_ALIGNMENT requirements

2021-03-03 Thread Sebastian Huber
Clarify CPU_STACK_ALIGNMENT requirements in no_cpu port. Add static assertion to enforce CPU_STACK_ALIGNMENT requirements. --- .../score/cpu/bfin/include/rtems/score/cpu.h | 13 .../score/cpu/lm32/include/rtems/score/cpu.h | 10 --- .../score/cpu/m68k/include/rtems/score/cpu.h |

[PATCH 3/4] CONFIGURE_MAXIMUM_THREAD_LOCAL_STORAGE_SIZE

2021-03-03 Thread Sebastian Huber
Ensure that CONFIGURE_MAXIMUM_THREAD_LOCAL_STORAGE_SIZE meets the task storage alignment requirement. --- cpukit/doxygen/appl-config.h| 14 +++--- cpukit/include/rtems/confdefs/threads.h | 8 +++- 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/cpukit/doxyg

[PATCH 4/4] score: Ensure stack alignment requirement

2021-03-03 Thread Sebastian Huber
Make sure we meet the stack aligment requirement also for CPU ports with CPU_STACK_ALIGNMENT > CPU_HEAP_ALIGNMENT. --- cpukit/include/rtems/score/context.h | 3 +-- cpukit/include/rtems/score/stackimpl.h | 9 + cpukit/score/src/threadinitialize.c| 9 + cpukit/score/src/tls

[PATCH 2/4] rtems: Fix RTEMS_TASK_STORAGE_ALIGNMENT

2021-03-03 Thread Sebastian Huber
Make sure we meet the stack alignment requirement for user-provided thread storage areas. --- cpukit/include/rtems/rtems/tasks.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/include/rtems/rtems/tasks.h b/cpukit/include/rtems/rtems/tasks.h index d896e66bd5..a8fe267884