On 18/07/2019 07:38, Ravindra Kumar Meena wrote:
Hi,
I am facing difficulty in adding event.header in client-side.
struct event_header_compact {
enum : uint5_t { compact = 0 ... 30, extended = 31 } id;
variant {
struct {
uint27_clock_monotonic_t timestamp;
} compact;
struct {
uint32_t id;
uint
Hi,
I am facing difficulty in adding event.header in client-side.
struct event_header_compact {
enum : uint5_t { compact = 0 ... 30, extended = 31 } id;
variant {
struct {
uint27_clock_monotonic_t timestamp;
} compact;
struct {
uint32_t id;
uint64_clock_monotonic_t timestamp;
} extended;
} v;
}
On 17/07/2019 23:42, dufa...@hda.com wrote:
On Jul 17, 2019, at 01:48 , Sebastian Huber
wrote:
Hello Peter,
On 16/07/2019 19:58, Peter Dufault wrote:
I have a build failure with the MVME5500 “beatnik” BSP. Therefore I tried to build the
“psim” BSP and have the same failure: the FreeBSD Powe
On 17/07/2019 22:28, Vijay Kumar Banerjee wrote:
+static int
+testmmap(struct cdev *dev, vm_ooffset_t offset, vm_paddr_t *paddr,
+ int nprot, vm_memattr_t *memattr)
+{
+ test_state *state = dev->si_drv1;
+
+ assert(memattr == VM_MEMATTR_DEFAULT);
+ assert(paddr != NULL);
On Wed, Jul 17, 2019 at 11:42 PM Gedare Bloom wrote:
> On Tue, Jul 16, 2019 at 6:57 AM Joel Sherrill wrote:
> >
> > Let's give preference to FreeBSD sources. Notes below.
> >
> > On Wed, Jul 3, 2019 at 1:08 PM Vaibhav Gupta
> wrote:
> >>
> >> Hello,
> >> I have found sources for fenv.
> >>
> >>
On Tue, Jul 16, 2019 at 6:26 PM Joel Sherrill wrote:
> Let's give preference to FreeBSD sources. Notes below.
>
> On Wed, Jul 3, 2019 at 1:08 PM Vaibhav Gupta
> wrote:
>
>> Hello,
>> I have found sources for fenv.
>>
>> 1.1) - ARM FreeBSD Source:
>> - https://github.com/freebsd/freebsd/blob/mast
On Wed, Jul 17, 2019, 1:12 PM Gedare Bloom wrote:
> On Tue, Jul 16, 2019 at 6:57 AM Joel Sherrill wrote:
> >
> > Let's give preference to FreeBSD sources. Notes below.
> >
> > On Wed, Jul 3, 2019 at 1:08 PM Vaibhav Gupta
> wrote:
> >>
> >> Hello,
> >> I have found sources for fenv.
> >>
> >> 1.
> On Jul 17, 2019, at 01:48 , Sebastian Huber
> wrote:
>
> Hello Peter,
>
> On 16/07/2019 19:58, Peter Dufault wrote:
>> I have a build failure with the MVME5500 “beatnik” BSP. Therefore I tried to
>> build the “psim” BSP and have the same failure: the FreeBSD PowerPC
>> “cpufunc.h” and the R
---
freebsd/sys/kern/kern_conf.c | 8 +++
freebsd/sys/sys/conf.h | 2 +-
rtemsbsd/include/machine/vm.h | 2 ++
rtemsbsd/sys/fs/devfs/devfs_devs.c | 38 ++
testsuite/cdev01/test_cdev.c | 21 -
testsuite/cdev01/test_cdev
On 17/07/2019 11:10, Nils Hölscher wrote:
> Hi,
>
> +#define VM_MEMATTR_DEFAULT 0
> +#define VM_MEMATTR_UNCACHEABLE 1
>
>
> Are you sure that these values are correct in general?
> BSD defines this only for ARM versions smaller 6.
> https://github.com/freebsd/freebsd/blob/1d6e4247415d26
On Wed, Jul 17, 2019, 11:46 PM Gedare Bloom wrote:
> On Wed, Jul 17, 2019 at 11:09 AM Vaibhav Gupta
> wrote:
> >
> > Thanks for the review!
> > I will re generate the patch with corrections
> >
> > On Wed, Jul 17, 2019 at 10:12 PM Gedare Bloom wrote:
> >>
> >> On Wed, Jul 10, 2019 at 1:49 AM Va
On Wed, Jul 17, 2019 at 11:09 AM Vaibhav Gupta wrote:
>
> Thanks for the review!
> I will re generate the patch with corrections
>
> On Wed, Jul 17, 2019 at 10:12 PM Gedare Bloom wrote:
>>
>> On Wed, Jul 10, 2019 at 1:49 AM Vaibhav Gupta
>> wrote:
>> >
>> > ---
>> > testsuites/psxtests/Makefil
On Tue, Jul 16, 2019 at 6:57 AM Joel Sherrill wrote:
>
> Let's give preference to FreeBSD sources. Notes below.
>
> On Wed, Jul 3, 2019 at 1:08 PM Vaibhav Gupta wrote:
>>
>> Hello,
>> I have found sources for fenv.
>>
>> 1.1) - ARM FreeBSD Source:
>> - https://github.com/freebsd/freebsd/blob/mast
Thanks for the review!
I will re generate the patch with corrections
On Wed, Jul 17, 2019 at 10:12 PM Gedare Bloom wrote:
> On Wed, Jul 10, 2019 at 1:49 AM Vaibhav Gupta
> wrote:
> >
> > ---
> > testsuites/psxtests/Makefile.am | 7 +
> > testsuites/psxtests/configure.ac | 1 +
> >
On Wed, Jul 10, 2019 at 1:49 AM Vaibhav Gupta wrote:
>
> ---
> testsuites/psxtests/Makefile.am | 7 +
> testsuites/psxtests/configure.ac | 1 +
> testsuites/psxtests/psxndbm01/init.c | 260 +++
> 3 files changed, 268 insertions(+)
> create mode 100644 testsui
Hello Ravindra,
very well done. Having something that is readable by Trace Compass at a
basic level is a big step forward. Please focus now on providing the
events in a structure similar to LTTNG.
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Pho
Hi,
I applied the patch and now all compiles.
But I haven't tested anything yet, I am currently working on an application
for testing.
I will keep in contact concerning the mmap patch.
Best,
Nils
On Tue, 16 Jul 2019 at 15:47, Christian Mauderer <
christian.maude...@embedded-brains.de> wrote:
>
On Wed, 17 Jul 2019 at 09:03, Vijay Kumar Banerjee
wrote:
> ---
> freebsd/sys/kern/kern_conf.c | 8 +++
> freebsd/sys/sys/conf.h | 2 +-
> rtemsbsd/include/machine/vm.h | 2 ++
> rtemsbsd/sys/fs/devfs/devfs_devs.c | 34 ++
> testsuite/cde
On 17/07/2019 09:02, Vijay Kumar Banerjee wrote:
+static int
+testmmap(struct cdev *dev, vm_ooffset_t offset, vm_paddr_t *paddr,
+ int nprot, vm_memattr_t *memattr)
+{
+ test_state *state = dev->si_drv1;
+
Please add assertions for all parameters.
+ assert(*state == TEST_K
On 17/07/2019 09:02, Vijay Kumar Banerjee wrote:
+ if (td != 0) {
+ if (cdev == NULL) {
+ error = ENXIO;
+ }
Suppose cdev == NULL, then you have a NULL pointer access here:
+ if (cdev->si_flags & SI_ALIAS) {
+
On Wed, Jul 17, 2019 at 10:26 AM Sebastian Huber <
sebastian.hu...@embedded-brains.de> wrote:
> On 16/07/2019 21:47, Vijay Kumar Banerjee wrote:
> > + rv = mmap(NULL, 1, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);
> > + assert(rv != MAP_FAILED);
> > +
>
> Please change this to:
>
> assert(
---
freebsd/sys/kern/kern_conf.c | 8 +++
freebsd/sys/sys/conf.h | 2 +-
rtemsbsd/include/machine/vm.h | 2 ++
rtemsbsd/sys/fs/devfs/devfs_devs.c | 34 ++
testsuite/cdev01/test_cdev.c | 17 ++-
testsuite/cdev01/test_cdev01
22 matches
Mail list logo
