Re: x86_64 gcc missing crti/n

2019-03-14 Thread Sebastian Huber
I already checked it in, it did build fine. - Joel Sherrill schrieb: > Definitely fixes. Posting patch now. > > On Thu, Mar 14, 2019 at 1:49 PM Joel Sherrill wrote: > > > LOL. I thought i would fix it while you were asleep. I have a build now. > > > > On Thu, Mar 14, 2019 at 1:46 PM Sebast

Re: Query Regarding Old Projects, for GSoC 2019

2019-03-14 Thread Vaibhav Gupta
On Fri, 15 Mar, 2019, 12:27 AM Joel Sherrill It's always good to discuss old project ideas and make sure they are still > sane and useful. > Yes I agree, I meant for GSoC I am focusing on "POSIX Compilance" But any project ideas, old/new, always trigger my curiosity, the reason I asked it in the q

Re: x86_64 gcc missing crti/n

2019-03-14 Thread Joel Sherrill
Definitely fixes. Posting patch now. On Thu, Mar 14, 2019 at 1:49 PM Joel Sherrill wrote: > LOL. I thought i would fix it while you were asleep. I have a build now. > > On Thu, Mar 14, 2019 at 1:46 PM Sebastian Huber < > sebastian.hu...@embedded-brains.de> wrote: > >> - Am 14. Mrz 2019 um 19

[PATCH] rtems-x86_64.bset: Bump to gcc 9 to have crti/n

2019-03-14 Thread Joel Sherrill
--- rtems/config/5/rtems-x86_64.bset | 9 + 1 file changed, 9 insertions(+) diff --git a/rtems/config/5/rtems-x86_64.bset b/rtems/config/5/rtems-x86_64.bset index 2d6ff5f..bbcd7ca 100644 --- a/rtems/config/5/rtems-x86_64.bset +++ b/rtems/config/5/rtems-x86_64.bset @@ -3,3 +3,12 @@ %defin

Re: [PATCH] leon2-sis.ini, leon3-sis.ini: Correct run arguments

2019-03-14 Thread Joel Sherrill
I will double check that it works without. Thanks. On Thu, Mar 14, 2019 at 8:44 AM Jiri Gaisler wrote: > I don't think this patch is necessary, the -r option is already present > and does not need to be duplicated. > > Jiri. > > On 2019-03-14 14:21, Joel Sherrill wrote: > > --- > > tester/rte

Re: Query Regarding Old Projects, for GSoC 2019

2019-03-14 Thread Joel Sherrill
It's always good to discuss old project ideas and make sure they are still sane and useful. On the POSIX Compliance, I am make sure it is said publicly that methods included in FACE Technical Standard profiles that are missing are the highest priority to add. And this is documented in the Complian

Re: x86_64 gcc missing crti/n

2019-03-14 Thread Joel Sherrill
LOL. I thought i would fix it while you were asleep. I have a build now. On Thu, Mar 14, 2019 at 1:46 PM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > - Am 14. Mrz 2019 um 19:15 schrieb joel j...@rtems.org: > > > On Thu, Mar 14, 2019 at 1:11 PM Sebastian Huber < > > sebastian

Re: x86_64 gcc missing crti/n

2019-03-14 Thread Sebastian Huber
- Am 14. Mrz 2019 um 19:15 schrieb joel j...@rtems.org: > On Thu, Mar 14, 2019 at 1:11 PM Sebastian Huber < > sebastian.hu...@embedded-brains.de> wrote: > >> - Am 14. Mrz 2019 um 18:29 schrieb Amaan Cheval amaan.che...@gmail.com >> : >> >> > Quick note; I'm not at the computer, but I have

Re: x86_64 gcc missing crti/n

2019-03-14 Thread Joel Sherrill
On Thu, Mar 14, 2019 at 1:11 PM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > - Am 14. Mrz 2019 um 18:29 schrieb Amaan Cheval amaan.che...@gmail.com > : > > > Quick note; I'm not at the computer, but I haven't tested with the RTEMS > 6 > > buildsets - I can do that tomorrow to

Re: x86_64 gcc missing crti/n

2019-03-14 Thread Sebastian Huber
- Am 14. Mrz 2019 um 18:29 schrieb Amaan Cheval amaan.che...@gmail.com: > Quick note; I'm not at the computer, but I haven't tested with the RTEMS 6 > buildsets - I can do that tomorrow too. The RTEMS 6 tool chain should not use patches. It is intended to test the upstream versions. Why can

Re: x86_64 gcc missing crti/n

2019-03-14 Thread Amaan Cheval
Quick note; I'm not at the computer, but I haven't tested with the RTEMS 6 buildsets - I can do that tomorrow too. On Thu, Mar 14, 2019, 10:52 PM Amaan Cheval wrote: > Hey! > > It seems like the RSB patch for crt[i/n] was mistakenly taken out > along with other stuff: > > https://git.rtems.org/r

Re: x86_64 gcc missing crti/n

2019-03-14 Thread Amaan Cheval
Hey! It seems like the RSB patch for crt[i/n] was mistakenly taken out along with other stuff: https://git.rtems.org/rtems-source-builder/commit/?id=258129e140a2f0c7f579492bda2a86c6c1b93080 I'm on a new computer where I'll have to compile git from source to use `send-email` to send the patch, so

x86_64 gcc missing crti/n

2019-03-14 Thread Joel Sherrill
Hi Sebastian mentioned that x86_64 gcc is missing crti/n. I looked on the GCC master and the code is in libgcc/config.host. This is in libgcc/config.host on the master. I am assuming it isn't in gcc 7.4.0 and the RSB is missing a patch. x86_64-*-elf* | x86_64-*-rtems*) tmake_file="$tmake

Re: [PATCH] shell: Correct argument order of `mfill`

2019-03-14 Thread Gedare Bloom
Thank you Jonathan patches applied and tickets have closed properly. On Tue, Mar 12, 2019 at 11:12 PM Jonathan Brandmeyer < jbrandme...@planetiq.com> wrote: > I apologize for the vagueness - It isn't clear which one is supposed > to go against which branch. The only distinguishing feature is th

Re: [PATCH 0/1] eng: Add software test framework chapter

2019-03-14 Thread Gedare Bloom
On Thu, Mar 14, 2019 at 9:42 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 14/03/2019 14:31, Gedare Bloom wrote: > > Do we also want to document the adhoc testsuite here? > > For our pre-qualification project we need also a documentation about the > test suites. I think this

Re: [PATCH 2/3] fifo.c: Eliminate logically dead code (Coverity 1437635)

2019-03-14 Thread Gedare Bloom
On Thu, Mar 14, 2019 at 9:22 AM Joel Sherrill wrote: > --- > cpukit/libfs/src/pipe/fifo.c | 13 + > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/cpukit/libfs/src/pipe/fifo.c b/cpukit/libfs/src/pipe/fifo.c > index 71d5f85..3275e5f 100644 > --- a/cpukit/libfs/src/pi

Re: [PATCH 3/3] main_edit.c: Use strncpy() to eliminate potential buffer overflow.

2019-03-14 Thread Gedare Bloom
On Thu, Mar 14, 2019 at 9:22 AM Joel Sherrill wrote: > --- > cpukit/libmisc/shell/main_edit.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/cpukit/libmisc/shell/main_edit.c > b/cpukit/libmisc/shell/main_edit.c > index 079e9ff..e43ff68 100644 > --- a/cpukit/lib

Re: [PATCH] leon2-sis.ini, leon3-sis.ini: Correct run arguments

2019-03-14 Thread Jiri Gaisler
I don't think this patch is necessary, the -r option is already present and does not need to be duplicated. Jiri. On 2019-03-14 14:21, Joel Sherrill wrote: --- tester/rtems/testing/bsps/leon2-sis.ini | 2 +- tester/rtems/testing/bsps/leon3-sis.ini | 2 +- 2 files changed, 2 insertions(+),

Re: [PATCH 0/1] eng: Add software test framework chapter

2019-03-14 Thread Sebastian Huber
On 14/03/2019 14:31, Gedare Bloom wrote: Do we also want to document the adhoc testsuite here? For our pre-qualification project we need also a documentation about the test suites. I think this should go into a separate chapter or document. -- Sebastian Huber, embedded brains GmbH Address :

Re: BSP Basics in Doxygen Recommendations?

2019-03-14 Thread Gedare Bloom
On Thu, Mar 14, 2019 at 9:39 AM Gedare Bloom wrote: > > > On Thu, Mar 14, 2019 at 8:53 AM Sebastian Huber < > sebastian.hu...@embedded-brains.de> wrote: > >> Hello, >> >> I am about to update the Doxygen Recommendations in the RTEMS Software >> Engineering handbook. Currently, there is a lot of o

Re: BSP Basics in Doxygen Recommendations?

2019-03-14 Thread Gedare Bloom
On Thu, Mar 14, 2019 at 8:53 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > Hello, > > I am about to update the Doxygen Recommendations in the RTEMS Software > Engineering handbook. Currently, there is a lot of other content mixed > in such as "BSP Basics". We should really try

Re: [PATCH 0/1] eng: Add software test framework chapter

2019-03-14 Thread Gedare Bloom
Do we also want to document the adhoc testsuite here? On Thu, Mar 14, 2019 at 6:23 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > This patch adds a "Software Test Framework" to the "RTEMS Software > Engineering" handbook. A PDF document with this patch can be viewed here: > >

Re: [PATCH 1/3] z85c30.c: Do not process 0 baud and return an error (CID 1399713)

2019-03-14 Thread Sebastian Huber
On 14/03/2019 14:22, Joel Sherrill wrote: _Assert( baud_number != 0 ); + /* + * POSIX says baud rate of zero is a request to hang up or disconnect. + * This is not supported by this driver. + */ + _Assert( baud_number != 0 ); Duplicate assert. -- Sebastian Huber, embedded brai

[PATCH 2/3] fifo.c: Eliminate logically dead code (Coverity 1437635)

2019-03-14 Thread Joel Sherrill
--- cpukit/libfs/src/pipe/fifo.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/cpukit/libfs/src/pipe/fifo.c b/cpukit/libfs/src/pipe/fifo.c index 71d5f85..3275e5f 100644 --- a/cpukit/libfs/src/pipe/fifo.c +++ b/cpukit/libfs/src/pipe/fifo.c @@ -149,18 +149,15 @@ s

[PATCH 1/3] z85c30.c: Do not process 0 baud and return an error (CID 1399713)

2019-03-14 Thread Joel Sherrill
--- bsps/shared/dev/serial/z85c30.c | 9 + 1 file changed, 9 insertions(+) diff --git a/bsps/shared/dev/serial/z85c30.c b/bsps/shared/dev/serial/z85c30.c index 55df9d3..d1f4a6f 100644 --- a/bsps/shared/dev/serial/z85c30.c +++ b/bsps/shared/dev/serial/z85c30.c @@ -456,6 +456,15 @@ Z85C30_S

[PATCH 3/3] main_edit.c: Use strncpy() to eliminate potential buffer overflow.

2019-03-14 Thread Joel Sherrill
--- cpukit/libmisc/shell/main_edit.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/cpukit/libmisc/shell/main_edit.c b/cpukit/libmisc/shell/main_edit.c index 079e9ff..e43ff68 100644 --- a/cpukit/libmisc/shell/main_edit.c +++ b/cpukit/libmisc/shell/main_edit.c @@ -286,

[PATCH] leon2-sis.ini, leon3-sis.ini: Correct run arguments

2019-03-14 Thread Joel Sherrill
--- tester/rtems/testing/bsps/leon2-sis.ini | 2 +- tester/rtems/testing/bsps/leon3-sis.ini | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tester/rtems/testing/bsps/leon2-sis.ini b/tester/rtems/testing/bsps/leon2-sis.ini index 61205ad..d0dd315 100644 --- a/tester/rtems/tes

BSP Basics in Doxygen Recommendations?

2019-03-14 Thread Sebastian Huber
Hello, I am about to update the Doxygen Recommendations in the RTEMS Software Engineering handbook. Currently, there is a lot of other content mixed in such as "BSP Basics". We should really try to avoid all the duplication across the documentation set which is simply not maintainable. What i

[PATCH] config: Add x86_64 to tier-3 archs

2019-03-14 Thread Sebastian Huber
--- config/rtems-bsps-tiers.ini | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/rtems-bsps-tiers.ini b/config/rtems-bsps-tiers.ini index 34d7143..64ad105 100644 --- a/config/rtems-bsps-tiers.ini +++ b/config/rtems-bsps-tiers.ini @@ -37,7 +37,7 @@ bsps_powerpc = qoriq_e50

Re: [rtems-bsp-builder] 2019-03-13 12:11:40: Profile(s): everything

2019-03-14 Thread Sebastian Huber
It seems that the BSP builder doesn't build the x86_64 architecture. If I build it by hand, on my system it fails with: gmake[5]: Entering directory '/build/git-build/b-all-x86_64-5/x86_64-rtems5/c/amd64/testsuites/samples' x86_64-rtems5-gcc  -mno-red-zone -mcmodel=large -Werror=return-type -O2

[PATCH 3/3] ttest01: New test

2019-03-14 Thread Sebastian Huber
This is an example test using the T Test Framework. It tests also the framework itself. Add T_FILE_NAME command line define to get rid of the full file path. This is important to reduce the read-only data of test files and make them build system independent. Update #3199. --- testsuites/automak

[PATCH 1/3] build: Move test support to librtemstest.a

2019-03-14 Thread Sebastian Huber
One reason to move the test support into a dedicated library are the standard output __wrap_*() functions. They may conflict with application level wrappers. Update #3199. --- cpukit/Makefile.am | 14 +- cpukit/{libmisc/testsupport => libtest}/tes

[PATCH 0/1] eng: Add software test framework chapter

2019-03-14 Thread Sebastian Huber
This patch adds a "Software Test Framework" to the "RTEMS Software Engineering" handbook. A PDF document with this patch can be viewed here: https://ftp.rtems.org/pub/rtems/people/sebh/eng.pdf An example test report can be viewed here: https://ftp.rtems.org/pub/rtems/people/sebh/test-report.pdf

[PATCH 1/1] eng: Add software test framework chapter

2019-03-14 Thread Sebastian Huber
Update #3199. --- eng/index.rst |3 + eng/test-framework.rst | 2077 2 files changed, 2080 insertions(+) create mode 100644 eng/test-framework.rst diff --git a/eng/index.rst b/eng/index.rst index fe51e91..f29d0f3 100644 --- a/eng/inde

[PATCH] eng: Change title to RTEMS Software Engineering

2019-03-14 Thread Sebastian Huber
Use a shorter title so that the PDF page header fits into one line. --- eng/conf.py | 4 ++-- eng/index.rst | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/eng/conf.py b/eng/conf.py index eb838fd..a8a0d71 100644 --- a/eng/conf.py +++ b/eng/conf.py @@ -3,12 +3,12 @@ sys