Re: Generating separate coverage reports for different symbol-sets from covoar

2018-05-30 Thread Gedare Bloom
On Wed, May 30, 2018 at 5:20 PM, Vijay Kumar Banerjee wrote: > Hello, > > The covoar currently is capable of processing multisets > from the symbol-sets ini file, however, it currently keeps > all the reports in the same directory (../coverage/score). > > Before the recent updates to covoar it cou

Generating separate coverage reports for different symbol-sets from covoar

2018-05-30 Thread Vijay Kumar Banerjee
Hello, The covoar currently is capable of processing multisets from the symbol-sets ini file, however, it currently keeps all the reports in the same directory (../coverage/score). Before the recent updates to covoar it could only read one set/subsystem from an ini file, and the script used to lo

Re: [PATCH] Generate coverage analysis Report

2018-05-30 Thread Vijay Kumar Banerjee
On 31 May 2018 at 02:02, Joel Sherrill wrote: > > > On Wed, May 30, 2018 at 3:29 PM, Vijay Kumar Banerjee < > vijaykumar9...@gmail.com> wrote: > >> On 31 May 2018 at 00:28, Joel Sherrill wrote: >> >>> >>> >>> I may not understand correctly but there is test_run and coverage_run. >>> Someone >>>

Re: [PATCH] Generate coverage analysis Report

2018-05-30 Thread Joel Sherrill
On Wed, May 30, 2018 at 3:29 PM, Vijay Kumar Banerjee < vijaykumar9...@gmail.com> wrote: > On 31 May 2018 at 00:28, Joel Sherrill wrote: > >> >> >> I may not understand correctly but there is test_run and coverage_run. >> Someone >> suggested making coverage_running an option to test_run. If that

Re: [PATCH] Generate coverage analysis Report

2018-05-30 Thread Vijay Kumar Banerjee
On 31 May 2018 at 00:28, Joel Sherrill wrote: > > > I may not understand correctly but there is test_run and coverage_run. > Someone > suggested making coverage_running an option to test_run. If that's what's > being > asked for, then I think doing it in a follow up patch is OK. > > If that's the

Re: [PATCH 1/1] Fix and extend error message in posix timer test

2018-05-30 Thread Joel Sherrill
I've applied the patch and will run the tests. If OK, then I should be pushing soon. On Wed, May 30, 2018 at 1:50 PM, Gedare Bloom wrote: > I'm having trouble standing up a sparc-rtems5/erc32 build right now, > so I can't test this. > > On Wed, May 30, 2018 at 1:44 PM, Joel Sherrill wrote: > >

Re: [PATCH] Generate coverage analysis Report

2018-05-30 Thread Joel Sherrill
On Wed, May 30, 2018 at 1:34 PM, Vijay Kumar Banerjee < vijaykumar9...@gmail.com> wrote: > On 30 May 2018 at 23:29, Joel Sherrill wrote: > >> >> >> On Wed, May 30, 2018 at 12:54 PM, Vijay Kumar Banerjee < >> vijaykumar9...@gmail.com> wrote: >> >>> On 30 May 2018 at 22:51, Gedare Bloom wrote: >>>

Re: [PATCH 1/1] Fix and extend error message in posix timer test

2018-05-30 Thread Gedare Bloom
I'm having trouble standing up a sparc-rtems5/erc32 build right now, so I can't test this. On Wed, May 30, 2018 at 1:44 PM, Joel Sherrill wrote: > > > On Wed, May 30, 2018 at 10:33 AM, Gedare Bloom wrote: >> >> This looks fine to me, and I'll commit after I can test it. (We >> currently don't ap

Re: [PATCH] Generate coverage analysis Report

2018-05-30 Thread Vijay Kumar Banerjee
On 30 May 2018 at 23:29, Joel Sherrill wrote: > > > On Wed, May 30, 2018 at 12:54 PM, Vijay Kumar Banerjee < > vijaykumar9...@gmail.com> wrote: > >> On 30 May 2018 at 22:51, Gedare Bloom wrote: >> >>> Please provide your name in your commits (git config --user.name "My >>> Name") that you submit

Re: [PATCH] Generate coverage analysis Report

2018-05-30 Thread Vijay Kumar Banerjee
On 30 May 2018 at 22:51, Gedare Bloom wrote: > > +def coverage_run(opts, coverage, executables): > > +coverage.executables = executables > > +coverage.run() > > + > > def run(command_path = None): > > import sys > > tests = [] > > @@ -221,15 +228,16 @@ def run(command_path = No

Re: [PATCH] Generate coverage analysis Report

2018-05-30 Thread Joel Sherrill
On Wed, May 30, 2018 at 12:54 PM, Vijay Kumar Banerjee < vijaykumar9...@gmail.com> wrote: > On 30 May 2018 at 22:51, Gedare Bloom wrote: > >> Please provide your name in your commits (git config --user.name "My >> Name") that you submit. >> >> OK Noted :) > >> The first line of this commit, and t

Re: [PATCH] Generate coverage analysis Report

2018-05-30 Thread Cillian O'Donnell
On Wed, 30 May 2018, 18:54 Vijay Kumar Banerjee, wrote: > On 30 May 2018 at 22:51, Gedare Bloom wrote: > >> Please provide your name in your commits (git config --user.name "My >> Name") that you submit. >> >> OK Noted :) > >> The first line of this commit, and therefore the email subject, is >>

Re: [PATCH] Generate coverage analysis Report

2018-05-30 Thread Vijay Kumar Banerjee
On 30 May 2018 at 22:51, Gedare Bloom wrote: > Please provide your name in your commits (git config --user.name "My > Name") that you submit. > > OK Noted :) > The first line of this commit, and therefore the email subject, is > overly vague. Provide a slightly more specific description. > On We

Re: [PATCH] Generate coverage analysis Report

2018-05-30 Thread Cillian O'Donnell
On Wed, 30 May 2018, 18:21 Gedare Bloom, wrote: > Please provide your name in your commits (git config --user.name "My > Name") that you submit. > > The first line of this commit, and therefore the email subject, is > overly vague. Provide a slightly more specific description. > > On Wed, May 30,

Re: [PATCH 1/1] Fix and extend error message in posix timer test

2018-05-30 Thread Joel Sherrill
On Wed, May 30, 2018 at 10:33 AM, Gedare Bloom wrote: > This looks fine to me, and I'll commit after I can test it. (We > currently don't apply any significance to --signed-off-by in RTEMS > Project.) I'm investigating your inquiry on the 0/1 cover letter. > I am ok with it if it tests OK with y

Re: Coverage support for tester

2018-05-30 Thread Joel Sherrill
On Wed, May 30, 2018 at 12:25 PM, Cillian O'Donnell wrote: > > > On Wed, 30 May 2018, 18:15 Vijay Kumar Banerjee, > wrote: > >> >> >> On Wed, 30 May 2018, 22:42 Cillian O'Donnell, >> wrote: >> >>> >>> >>> On Wed, 30 May 2018, 16:58 Gedare Bloom, wrote: >>> On Wed, May 30, 2018 at 11:32 AM

Re: Coverage support for tester

2018-05-30 Thread Vijay Kumar Banerjee
On 30 May 2018 at 22:55, Cillian O'Donnell wrote: > > > On Wed, 30 May 2018, 18:15 Vijay Kumar Banerjee, > wrote: > >> >> >> On Wed, 30 May 2018, 22:42 Cillian O'Donnell, >> wrote: >> >>> >>> >>> On Wed, 30 May 2018, 16:58 Gedare Bloom, wrote: >>> On Wed, May 30, 2018 at 11:32 AM, Vijay K

Re: Coverage support for tester

2018-05-30 Thread Cillian O'Donnell
On Wed, 30 May 2018, 18:15 Vijay Kumar Banerjee, wrote: > > > On Wed, 30 May 2018, 22:42 Cillian O'Donnell, > wrote: > >> >> >> On Wed, 30 May 2018, 16:58 Gedare Bloom, wrote: >> >>> On Wed, May 30, 2018 at 11:32 AM, Vijay Kumar Banerjee >>> wrote: >>> > On 30 May 2018 at 20:18, Gedare Bloom

buffer overrun in rtems_rfs_bitmap_create_search()

2018-05-30 Thread Walter Lee
Hi. I am encountering a buffer overrun in rtems_rfs_bitmap_create_search(). It seems that whenever the bitmap uses the last bit of its search_map (i.e. (control->size + 31) % 32 == 32)), the loop will write to the word one beyond the end of search_map. I filed a bug at https://devel.rtems.org/ti

Re: [PATCH] Generate coverage analysis Report

2018-05-30 Thread Gedare Bloom
Please provide your name in your commits (git config --user.name "My Name") that you submit. The first line of this commit, and therefore the email subject, is overly vague. Provide a slightly more specific description. On Wed, May 30, 2018 at 1:00 PM, thelunatic wrote: > + Add script to run cov

Re: Coverage support for tester

2018-05-30 Thread Vijay Kumar Banerjee
On Wed, 30 May 2018, 22:42 Cillian O'Donnell, wrote: > > > On Wed, 30 May 2018, 16:58 Gedare Bloom, wrote: > >> On Wed, May 30, 2018 at 11:32 AM, Vijay Kumar Banerjee >> wrote: >> > On 30 May 2018 at 20:18, Gedare Bloom wrote: >> >> >> >> Hello Vijay, >> >> >> >> Do you expect/need an answer t

Re: Coverage support for tester

2018-05-30 Thread Cillian O'Donnell
On Wed, 30 May 2018, 16:58 Gedare Bloom, wrote: > On Wed, May 30, 2018 at 11:32 AM, Vijay Kumar Banerjee > wrote: > > On 30 May 2018 at 20:18, Gedare Bloom wrote: > >> > >> Hello Vijay, > >> > >> Do you expect/need an answer to something in here? > >> > >> gedare > >> > > Hello, > > > > I wante

[PATCH] Generate coverage analysis Report

2018-05-30 Thread thelunatic
+ Add script to run covoar and generate an html report from the output generated from covoar + Add symbol-sets ini file for library addresses of the symbol-sets + tester/rt/test : Add options for running coverage Co-author : Cillian O'Donnel --- tester/rt/coverage.py | 38

Re: configure/make with multiple jobs error?

2018-05-30 Thread Gedare Bloom
On Wed, May 30, 2018 at 12:15 PM, Gedare Bloom wrote: > On Wed, May 30, 2018 at 12:10 PM, Gedare Bloom wrote: >> Hello all, >> >> I got a strange error just now with a fresh toolchain and current master. >> >> I did: >> $ ../../rtems/configure --target=sparc-rtems5 --enable-rtemsbsp=erc32 >> --en

Re: configure/make with multiple jobs error?

2018-05-30 Thread Gedare Bloom
On Wed, May 30, 2018 at 12:10 PM, Gedare Bloom wrote: > Hello all, > > I got a strange error just now with a fresh toolchain and current master. > > I did: > $ ../../rtems/configure --target=sparc-rtems5 --enable-rtemsbsp=erc32 > --enable-tests > This was OK. > > $ make -j4 > This errored out with

Re: [PATCH] Updating trace buffer configuration

2018-05-30 Thread Sebastian Huber
- Am 30. Mai 2018 um 15:35 schrieb Amaan Cheval amaan.che...@gmail.com: [...] > Minor, but in most other places in RTEMS, I've seen pointers declared > with the asterisk on the variable not on the type ("int *ptr;" instead > of "int* ptr;"). [...] The int *ptr; is RTEMS-style, the int* ptr

configure/make with multiple jobs error?

2018-05-30 Thread Gedare Bloom
Hello all, I got a strange error just now with a fresh toolchain and current master. I did: $ ../../rtems/configure --target=sparc-rtems5 --enable-rtemsbsp=erc32 --enable-tests This was OK. $ make -j4 This errored out with: checking for gawk... gawk checking whether make sets $(MAKE)... yes chec

Re: [GSOC] CTF generator configuration files

2018-05-30 Thread Sebastian Huber
- Am 30. Mai 2018 um 13:40 schrieb Vidushi Vashishth reachv...@gmail.com: > Thats alright no problem! I will begin work on the documentation. Ok, good. I am a lazy person and need your documentation to get started. I should be able to reproduce your stuff easily using the new documentation i

Re: Coverage support for tester

2018-05-30 Thread Gedare Bloom
On Wed, May 30, 2018 at 11:32 AM, Vijay Kumar Banerjee wrote: > On 30 May 2018 at 20:18, Gedare Bloom wrote: >> >> Hello Vijay, >> >> Do you expect/need an answer to something in here? >> >> gedare >> > Hello, > > I wanted to know if there were any plans on how covoar > should store the reports w

Re: [PATCH v2] Updating trace buffer configuration

2018-05-30 Thread Sebastian Huber
This patch doesn't apply. Please generate patches against the upstream master and not one of your local branches. ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH 1/1] Fix and extend error message in posix timer test

2018-05-30 Thread Gedare Bloom
This looks fine to me, and I'll commit after I can test it. (We currently don't apply any significance to --signed-off-by in RTEMS Project.) I'm investigating your inquiry on the 0/1 cover letter. On Tue, May 15, 2018 at 5:21 AM, Martin Erik Werner wrote: > _Timespec_Equal_to() does not set errno

Re: Coverage support for tester

2018-05-30 Thread Vijay Kumar Banerjee
On 30 May 2018 at 20:18, Gedare Bloom wrote: > Hello Vijay, > > Do you expect/need an answer to something in here? > > gedare > > Hello, I wanted to know if there were any plans on how covoar should store the reports when running for multisets. Earlier it used to be done by the coverage script,

[PATCH v2] Updating trace buffer configuration

2018-05-30 Thread Vidushi Vashishth
--- linkers/rtld-trace-buffer.ini | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/linkers/rtld-trace-buffer.ini b/linkers/rtld-trace-buffer.ini index ee68d55..c17f2f1 100644 --- a/linkers/rtld-trace-buffer.ini +++ b/linkers/rtld-trace-buffer.ini @@ -27,6 +27,7 @@ header = "#i

Re: Coverage support for tester

2018-05-30 Thread Gedare Bloom
Hello Vijay, Do you expect/need an answer to something in here? gedare On Wed, May 30, 2018 at 10:29 AM, Vijay Kumar Banerjee wrote: > On 30 May 2018 at 00:54, Joel Sherrill wrote: >> >> >> >> On Tue, May 29, 2018 at 11:27 AM, Vijay Kumar Banerjee >> wrote: >>> >>> >>> >>> On Tue, 29 May 2018

Re: [PATCH] Updating trace buffer configuration

2018-05-30 Thread Gedare Bloom
Vidushi, For revisions to patches, please use the "-v" option for git-format-patch before you git-send-email the patch files to append a version number, in this case, use git format-patch -v 2 HEAD^ -o ../ to generate a patch from the head commit in the parent directory having the "v2" appended to

Re: [PATCH] Updating trace buffer configuration

2018-05-30 Thread Vidushi Vashishth
--- linkers/rtld-trace-buffer.ini | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/linkers/rtld-trace-buffer.ini b/linkers/rtld-trace-buffer.ini index ee68d55..c17f2f1 100644 --- a/linkers/rtld-trace-buffer.ini +++ b/linkers/rtld-trace-buffer.ini @@ -27,6 +27,7 @@ header = "#i

Re: Coverage support for tester

2018-05-30 Thread Vijay Kumar Banerjee
On 30 May 2018 at 00:54, Joel Sherrill wrote: > > > On Tue, May 29, 2018 at 11:27 AM, Vijay Kumar Banerjee < > vijaykumar9...@gmail.com> wrote: > >> >> >> On Tue, 29 May 2018, 20:10 Joel Sherrill, wrote: >> >>> >>> >>> On Mon, May 28, 2018 at 11:08 PM, Chris Johns wrote: >>> On 29/5/18 4:2

Re: (release notes generator) Do we need to worry about attachment?

2018-05-30 Thread Gedare Bloom
On Tue, May 29, 2018 at 5:14 PM, Chris Johns wrote: > On 30/5/18 5:30 am, Dannie Huang wrote: >> I am now able to grab most of needed information from ticket's page by using >> python (like ticket id, description, comments, etc). > > Fantastic. > >> There is a place for >> attachment on a ticket's

Re: [PATCH] Updating trace buffer configuration

2018-05-30 Thread Vidushi Vashishth
>Based on this error, I believe you need to drop the "struct", given >that Thread_Control is the typedef for "struct _Thread_Control". Oh yes you are right. It was originally written with the "struct" so I somehow overlooked it. I tired it this way. It works thanks. >Minor, but in most other plac

Re: [PATCH] c-user: Fix rtems_region_create() return status

2018-05-30 Thread Joel Sherrill
On Wed, May 30, 2018 at 8:29 AM, Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 30/05/18 14:13, Joel Sherrill wrote: > >> Why is improperly aligned not an error? >> > > _Heap_Initialize() will align it. It fails only if the area is too small. Then there should be a note in reg

Re: [PATCH] Updating trace buffer configuration

2018-05-30 Thread Amaan Cheval
On Wed, May 30, 2018 at 6:33 PM, Vidushi Vashishth wrote: > Could you please change the > > struct _Thread_Control > > to > > Thread_Control > > and check if it still works. > > In RTEMS, we use typedefs for structures in general. > > I tried to include the threadq.h header file so that I could us

Re: [PATCH] c-user: Fix rtems_region_create() return status

2018-05-30 Thread Sebastian Huber
On 30/05/18 14:13, Joel Sherrill wrote: Why is improperly aligned not an error? _Heap_Initialize() will align it. It fails only if the area is too small. -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89

Re: [PATCH] Updating trace buffer configuration

2018-05-30 Thread Vidushi Vashishth
Could you please change the struct _Thread_Control to Thread_Control and check if it still works. In RTEMS, we use typedefs for structures in general. I tried to include the threadq.h header file so that I could use the variable Thread_Control instead of _Thread_Control. This header file has

Re: [PATCH] c-user: Fix rtems_region_create() return status

2018-05-30 Thread Joel Sherrill
Why is improperly aligned not an error? On Wed, May 30, 2018, 3:53 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > --- > c-user/region_manager.rst | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/c-user/region_manager.rst b/c-user/region_manager.rst

Re: [PATCH] beagle: Disable WiFi if libbsd is build without it.

2018-05-30 Thread Udit agarwal
Hi, Thanks, that patch worked perfectly. Wifi is now, by default disabled. Regards, Udit agarwal On Wed, May 30, 2018 at 5:04 PM, Christian Mauderer < christian.maude...@embedded-brains.de> wrote: > Update #3351. > --- > rtemsbsd/include/bsp/nexus-devices.h | 3 +++ > 1 file changed, 3 insertio

Re: [GSOC] CTF generator configuration files

2018-05-30 Thread Vidushi Vashishth
Thats alright no problem! I will begin work on the documentation. On Wed, May 30, 2018 at 4:59 PM, Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 30/05/18 13:27, Vidushi Vashishth wrote: > >> Hi Sebastian! >> >> Yes I have been working on the documentation. I wrote a blog abo

[PATCH] beagle: Disable WiFi if libbsd is build without it.

2018-05-30 Thread Christian Mauderer
Update #3351. --- rtemsbsd/include/bsp/nexus-devices.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/rtemsbsd/include/bsp/nexus-devices.h b/rtemsbsd/include/bsp/nexus-devices.h index 13d51ceb..f7003923 100644 --- a/rtemsbsd/include/bsp/nexus-devices.h +++ b/rtemsbsd/include/bsp/nexus-dev

Re: [GSOC] CTF generator configuration files

2018-05-30 Thread Sebastian Huber
On 30/05/18 13:27, Vidushi Vashishth wrote: Hi Sebastian! Yes I have been working on the documentation. I wrote a blog about the the tracing framework use cases a while ago. It can be seen here https://vidushivashishth.github.io/Third-post-copy/ I will write a blog about trace buffer generatio

Re: [GSOC] CTF generator configuration files

2018-05-30 Thread Vidushi Vashishth
Hi Sebastian! Yes I have been working on the documentation. I wrote a blog about the the tracing framework use cases a while ago. It can be seen here https://vidushivashishth.github.io/Third-post-copy/ I will write a blog about trace buffer generation which would explain all the questions you have

Re: [GSoC] Ways to make the x86_64 port work with UEFI

2018-05-30 Thread Amaan Cheval
On Wed, May 30, 2018 at 4:30 AM, Joel Sherrill wrote: > > > On Tue, May 29, 2018 at 11:26 AM, Amaan Cheval > wrote: >> >> On Tue, May 29, 2018 at 9:28 PM, Amaan Cheval >> wrote: >> > Noted, thanks a ton for the details! Unrelated to the topic at hand, >> > but out of interest, is this the only r

[PATCH] c-user: Fix rtems_region_create() return status

2018-05-30 Thread Sebastian Huber
--- c-user/region_manager.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/c-user/region_manager.rst b/c-user/region_manager.rst index 1bebd8a..713fb07 100644 --- a/c-user/region_manager.rst +++ b/c-user/region_manager.rst @@ -255,12 +255,13 @@ DIRECTIVE STATUS CODES: