Re: [PATCH] [RTEMS] Update RTEMS thread model

2015-09-03 Thread Sebastian Huber
On 03/09/15 15:47, Martin Galvan wrote: Hi Sebastian! Thanks for your answer. There are a couple of things I still don't get :) On Thu, Sep 3, 2015 at 2:48 AM, Sebastian Huber wrote: I updated the rtems-testing repository. 1. You have to adjust the VERSIONS file. Is this file meant to help t

Re: [PATCH] smp: Documentation

2015-09-03 Thread Sebastian Huber
On 03/09/15 17:09, Gedare Bloom wrote: On Thu, Sep 3, 2015 at 8:46 AM, Sebastian Huber wrote: --- doc/user/smp.t | 66 ++ 1 file changed, 66 insertions(+) diff --git a/doc/user/smp.t b/doc/user/smp.t index 2ab9aaf..a06be8a 100644 ---

Re: [PATCH 1/4] smp: Documentation

2015-09-03 Thread Sebastian Huber
On 03/09/15 16:59, Gedare Bloom wrote: On Thu, Sep 3, 2015 at 8:01 AM, Sebastian Huber wrote: >--- > doc/user/smp.t | 38 ++ > 1 file changed, 38 insertions(+) > >diff --git a/doc/user/smp.t b/doc/user/smp.t >index 1b4849a..ba700e0 100644 >--- a/doc/user/

[wwwdocs] GCC 6 Release Notes for RTEMS

2015-09-03 Thread Sebastian Huber
Index: htdocs/gcc-6/changes.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-6/changes.html,v retrieving revision 1.25 diff -u -r1.25 changes.html --- htdocs/gcc-6/changes.html 25 Aug 2015 22:27:46 - 1.25 +++ htdocs/gcc-6/cha

Re: [PATCH] cpukit/libnetworking/rtems/rtems_dhcp.c: Fix compilation error

2015-09-03 Thread Daniel Gutson
On Thu, Sep 3, 2015 at 5:44 PM, Joel Sherrill wrote: > Should be committed now. > > I guess one of us should have compiled it. :) Don't worry, Martin will buy some beers because of this. Cheers. Daniel. > > --joel > > On 9/3/2015 3:25 PM, Martin Galvan wrote: >> >> Apparently 'free' is define

[PATCH] cpukit/libmisc/dumpbuf/dumpbuf.c: Fix compilation warnings

2015-09-03 Thread Martin Galvan
Compiling dumpbuf.c causes the following warning to be issued: warning: pointer targets in passing argument 1 of 'snprintf' differ in signedness [-Wpointer-sign] This happens because line_buffer is declared as unsigned. Closes #2411. --- cpukit/libmisc/dumpbuf/dumpbuf.c | 2 +- 1 file changed,

Re: [PATCH] cpukit/libnetworking/rtems/rtems_dhcp.c: Fix compilation error

2015-09-03 Thread Joel Sherrill
Should be committed now. I guess one of us should have compiled it. :) --joel On 9/3/2015 3:25 PM, Martin Galvan wrote: Apparently 'free' is defined as a macro which takes two arguments and calls rtems_bsdnet_free. When fixing #2405 I added a missing 'free' but didn't notice it was non-standar

[PATCH] cpukit/libnetworking/rtems/rtems_dhcp.c: Fix compilation error

2015-09-03 Thread Martin Galvan
Apparently 'free' is defined as a macro which takes two arguments and calls rtems_bsdnet_free. When fixing #2405 I added a missing 'free' but didn't notice it was non-standard. Closes #2410. --- cpukit/libnetworking/rtems/rtems_dhcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

Re: [PATCH v2 4/5] cpukit/libmisc/dumpbuf/dumpbuf.c: Fix undefined behavior for sprintf()

2015-09-03 Thread Joel Sherrill
On 9/3/2015 12:18 PM, Daniel Gutson wrote: On Thu, Sep 3, 2015 at 1:21 PM, Joel Sherrill wrote: On 9/2/2015 4:54 PM, Martin Galvan wrote: I also used the 'n' versions of the string functions, #define'd magic numbers and added a few comments. Great on the 'n' versions! One comment. Why

Re: [PATCH v2 4/5] cpukit/libmisc/dumpbuf/dumpbuf.c: Fix undefined behavior for sprintf()

2015-09-03 Thread Daniel Gutson
On Thu, Sep 3, 2015 at 1:21 PM, Joel Sherrill wrote: > > > On 9/2/2015 4:54 PM, Martin Galvan wrote: >> >> I also used the 'n' versions of the string functions, #define'd magic >> numbers >> and added a few comments. > > > Great on the 'n' versions! > > One comment. Why is the output buffer now st

Re: [PATCH v2 4/5] cpukit/libmisc/dumpbuf/dumpbuf.c: Fix undefined behavior for sprintf()

2015-09-03 Thread Martin Galvan
On Thu, Sep 3, 2015 at 1:21 PM, Joel Sherrill wrote: > One comment. Why is the output buffer now static? I know it > moves it off the stack but what's the consensus on an 80 > byte array on a stack? I'm not sure what the consensus is. I briefly discussed this with Daniel and it's ok with us, but

Re: [PATCH v2 3/5] tools/cpu/nios2/ptf.c: Fix leak of memory pointed to by new_prefix

2015-09-03 Thread Martin Galvan
On Thu, Sep 3, 2015 at 1:20 PM, Joel Sherrill wrote: > Am I misreading this or did the formatting change? > > It looks like the indentation on the "+" lines is different Indeed :) Now the '+' lines are executed only if new_prefix != NULL (new_prefix being the result of malloc). The resulting code

Re: [PATCH v2 1/5] various .h files: Add missing C++ extern wrappers

2015-09-03 Thread Joel Sherrill
I committed 1, 2, and 5 to 4.11 and master. The ticket closed with 5. Once the questions about 3 and 4 are answered, then I will apply those. On 9/2/2015 4:54 PM, Martin Galvan wrote: Updates #2405. --- c/src/lib/libbsp/shared/umon/umon.h | 4 cpukit/posix/include/rtems/posix/pt

Re: [PATCH v2 4/5] cpukit/libmisc/dumpbuf/dumpbuf.c: Fix undefined behavior for sprintf()

2015-09-03 Thread Joel Sherrill
On 9/2/2015 4:54 PM, Martin Galvan wrote: I also used the 'n' versions of the string functions, #define'd magic numbers and added a few comments. Great on the 'n' versions! One comment. Why is the output buffer now static? I know it moves it off the stack but what's the consensus on an 80 by

Re: [PATCH v2 3/5] tools/cpu/nios2/ptf.c: Fix leak of memory pointed to by new_prefix

2015-09-03 Thread Joel Sherrill
Am I misreading this or did the formatting change? It looks like the indentation on the "+" lines is different On 9/2/2015 4:54 PM, Martin Galvan wrote: Updates #2405. --- tools/cpu/nios2/ptf.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/too

Re: [PATCH] RTEMS CAN Rough Draft Implementation

2015-09-03 Thread Gedare Bloom
This is on my list but I'm back-logged. Hopefully someone else can check through it, preferably someone who is knowledgeable about CAN. :) On Thu, Aug 27, 2015 at 2:45 PM, Isaac Gutekunst wrote: > Hi All, > > Here is the RTEMS CAN driver framework I've been talking about. Please give > me feedbac

Re: [PATCH 4/4] score: Implement priority boosting

2015-09-03 Thread Gedare Bloom
3 and 4 look good. On Thu, Sep 3, 2015 at 8:01 AM, Sebastian Huber wrote: > --- > cpukit/score/include/rtems/score/threadimpl.h | 31 + > cpukit/score/include/rtems/score/threadqimpl.h | 25 +++ > cpukit/score/src/coremutexseize.c | 2 +- > cpukit/score/src/cor

Re: [PATCH v2 5/5] cpukit/libnetworking/rtems/rtems_dhcp.c: Fix leak on realloc failure for dhcp_hostname.

2015-09-03 Thread Gedare Bloom
Joel, Review/Commit these if happy. Gedare On Wed, Sep 2, 2015 at 5:54 PM, Martin Galvan wrote: > Closes #2405. > --- > cpukit/libnetworking/rtems/rtems_dhcp.c | 18 +- > 1 file changed, 13 insertions(+), 5 deletions(-) > > diff --git a/cpukit/libnetworking/rtems/rtems_dhcp.c

Re: [PATCH 2/4] score: Documentation

2015-09-03 Thread Gedare Bloom
On Thu, Sep 3, 2015 at 8:01 AM, Sebastian Huber wrote: > --- > cpukit/score/include/rtems/score/threadq.h | 31 > -- > 1 file changed, 29 insertions(+), 2 deletions(-) > > diff --git a/cpukit/score/include/rtems/score/threadq.h > b/cpukit/score/include/rtems/score/th

Re: [PATCH] smp: Documentation

2015-09-03 Thread Gedare Bloom
On Thu, Sep 3, 2015 at 8:46 AM, Sebastian Huber wrote: > --- > doc/user/smp.t | 66 > ++ > 1 file changed, 66 insertions(+) > > diff --git a/doc/user/smp.t b/doc/user/smp.t > index 2ab9aaf..a06be8a 100644 > --- a/doc/user/smp.t > +++ b/doc/

Re: [PATCH 1/4] smp: Documentation

2015-09-03 Thread Gedare Bloom
On Thu, Sep 3, 2015 at 8:01 AM, Sebastian Huber wrote: > --- > doc/user/smp.t | 38 ++ > 1 file changed, 38 insertions(+) > > diff --git a/doc/user/smp.t b/doc/user/smp.t > index 1b4849a..ba700e0 100644 > --- a/doc/user/smp.t > +++ b/doc/user/smp.t > @@ -147,6

Re: [PATCH] [RTEMS] Update RTEMS thread model

2015-09-03 Thread Martin Galvan
Hi Sebastian! Thanks for your answer. There are a couple of things I still don't get :) On Thu, Sep 3, 2015 at 2:48 AM, Sebastian Huber wrote: > I updated the rtems-testing repository. > > 1. You have to adjust the VERSIONS file. Is this file meant to help the scripts download the tool sources a

[PATCH] smp: Documentation

2015-09-03 Thread Sebastian Huber
--- doc/user/smp.t | 66 ++ 1 file changed, 66 insertions(+) diff --git a/doc/user/smp.t b/doc/user/smp.t index 2ab9aaf..a06be8a 100644 --- a/doc/user/smp.t +++ b/doc/user/smp.t @@ -465,6 +465,72 @@ architecture please consult the @cite{RTEM

[PATCH 3/4] score: Implement SMP specific priority queue

2015-09-03 Thread Sebastian Huber
--- cpukit/sapi/include/confdefs.h | 7 +- cpukit/score/include/rtems/score/threadq.h | 44 +++- cpukit/score/include/rtems/score/threadqimpl.h | 16 ++ cpukit/score/src/thread.c | 3 +- cpukit/score/src/threadinitialize.c| 4 +- cpukit/

[PATCH 1/4] smp: Documentation

2015-09-03 Thread Sebastian Huber
--- doc/user/smp.t | 38 ++ 1 file changed, 38 insertions(+) diff --git a/doc/user/smp.t b/doc/user/smp.t index 1b4849a..ba700e0 100644 --- a/doc/user/smp.t +++ b/doc/user/smp.t @@ -147,6 +147,44 @@ another processor. So if we enable interrupts during this tr

[PATCH 4/4] score: Implement priority boosting

2015-09-03 Thread Sebastian Huber
--- cpukit/score/include/rtems/score/threadimpl.h | 31 + cpukit/score/include/rtems/score/threadqimpl.h | 25 +++ cpukit/score/src/coremutexseize.c | 2 +- cpukit/score/src/coremutexsurrender.c | 1 + cpukit/score/src/mutex.c | 15

[PATCH 2/4] score: Documentation

2015-09-03 Thread Sebastian Huber
--- cpukit/score/include/rtems/score/threadq.h | 31 -- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/cpukit/score/include/rtems/score/threadq.h b/cpukit/score/include/rtems/score/threadq.h index 8f2b138..2b58310 100644 --- a/cpukit/score/include/rtems