Re: [PATCH 2/3] rbtree: Add _RBTree_Replace_node()

On 31/08/15 16:30, Gedare Bloom wrote: It's on the caller to ensure no ordering violation? Yes, I added this function for the Linux rbtree support. One user is the JFFS2 file system. -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89

Re: [PATCH v3] ARMv7M: Fix exception handler for supporting FPU

Martin's ticket works, and his commit can #close it. On Mon, Aug 31, 2015 at 3:22 PM, sudarshan.rajagopalan wrote: > On 2015-08-31 13:39, Daniel Gutson wrote: >> >> On Mon, Aug 31, 2015 at 2:34 PM, Gedare Bloom wrote: >>> >>> I'd approve 2 patches in case you want to give credit. First patch >>

Re: [PATCH v3] ARMv7M: Fix exception handler for supporting FPU

On 2015-08-31 13:39, Daniel Gutson wrote: On Mon, Aug 31, 2015 at 2:34 PM, Gedare Bloom wrote: I'd approve 2 patches in case you want to give credit. First patch with Sudarshan's fix, and Martin's improvement second. +1 Sounds fair enough! :) Thanks for the support, Daniel. Should I make a

Re: [PATCH v3] ARMv7M: Fix exception handler for supporting FPU

On Mon, Aug 31, 2015 at 2:34 PM, Gedare Bloom wrote: > I'd approve 2 patches in case you want to give credit. First patch > with Sudarshan's fix, and Martin's improvement second. +1 > > On Mon, Aug 31, 2015 at 1:28 PM, Daniel Gutson > wrote: >> Side question to Joel and others: is this enough t

Re: [PATCH v3] ARMv7M: Fix exception handler for supporting FPU

On Mon, Aug 31, 2015 at 2:34 PM, Gedare Bloom wrote: > I'd approve 2 patches in case you want to give credit. First patch > with Sudarshan's fix, and Martin's improvement second. Agreed. Sudarshan sent his patch a couple days ago; I'll generate a new one with the new instructions and the comments

Re: [PATCH v3] ARMv7M: Fix exception handler for supporting FPU

I'd approve 2 patches in case you want to give credit. First patch with Sudarshan's fix, and Martin's improvement second. On Mon, Aug 31, 2015 at 1:28 PM, Daniel Gutson wrote: > Side question to Joel and others: is this enough to credit Sudarshan? > He did an amazing job for finding the bug and p

Re: [PATCH v3] ARMv7M: Fix exception handler for supporting FPU

Side question to Joel and others: is this enough to credit Sudarshan? He did an amazing job for finding the bug and proposing an initial solution. On Mon, Aug 31, 2015 at 11:37 AM, Martin Galvan wrote: > On exception entry, _ARMV7M_Exception_default stores the previous Stack > Pointer > in a CPU

[PATCH v3] ARMv7M: Fix exception handler for supporting FPU

On exception entry, _ARMV7M_Exception_default stores the previous Stack Pointer in a CPU_Exception_frame. The SP can be MSP or PSP, depending on the mode in which the exception was taken. To know this, we must check the value of LR. Right now the code checks whether it should store MSP or PSP by c

Re: [PATCH v2] ARMv7M: Fix exception handler for supporting FPU

Please add "closes #2401." as a line in your commit message if you do'nt mind. On Mon, Aug 31, 2015 at 9:52 AM, Martin Galvan wrote: > By the way, I noticed there wasn't a ticket yet for this bug, so I > created one (#2401). You can view it here: > > https://devel.rtems.org/ticket/2401 >

Re: [PATCH 2/3] rbtree: Add _RBTree_Replace_node()

It's on the caller to ensure no ordering violation? On Mon, Aug 31, 2015 at 7:54 AM, Sebastian Huber wrote: > --- > cpukit/score/Makefile.am | 1 + > cpukit/score/include/rtems/score/rbtree.h | 13 +++ > cpukit/score/src/rbtreereplace.c | 61 >

Re: [PATCH] rbtree: Delete rtems_rbtree_find_control()

OK On Mon, Aug 31, 2015 at 4:44 AM, Sebastian Huber wrote: > I would like to back port this patch to the 4.11 branch. > > On 31/08/15 10:43, Sebastian Huber wrote: >> >> This function is hard to support in alternative implementations. It has >> no internal use case. > > > -- > Sebastian Huber, e

Re: [PATCH v2] ARMv7M: Fix exception handler for supporting FPU

By the way, I noticed there wasn't a ticket yet for this bug, so I created one (#2401). You can view it here: https://devel.rtems.org/ticket/2401 ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

[PATCH 2/3] rbtree: Add _RBTree_Replace_node()

--- cpukit/score/Makefile.am | 1 + cpukit/score/include/rtems/score/rbtree.h | 13 +++ cpukit/score/src/rbtreereplace.c | 61 +++ 3 files changed, 75 insertions(+) create mode 100644 cpukit/score/src/rbtreereplace.c diff --git a/cpukit/

[PATCH 1/3] rbtree: Replace implementation

Use the BSD implementation since it is faster, more flexible and uses less storage. See https://github.com/sebhub/rb-bench. --- cpukit/score/include/rtems/score/rbtree.h | 277 + cpukit/score/include/rtems/score/rbtreeimpl.h | 118 cpukit/score/src/rbtreeextract.c |

[PATCH 3/3] JFFS2: Use RTEMS red-black tree implementation

--- cpukit/libfs/Makefile.am | 1 - cpukit/libfs/src/jffs2/include/linux/rbtree.h | 128 ++-- cpukit/libfs/src/jffs2/src/compat-rbtree.c| 422 -- 3 files changed, 98 insertions(+), 453 deletions(-) delete mode 100644 cpukit/libfs/src/jffs2/sr

Re: building RTEMS 4.11 leon3 with floating point support?

Having a floating point configuration of the BSP makes sense. I was able to rebuild the BSP with the hardware floating point compiler option and it works. I did get a floating point exception in the FTP task and had to change the FTP task create to enable floating point. Is it worth submitting a p

Re: [PATCH] rbtree: Delete rtems_rbtree_find_control()

I would like to back port this patch to the 4.11 branch. On 31/08/15 10:43, Sebastian Huber wrote: This function is hard to support in alternative implementations. It has no internal use case. -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone

[PATCH] rbtree: Delete rtems_rbtree_find_control()

This function is hard to support in alternative implementations. It has no internal use case. --- cpukit/sapi/include/rtems/rbtree.h| 10 -- cpukit/score/include/rtems/score/rbtree.h | 25 - testsuites/sptests/sprbtree01/init.c | 7 --- 3 files ch