Re: [PATCH 09/45] score: New timer server implementation

2015-05-16 Thread Gedare Bloom
> -/* FIXME: This locking approach for SMP is improvable! */ > + ++watchdogs->generation; > We should probably try to file a ticket associated with any FIXME type comments, and refer to it in the FIXME too. ___ devel mailing list devel@rtems.org http://l

Re: [PATCH 37/45] psxualarm: Avoid endless signal handling

2015-05-16 Thread Gedare Bloom
On Fri, May 15, 2015 at 7:41 AM, Sebastian Huber wrote: > Increase the ualarm timer interval to avoid endless signal handling. > --- > testsuites/psxtests/psxualarm/init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/testsuites/psxtests/psxualarm/init.c > b/testsuites

Re: [PATCH 34/45] score: Do not inline SMP lock if profiling enabled

2015-05-16 Thread Gedare Bloom
Not really related, but what is the "rule" for when we should use RTEMS_INLINE_ROUTINE versus being able to say "static inline"? -Gedare On Fri, May 15, 2015 at 7:41 AM, Sebastian Huber wrote: > This reduces the code size drastically. > --- > cpukit/score/Makefile.am | 1 + >

Re: [PATCH 05/45] score: Add header to _Watchdog_Remove()

2015-05-16 Thread Sebastian Huber
- Am 15. Mai 2015 um 20:07 schrieb Gedare Bloom ged...@rtems.org: > On Fri, May 15, 2015 at 7:41 AM, Sebastian Huber > wrote: [...] >> diff --git a/cpukit/rtems/src/timercreate.c b/cpukit/rtems/src/timercreate.c >> index 0b1c44b..390c965 100644 >> --- a/cpukit/rtems/src/timercreate.c >> +++

Re: Major SMP Improvements

2015-05-16 Thread Sebastian Huber
- Am 16. Mai 2015 um 8:49 schrieb Chris Johns chr...@rtems.org: > On 16/05/2015 4:44 pm, Daniel Hellstrom wrote: >> >> I thought this was publicaly known and that Sebastian's ticket was the >> way to fix it. There was a discussion about it when it was discovered >> around Aug 2014, and I ag