Re: [PATCH v2] libmisc: More useful default configuration

2014-12-03 Thread Chris Johns
On 4/12/2014 6:31 pm, Sebastian Huber wrote: Ah of course. Why not move the bspinit.c one into the cpukit and use that rather than add another copy ? Should we really initialize the network by default? No and I feel that should do from bspinit.c. If you look at the README file in the du

Re: [PATCH v2] libmisc: More useful default configuration

2014-12-03 Thread Sebastian Huber
On 04/12/14 08:25, Chris Johns wrote: On 4/12/2014 5:30 pm, Sebastian Huber wrote: On 04/12/14 00:00, Joel Sherrill wrote: On December 3, 2014 4:53:23 PM EST, Chris Johns wrote: >On 3/12/2014 7:46 pm, Sebastian Huber wrote: >>The dummy.c is a de-facto default configuration so use unlimited

Re: [PATCH v2] libmisc: More useful default configuration

2014-12-03 Thread Chris Johns
On 4/12/2014 5:30 pm, Sebastian Huber wrote: On 04/12/14 00:00, Joel Sherrill wrote: On December 3, 2014 4:53:23 PM EST, Chris Johns wrote: >On 3/12/2014 7:46 pm, Sebastian Huber wrote: >>The dummy.c is a de-facto default configuration so use unlimited >objects >>and the stack checker. Th

SPARC GCC Version

2014-12-03 Thread Sebastian Huber
Hello, we use currently GCC 4.9.2 for the SPARC. Unfortunately two patches are missing in this version: 2014-11-07 Daniel Hellstrom Backport from mainline * config.gcc (sparc-*-rtems*): Clean away unused t-elf. * config/sparc/t-rtems: Add leon3v7 and muser-mode

Re: [PATCH v2] libmisc: More useful default configuration

2014-12-03 Thread Sebastian Huber
On 04/12/14 00:00, Joel Sherrill wrote: On December 3, 2014 4:53:23 PM EST, Chris Johns wrote: >On 3/12/2014 7:46 pm, Sebastian Huber wrote: >>The dummy.c is a de-facto default configuration so use unlimited >objects >>and the stack checker. This makes it easier for new RTEMS users >which

Re: [PATCH 3/3] doxygen: expand specified compiler macros to empty string, so they are ignored by doxygen

2014-12-03 Thread Gedare Bloom
These 3 OK by me. I'll try to commit tomorrow if no one complains. -Gedare On Wed, Dec 3, 2014 at 6:56 PM, Jan Dolezal wrote: > --- > cpukit/Doxyfile.in | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/cpukit/Doxyfile.in b/cpukit/Doxyfile.in > index 4a6ee55..e4b68

[PATCH 2/3] i386: doxygen and comments related to VESA real mode framebuffer

2014-12-03 Thread Jan Dolezal
--- c/src/lib/libbsp/i386/pc386/console/fb_vesa_rm.c | 105 ++-- c/src/lib/libbsp/i386/pc386/include/edid.h | 14 +- c/src/lib/libbsp/i386/pc386/include/fb_vesa.h | 77 +-- c/src/lib/libbsp/i386/pc386/include/tblsizes.h | 1 - c/src/lib/libbsp/i386/pc386/include/vbe3.h

[PATCH 3/3] doxygen: expand specified compiler macros to empty string, so they are ignored by doxygen

2014-12-03 Thread Jan Dolezal
--- cpukit/Doxyfile.in | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/cpukit/Doxyfile.in b/cpukit/Doxyfile.in index 4a6ee55..e4b681f 100644 --- a/cpukit/Doxyfile.in +++ b/cpukit/Doxyfile.in @@ -1267,13 +1267,13 @@ ENABLE_PREPROCESSING = YES # compilation will be perf

[PATCH 1/3] i386/pc386: cammelCase (struct and function names) to underscores, typedefed structs, break >80 chars lines, removed newlines at EOFs

2014-12-03 Thread Jan Dolezal
fb_vesa_rm.c: removed inline from functions declared in fb_vesa.h removed unnecessary printks in the end of patch edid.h, vbe3.h: switched from custom *PACKED_ATTRIBUTE at the structs to the RTEMS_COMPILER_PACKED_ATTRIBUTE for easier maintainability of

[PATCH v2 0/3] i386 VESA framebuffer support - follow up patches

2014-12-03 Thread Jan Dolezal
changes since original set of patches: - structures are typedefed [G. Bloom] - correct english [J. Sherill] - removed newlines at EOF [G. Bloom] - copyright blocks separated from doxygen blocks [J. Sherill] changes since v1 - struct and function names does not use camelCase [G.

Re: [PATCH v2] libmisc: More useful default configuration

2014-12-03 Thread Joel Sherrill
On December 3, 2014 4:53:23 PM EST, Chris Johns wrote: >On 3/12/2014 7:46 pm, Sebastian Huber wrote: >> The dummy.c is a de-facto default configuration so use unlimited >objects >> and the stack checker. This makes it easier for new RTEMS users >which >> will likely use this file if they just w

Re: [PATCH v2] libmisc: More useful default configuration

2014-12-03 Thread Chris Johns
On 3/12/2014 7:46 pm, Sebastian Huber wrote: The dummy.c is a de-facto default configuration so use unlimited objects and the stack checker. This makes it easier for new RTEMS users which will likely use this file if they just work with the usual main() function as the application entry point.

Re: [PATCH 2/2] i386: doxygen and comments related to VESA real mode framebuffer

2014-12-03 Thread Gedare Bloom
On Wed, Dec 3, 2014 at 11:29 AM, Jan Dolezal wrote: > Hello Gedare, > > thank you very much for your comments. I really appreciate them. > > On 3.12.2014 00:59, Gedare Bloom wrote: >> >> Sometimes params are identified as in our out, sometimes they are not. >> Please be consistent. Generally patch

Re: [PATCH] fix for default configuration for pc386 bsp

2014-12-03 Thread Gedare Bloom
OK to commit On Tue, Dec 2, 2014 at 5:40 PM, Ben Gras wrote: > All, > > If USE_VBE_RM is not on, vesa_realmode_bootup_init shouldn't be > referenced, but it's always defined, so the test shoudl be #if instead > of #ifdef. > > ___ > devel mailing list >

Re: [PATCH] fix for default configuration for pc386 bsp

2014-12-03 Thread Jan Dolezal
Hello Ben, that is my fault, thank you for your correction. Jan Dolezal On 2.12.2014 23:40, Ben Gras wrote: All, If USE_VBE_RM is not on, vesa_realmode_bootup_init shouldn't be referenced, but it's always defined, so the test shoudl be #if instead of #ifdef. ___

Re: [PATCH 2/2] i386: doxygen and comments related to VESA real mode framebuffer

2014-12-03 Thread Jan Dolezal
Hello Gedare, thank you very much for your comments. I really appreciate them. On 3.12.2014 00:59, Gedare Bloom wrote: Sometimes params are identified as in our out, sometimes they are not. Please be consistent. Generally patch looks OK, does the doxygen look right when applied? [1] can help Th

Re: [PATCH 4/4 v3] SPARC: optimize IRQ enable & disable

2014-12-03 Thread Joel Sherrill
On 12/3/2014 8:39 AM, Sebastian Huber wrote: > Looks good. +1 Five instructions on this path is important. > On 03/12/14 15:29, Daniel Hellstrom wrote: >> * Coding style cleanups. >> * Use OS reserved trap 0x89 for IRQ Disable >> * Use OS reserved trap 0x8A for IRQ Enable >> * Add to SPARC CPU sup

Re: [PATCH 4/4 v3] SPARC: optimize IRQ enable & disable

2014-12-03 Thread Sebastian Huber
Looks good. On 03/12/14 15:29, Daniel Hellstrom wrote: * Coding style cleanups. * Use OS reserved trap 0x89 for IRQ Disable * Use OS reserved trap 0x8A for IRQ Enable * Add to SPARC CPU supplement documentation This will result in faster Disable/Enable code since the system trap handler does no

[PATCH 4/4 v3] SPARC: optimize IRQ enable & disable

2014-12-03 Thread Daniel Hellstrom
* Coding style cleanups. * Use OS reserved trap 0x89 for IRQ Disable * Use OS reserved trap 0x8A for IRQ Enable * Add to SPARC CPU supplement documentation This will result in faster Disable/Enable code since the system trap handler does not need to decode which function the user wants. Besides th

[PATCH v2] libmisc: More useful default configuration

2014-12-03 Thread Sebastian Huber
The dummy.c is a de-facto default configuration so use unlimited objects and the stack checker. This makes it easier for new RTEMS users which will likely use this file if they just work with the usual main() function as the application entry point. Provide proper arguments for main() using the B