Re: PowerPC Cache Warning Help Request

On Mon, Oct 20, 2014 at 5:11 PM, Peter Dufault wrote: > >> On Oct 20, 2014, at 16:47 , Joel Sherrill wrote: >> >>> However, should unimplemented versions return an error instead of being >>> a NOP? That would force one to visit code that makes assumptions. >> >> If this is OK for the mpc55xx, fe

Re: __assert.c Wpointer-to-int-cast

On Tue, Oct 14, 2014 at 2:21 AM, Sebastian Huber wrote: > On 14/10/14 04:21, Gedare Bloom wrote: >> >> cpukit/libcsupport/src/__assert.c52:43: >> warning: cast from pointer to integer of different size >> [-Wpointer-to-int-cast] >> rtems_fatal( RTEMS_FATAL_SOURCE_ASSERT, (rtems_fatal_code) >>

Re: x86 interpreter and NOVA hypervisor - Was: [PATCH] do_it

On Mon, Oct 20, 2014 at 10:55 AM, Pavel Pisa wrote: > Hello Gedare and others, > > On Sunday 19 of October 2014 15:01:08 Gedare Bloom wrote: >> On Sun, Oct 19, 2014 at 7:48 AM, Pavel Pisa > ... >> >set interpreter in RTEMS which would allow to run BIOS x86 >> >real code sandboxed and with

Re: PowerPC Cache Warning Help Request

> On Oct 20, 2014, at 16:47 , Joel Sherrill wrote: > >> However, should unimplemented versions return an error instead of being >> a NOP? That would force one to visit code that makes assumptions. > > If this is OK for the mpc55xx, feel free to submit a patch turning the > warning off for it.

Re: Warning Report 20 Oct 2014

Should have provided reports as attachments. To repeat, help finishing this off is really appreciated. On 10/20/2014 3:42 PM, Joel Sherrill wrote: > Hi > > I just submitted my latest round of patches. With those applied, > things are in pretty good shape but help is needed to wrap up > the remain

Re: PowerPC Cache Warning Help Request

On October 20, 2014 3:41:06 PM CDT, Peter Dufault wrote: > >> On Oct 20, 2014, at 13:20 , Joel Sherrill >wrote: >> >> >> On 10/20/2014 12:09 PM, Gedare Bloom wrote: >>> Cache manager implementations are a perennial open project. >> +1 >> >> In this case,we only have ten RTEMS_CPU_MODELs whic

Warning Report 20 Oct 2014

Hi I just submitted my latest round of patches. With those applied, things are in pretty good shape but help is needed to wrap up the remaining issues. The biggest things to note are that: + the only warnings left in libcpu code is the PowerPC cache issue. + Only the following BSPs have warnings

Re: PowerPC Cache Warning Help Request

> On Oct 20, 2014, at 13:20 , Joel Sherrill wrote: > > > On 10/20/2014 12:09 PM, Gedare Bloom wrote: >> Cache manager implementations are a perennial open project. > +1 > > In this case,we only have ten RTEMS_CPU_MODELs which are not > addressed. There are currently two blocks of code in the

[PATCH 24/34] libbsp/sh/shared/console.c: Eliminate use of obsolete method

--- c/src/lib/libbsp/sh/shared/console.c | 67 +++- 1 file changed, 21 insertions(+), 46 deletions(-) diff --git a/c/src/lib/libbsp/sh/shared/console.c b/c/src/lib/libbsp/sh/shared/console.c index 8217e26..3c39217 100644 --- a/c/src/lib/libbsp/sh/shared/console.c

[PATCH 34/34] or1k/or1ksim: Fix warnings

--- c/src/lib/libbsp/or1k/or1ksim/console/uart.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/c/src/lib/libbsp/or1k/or1ksim/console/uart.c b/c/src/lib/libbsp/or1k/or1ksim/console/uart.c index 31cdce6..bb86bae 100644 --- a/c/src/lib/libbsp/or1k/or1ksim/c

[PATCH 28/34] nios2/nios2_iss: Fix warnings

--- c/src/lib/libbsp/nios2/nios2_iss/console/console.c | 54 ++ .../lib/libbsp/nios2/nios2_iss/startup/bspstart.c | 5 +- c/src/lib/libbsp/nios2/nios2_iss/timer/timer.c | 20 3 files changed, 28 insertions(+), 51 deletions(-) diff --git a/c/src/lib/libbsp/nios2/

[PATCH 30/34] powerpc/qemuppc/startup/cmain.c: Fix warnings

--- c/src/lib/libbsp/powerpc/qemuppc/startup/cmain.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/c/src/lib/libbsp/powerpc/qemuppc/startup/cmain.c b/c/src/lib/libbsp/powerpc/qemuppc/startup/cmain.c index 21a02e0..fd59ed8 100644 --- a/c/src/lib/libbsp/powerpc/qemuppc/startup/cmain.c

[PATCH 23/34] cpukit/libfs/src/imfs/ioman.c: Fix typo

--- cpukit/libfs/src/imfs/ioman.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/libfs/src/imfs/ioman.c b/cpukit/libfs/src/imfs/ioman.c index 112a788..140d9e2 100644 --- a/cpukit/libfs/src/imfs/ioman.c +++ b/cpukit/libfs/src/imfs/ioman.c @@ -1,7 +1,7 @@ /** * @file

[PATCH 25/34] libcpu/sh/sh7045/sci/sci.c: Eliminate use of obsolete method

--- c/src/lib/libcpu/sh/sh7045/sci/sci.c | 32 +--- 1 file changed, 9 insertions(+), 23 deletions(-) diff --git a/c/src/lib/libcpu/sh/sh7045/sci/sci.c b/c/src/lib/libcpu/sh/sh7045/sci/sci.c index e6c54e2..690035a 100644 --- a/c/src/lib/libcpu/sh/sh7045/sci/sci.c +++ b

[PATCH 29/34] powerpc/shared/startup/bspstart.c: Fix warning for mvme2100

--- c/src/lib/libbsp/powerpc/shared/startup/bspstart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/c/src/lib/libbsp/powerpc/shared/startup/bspstart.c b/c/src/lib/libbsp/powerpc/shared/startup/bspstart.c index 1d5d5d5..08dc12b 100644 --- a/c/src/lib/libbsp/powerpc/shared/st

[PATCH 33/34] arm/raspberrypi: Fix warnings

--- c/src/lib/libbsp/arm/raspberrypi/console/usart.c | 126 +++ c/src/lib/libbsp/arm/raspberrypi/include/bsp.h | 2 + 2 files changed, 64 insertions(+), 64 deletions(-) diff --git a/c/src/lib/libbsp/arm/raspberrypi/console/usart.c b/c/src/lib/libbsp/arm/raspberrypi/consol

[PATCH 31/34] powerpc/qoriq/include/bsp.h: Add prototypes to fix warnings

--- c/src/lib/libbsp/powerpc/qoriq/include/bsp.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/c/src/lib/libbsp/powerpc/qoriq/include/bsp.h b/c/src/lib/libbsp/powerpc/qoriq/include/bsp.h index a4be2e2..0876060 100644 --- a/c/src/lib/libbsp/powerpc/qoriq/include/bsp.h +++ b/c/src

[PATCH 32/34] shared/clockdrv_shell.h: Always include to avoid warnings

--- c/src/lib/libbsp/shared/clockdrv_shell.h | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/c/src/lib/libbsp/shared/clockdrv_shell.h b/c/src/lib/libbsp/shared/clockdrv_shell.h index 324e1e5..5dbea13 100644 --- a/c/src/lib/libbsp/shared/clockdrv_shell.h +++ b

[PATCH 27/34] ss555/startup/bspstart.c: BSP does not use SPRG0

--- c/src/lib/libbsp/powerpc/ss555/startup/bspstart.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/c/src/lib/libbsp/powerpc/ss555/startup/bspstart.c b/c/src/lib/libbsp/powerpc/ss555/startup/bspstart.c index f27df69..4016c61 100644 --- a/c/src/lib/libbsp/powerpc/ss555/startup/bspstart.c ++

[PATCH 14/34] arm/csb337/console/fbcons.c: Fix warning

--- c/src/lib/libbsp/arm/csb337/console/fbcons.c | 22 -- 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/c/src/lib/libbsp/arm/csb337/console/fbcons.c b/c/src/lib/libbsp/arm/csb337/console/fbcons.c index 87067ca..62e8409 100644 --- a/c/src/lib/libbsp/arm/csb337/

[PATCH 11/34] arm/gba/console/conio.c: Fix warning

--- c/src/lib/libbsp/arm/gba/console/conio.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/c/src/lib/libbsp/arm/gba/console/conio.c b/c/src/lib/libbsp/arm/gba/console/conio.c index 1027b2a..c53793a 100644 --- a/c/src/lib/libbsp/arm/gba/console/conio.c +++ b/c/src/lib/li

[PATCH 17/34] m68k/idp: Fix warnings

--- c/src/lib/libbsp/m68k/idp/console/mc68ec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/c/src/lib/libbsp/m68k/idp/console/mc68ec.c b/c/src/lib/libbsp/m68k/idp/console/mc68ec.c index 3063af8..9041ca5 100644 --- a/c/src/lib/libbsp/m68k/idp/console/mc68ec.c +++ b/c/src/lib/libbsp/m68k/idp

[PATCH 18/34] m68k/mcf52235: Fix warnings

--- c/src/lib/libbsp/m68k/mcf52235/include/bsp.h | 5 + c/src/lib/libbsp/m68k/mcf52235/startup/init52235.c | 1 + 2 files changed, 6 insertions(+) diff --git a/c/src/lib/libbsp/m68k/mcf52235/include/bsp.h b/c/src/lib/libbsp/m68k/mcf52235/include/bsp.h index 1e6cb95..fd3f851 100644 ---

[PATCH 26/34] ep1a/startup/bspstart.c: BSP does not use SPRG0

--- c/src/lib/libbsp/powerpc/ep1a/startup/bspstart.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/c/src/lib/libbsp/powerpc/ep1a/startup/bspstart.c b/c/src/lib/libbsp/powerpc/ep1a/startup/bspstart.c index 47b6312..dc675e2 100644 --- a/c/src/lib/libbsp/powerpc/ep1a/startup/bspstart.c +++ b/

[PATCH 20/34] m68k/mcf5235: Fix warnings

--- c/src/lib/libbsp/m68k/mcf5235/include/bsp.h | 5 + 1 file changed, 5 insertions(+) diff --git a/c/src/lib/libbsp/m68k/mcf5235/include/bsp.h b/c/src/lib/libbsp/m68k/mcf5235/include/bsp.h index 66d0c70..96355e2 100644 --- a/c/src/lib/libbsp/m68k/mcf5235/include/bsp.h +++ b/c/src/lib/libbsp

[PATCH 08/34] score/cpu/lm32/rtems/score/cpu.h: Fix set but not used warning

--- cpukit/score/cpu/lm32/rtems/score/cpu.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/cpukit/score/cpu/lm32/rtems/score/cpu.h b/cpukit/score/cpu/lm32/rtems/score/cpu.h index 17fa33c..67d7ebe 100644 --- a/cpukit/score/cpu/lm32/rtems/score/cpu.h +++ b/cpukit/score/cpu/lm32/rtems/score/

[PATCH 13/34] libcpu/arm/pxa255/ffuart/ffuart.c: Fix warning

--- c/src/lib/libcpu/arm/pxa255/ffuart/ffuart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/c/src/lib/libcpu/arm/pxa255/ffuart/ffuart.c b/c/src/lib/libcpu/arm/pxa255/ffuart/ffuart.c index 1604f1d..335fc6f 100644 --- a/c/src/lib/libcpu/arm/pxa255/ffuart/ffuart.c +++ b/c/src

[PATCH 22/34] m68k/mrm332: Fix warnings

--- c/src/lib/libbsp/m68k/mrm332/spurious/spinit.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/c/src/lib/libbsp/m68k/mrm332/spurious/spinit.c b/c/src/lib/libbsp/m68k/mrm332/spurious/spinit.c index ac435cb..8f71b5e 100644 --- a/c/src/lib/libbsp/m68k/mrm332/spu

[PATCH 21/34] m68k/mcf5329: Fix warnings

--- c/src/lib/libbsp/m68k/mcf5329/include/bsp.h | 5 + c/src/lib/libbsp/m68k/mcf5329/startup/init5329.c | 1 + 2 files changed, 6 insertions(+) diff --git a/c/src/lib/libbsp/m68k/mcf5329/include/bsp.h b/c/src/lib/libbsp/m68k/mcf5329/include/bsp.h index 719c5f9..4ba7f0f 100644 --- a/c/sr

[PATCH 03/34] jffs2: Add casts and constant designators to address warnings on 16-bit targets

--- cpukit/libfs/src/jffs2/include/linux/kernel.h | 2 +- cpukit/libfs/src/jffs2/src/nodelist.h | 2 +- cpukit/libfs/src/jffs2/src/os-rtems.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cpukit/libfs/src/jffs2/include/linux/kernel.h b/cpukit/libfs/src/jff

[PATCH 02/34] m68k/mrm332: Move include of

This file defines at least the POW() macro which pollutes the public name space and causes warnings in at least the paranoia sample application. --- c/src/lib/libbsp/m68k/mrm332/clock/ckinit.c | 1 + c/src/lib/libbsp/m68k/mrm332/include/bsp.h | 1 - 2 files changed, 1 insertion(+), 1 deletion(-)

[PATCH 05/34] m68k/av5282: Fix warning

--- c/src/lib/libbsp/m68k/av5282/include/bsp.h | 24 +--- c/src/lib/libbsp/m68k/av5282/start/start.S | 7 ++- c/src/lib/libbsp/m68k/av5282/startup/init5282.c | 76 - 3 files changed, 58 insertions(+), 49 deletions(-) diff --git a/c/src/lib/libbsp/m68k/av5282

[PATCH 16/34] m68k/gen68360: Fix warnings

--- c/src/lib/libbsp/m68k/gen68360/include/bsp.h | 5 + c/src/lib/libbsp/m68k/gen68360/startup/init68360.c | 11 --- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/c/src/lib/libbsp/m68k/gen68360/include/bsp.h b/c/src/lib/libbsp/m68k/gen68360/include/bsp.h index

[PATCH 15/34] lm32 BSP shared and lm32_evr: Fix BSPs

--- c/src/lib/libbsp/lm32/lm32_evr/include/bsp.h | 7 +++ c/src/lib/libbsp/lm32/shared/console/console.c | 6 -- c/src/lib/libbsp/lm32/shared/console/uart.c| 9 ++--- 3 files changed, 13 insertions(+), 9 deletions(-) diff --git a/c/src/lib/libbsp/lm32/lm32_evr/include/bsp.h b/c

[PATCH 10/34] arm/edb7312: Fix warnings

--- c/src/lib/libbsp/arm/edb7312/include/bsp.h | 9 + c/src/lib/libbsp/arm/edb7312/irq/bsp_irq_asm.S | 6 +- c/src/lib/libbsp/arm/edb7312/irq/irq.c | 4 +++- 3 files changed, 17 insertions(+), 2 deletions(-) diff --git a/c/src/lib/libbsp/arm/edb7312/include/bsp.h b/c/src/

[PATCH 19/34] m68k/mcf5225x: Fix warnings

--- c/src/lib/libbsp/m68k/mcf5225x/include/bsp.h | 5 + c/src/lib/libbsp/m68k/mcf5225x/startup/init5225x.c | 1 + 2 files changed, 6 insertions(+) diff --git a/c/src/lib/libbsp/m68k/mcf5225x/include/bsp.h b/c/src/lib/libbsp/m68k/mcf5225x/include/bsp.h index 5ee6fe3..e5701ed 100644 ---

[PATCH 09/34] cpukit/score/cpu/lm32/irq.c: Fix warning

--- cpukit/score/cpu/lm32/irq.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/cpukit/score/cpu/lm32/irq.c b/cpukit/score/cpu/lm32/irq.c index 5ea3b04..1c50b11 100644 --- a/cpukit/score/cpu/lm32/irq.c +++ b/cpukit/score/cpu/lm32/irq.c @@ -29,6 +29,12 @@ void *_exception_stack_frame;

[PATCH 06/34] m68k/csb360: Fix warnings

--- c/src/lib/libbsp/m68k/csb360/include/bsp.h | 5 + c/src/lib/libbsp/m68k/csb360/start/start.S | 4 +- c/src/lib/libbsp/m68k/csb360/startup/init5272.c | 130 +++- 3 files changed, 69 insertions(+), 70 deletions(-) diff --git a/c/src/lib/libbsp/m68k/csb360/inclu

[PATCH 12/34] libcpu/arm/at91rm9200/dbgu/dbgu.c: Fix warning

--- c/src/lib/libcpu/arm/at91rm9200/dbgu/dbgu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/c/src/lib/libcpu/arm/at91rm9200/dbgu/dbgu.c b/c/src/lib/libcpu/arm/at91rm9200/dbgu/dbgu.c index e8d3b33..fa14a8e 100644 --- a/c/src/lib/libcpu/arm/at91rm9200/dbgu/dbgu.c +++ b/c

[PATCH 07/34] score/cpu/i386/rtems/score/cpu.h: Fix set but not used warning

--- cpukit/score/cpu/i386/rtems/score/cpu.h | 1 + 1 file changed, 1 insertion(+) diff --git a/cpukit/score/cpu/i386/rtems/score/cpu.h b/cpukit/score/cpu/i386/rtems/score/cpu.h index e0ab037..13d31a4 100644 --- a/cpukit/score/cpu/i386/rtems/score/cpu.h +++ b/cpukit/score/cpu/i386/rtems/score/cpu

[PATCH 01/34] libcpu/powerpc configure logic: Do not built e500 components unused by qoriq

--- c/src/lib/libcpu/powerpc/Makefile.am | 10 +++--- c/src/lib/libcpu/powerpc/configure.ac | 8 +++- c/src/lib/libcpu/powerpc/preinstall.am | 5 +++-- 3 files changed, 17 insertions(+), 6 deletions(-) diff --git a/c/src/lib/libcpu/powerpc/Makefile.am b/c/src/lib/libcpu/powerpc/Make

[PATCH 04/34] lm32/milkymist/startup/bspclean.c: Include to fix warning

--- c/src/lib/libbsp/lm32/milkymist/startup/bspclean.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/c/src/lib/libbsp/lm32/milkymist/startup/bspclean.c b/c/src/lib/libbsp/lm32/milkymist/startup/bspclean.c index 4041b77..d4ff09b 100644 --- a/c/src/lib/libbsp/lm32/mil

Re: PowerPC Cache Warning Help Request

On 10/20/2014 12:29 PM, Gedare Bloom wrote: > If you do the legwork now, they could make reasonable GCI tasks if we > decide to participate and are accepted. And in this case, by the time I did the legwork, I could fix them. The legwork is 97.5% of this. :) Find the manual for the CPU, look up HI

Re: PowerPC Cache Warning Help Request

If you do the legwork now, they could make reasonable GCI tasks if we decide to participate and are accepted. -Gedare On Mon, Oct 20, 2014 at 1:20 PM, Joel Sherrill wrote: > > On 10/20/2014 12:09 PM, Gedare Bloom wrote: >> Cache manager implementations are a perennial open project. > +1 > > In th

Re: PowerPC Cache Warning Help Request

On 10/20/2014 12:09 PM, Gedare Bloom wrote: > Cache manager implementations are a perennial open project. +1 In this case,we only have ten RTEMS_CPU_MODELs which are not addressed. There are currently two blocks of code in the file. One is protected by this: #if defined(ppc603) || defined(ppc60

Re: [PATCH 1/2] dosfs: Support ctime and mtime

What does it mean "as far as possible"? On Mon, Oct 20, 2014 at 10:24 AM, Sebastian Huber wrote: > Implement ctime and mtime updates according to POSIX as far as possible. > The ctime is mapped to the FAT create time and date. The mtime is > mapped to the FAT last modified time and date. For th

Re: PowerPC Cache Warning Help Request

Cache manager implementations are a perennial open project. On Mon, Oct 20, 2014 at 11:19 AM, Joel Sherrill wrote: > > On 10/20/2014 10:08 AM, Sebastian Huber wrote: >> On 20/10/14 16:58, Joel Sherrill wrote: >>> >>> On October 20, 2014 9:41:57 AM CDT, Sebastian Huber >>> wrote: Since nobo

Re: PowerPC Cache Warning Help Request

On 10/20/2014 10:08 AM, Sebastian Huber wrote: > On 20/10/14 16:58, Joel Sherrill wrote: >> >> On October 20, 2014 9:41:57 AM CDT, Sebastian Huber >> wrote: >>> Since nobody missed the unimplemented cache manager functions in >>> several years >>> it should be safe so simply remove this #warning

Re: PowerPC Cache Warning Help Request

On 20/10/14 16:58, Joel Sherrill wrote: On October 20, 2014 9:41:57 AM CDT, Sebastian Huber wrote: Since nobody missed the unimplemented cache manager functions in several years it should be safe so simply remove this #warning. You didn't notice it for qoriq or e500 so years is an exaggera

Re: PowerPC Cache Warning Help Request

On October 20, 2014 9:41:57 AM CDT, Sebastian Huber wrote: >Since nobody missed the unimplemented cache manager functions in >several years >it should be safe so simply remove this #warning. You didn't notice it for qoriq or e500 so years is an exaggeration for some models. Take a look at t

Re: x86 interpreter and NOVA hypervisor - Was: [PATCH] do_it

Hello Gedare and others, On Sunday 19 of October 2014 15:01:08 Gedare Bloom wrote: > On Sun, Oct 19, 2014 at 7:48 AM, Pavel Pisa ... > >set interpreter in RTEMS which would allow to run BIOS x86 > >real code sandboxed and with additional memory ranges protection > >and with minimal i

Re: STM32F4 register definitions and PLL settings patch

Hello Chris, I have currently no time to review this or follow your discussion. Please ping me if you have something final to commit. -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47 41-09 E-Mail

Re: PowerPC Cache Warning Help Request

Since nobody missed the unimplemented cache manager functions in several years it should be safe so simply remove this #warning. -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47 41-09 E-Mail : seba

PowerPC Cache Warning Help Request

Hi This is a plea to get folks with PowerPC experience to look at a single file and see if they can improve the conditionals. The change will be easy. It is just a matter of knowing the answer or having a manual handy. The way my script counts unique warnings, it looks like 29 of the 168 unique w

[PATCH 2/2] Revert "fstests/mdosfs_fstime: Remove test"

This reverts commit bdcf4102f71d1bc2a50f23d2d425d85c24ec0900. --- testsuites/fstests/Makefile.am | 1 + testsuites/fstests/configure.ac | 1 + testsuites/fstests/mdosfs_fstime/Makefile.am | 33 3 files changed, 35 insertions(+) create mode

[PATCH 1/2] dosfs: Support ctime and mtime

Implement ctime and mtime updates according to POSIX as far as possible. The ctime is mapped to the FAT create time and date. The mtime is mapped to the FAT last modified time and date. For the atime use the mtime. --- cpukit/libfs/src/dosfs/fat_file.c| 34 + cpukit/libfs/sr