Re: [rtems commit] bsps: Basic console driver for Termios devices

2014-07-09 Thread Joel Sherrill
This is duplicative of the following files in libbsp/shared: console_control.c console_read.c console_write.c Please just add individual files for the other methods and list them. And yes, there are BSPs that only use some of these and provide their own versions of others. On 7/9/2014 5:52 AM,

[PATCH 6/6] Use Shared Method for Thread Unblock Cleanup

2014-07-09 Thread Joel Sherrill
When a thread is removed from a thread queue or is unblocked by receiving an event, the same actions are required. + timeout watchdog canceled, + thread must be unblocked, and + (MP only) proxy cleaned up This patch makes sure there is only one copy of this code. --- cpukit/score/include/rtem

Re: Misc on RBTree Thread Queue Priority Discipline Changes

2014-07-09 Thread Joel Sherrill
On 7/9/2014 10:34 AM, Gedare Bloom wrote: > On Tue, Jul 8, 2014 at 5:37 PM, Joel Sherrill > wrote: >> Hi >> >> If you take the patches in their entirety, most of the tests >> appear to be about 500 bytes smaller on the erc32. >> > What is the change in wkspace size? Basically you add 3 pointers

Re: Misc on RBTree Thread Queue Priority Discipline Changes

2014-07-09 Thread Gedare Bloom
On Tue, Jul 8, 2014 at 5:37 PM, Joel Sherrill wrote: > Hi > > If you take the patches in their entirety, most of the tests > appear to be about 500 bytes smaller on the erc32. > What is the change in wkspace size? Basically you add 3 pointers + enum to each TCB / thd proxy, but remove some space f

Re: Adding capture support to score

2014-07-09 Thread Gedare Bloom
Hi, On Tue, Jul 8, 2014 at 3:19 PM, Jennifer Averett wrote: > The attached patches are a starting point for discussions for adding capture > support > to core objects. We started to write notes based on our discussions but the > text > was harder to follow than just writing some code and comm

Re: [PATCH 4/6] spintrcritical20: Fix incorrect assumption

2014-07-09 Thread Joel Sherrill
I think this patch is wrong. Subsequent changes to the thread queue after I posted this resulted in the test breaking again. What is the test trying to do? I think sometimes through the loop, the condition the test expects is not occurring and it fails. On Jul 9, 2014 9:32 AM, Sebastian Huber

Re: [PATCH-V2 7/7] bsp/sparc: Flush only instruction cache

2014-07-09 Thread Gedare Bloom
On Wed, Jul 9, 2014 at 3:02 AM, Daniel Cederman wrote: > The flush instruction on LEON flushes both the data and the instruction > cache. Flushing of just the instruction cache can be done by setting > the "flush instruction cache" bit in the cache control register. > --- > c/src/lib/libbsp/sparc

Re: [PATCH-V2 5/7] score/sparc: Add comment on icache flush after trap table update

2014-07-09 Thread Gedare Bloom
On Wed, Jul 9, 2014 at 3:02 AM, Daniel Cederman wrote: > Changes to the trap table might be missed by other cores. > If the system state is up, the other cores can be notified > using SMP messages that they need to flush their icache. > If the up state has not been reached there is no need to > no

Re: [PATCH 4/6] spintrcritical20: Fix incorrect assumption

2014-07-09 Thread Sebastian Huber
On 2014-07-08 22:52, Joel Sherrill wrote: The test assumed that the thread would have enough time to block and become enqueued. In fact, the thread would still be in the ready state and not blocked on the semaphore. Thus the state of the Wait sub-structure in the TCB would not be in the expected

Re: [PATCH-V2 3/7] score: Add SMP support to the cache manager

2014-07-09 Thread Sebastian Huber
The new cache manager functions should have tests, see also http://git.rtems.org/rtems/tree/testsuites/sptests/spcache01/init.c On 2014-07-09 09:02, Daniel Cederman wrote: Adds functions that allows the user to specify which cores that should perform the cache operation. SMP messages are sent t

Re: [PATCH-V2 6/7] bsp/sparc: Ensure that data cache snooping is enabled

2014-07-09 Thread Sebastian Huber
On 2014-07-09 09:02, Daniel Cederman wrote: Check that data cache snooping exists and is enabled on all cores. --- c/src/lib/libbsp/shared/include/fatal.h |2 ++ c/src/lib/libbsp/sparc/leon3/include/leon.h | 10 ++ c/src/lib/libbsp/sparc/leon3/startup/bspsmp.c |8 +++

[PATCH-V2 4/7] bsp/sparc: Flush icache before first time enabling interrupts

2014-07-09 Thread Daniel Cederman
A secondary processor might miss changes done to the trap table if the instruction cache is not flushed. Once interrupts are enabled any other required cache flushes can be ordered via the cache manager. --- c/src/lib/libbsp/sparc/leon3/startup/bspsmp.c |9 + cpukit/score/cpu/sparc/rte

[PATCH-V2 3/7] score: Add SMP support to the cache manager

2014-07-09 Thread Daniel Cederman
Adds functions that allows the user to specify which cores that should perform the cache operation. SMP messages are sent to all the specified cores and the caller waits until all cores have acknowledged that they have flushed their cache. If CPU_CACHE_NO_INSTRUCTION_CACHE_SNOOPING is defined the i

[PATCH-V2 0/7] Changes to SMP Cache manager patches

2014-07-09 Thread Daniel Cederman
Renamed _SMP_Broadcast_message and _SMP_Send_message_cpu_set to _SMP_Send_message_broadcast and _SMP_Send_message_multicast and changed the broadcast type to unsigned long. Broadcast no longer uses multicast. Now supports arbitrarily sized cpu sets. Dropped use of function ids in smp cache manage

[PATCH-V2 6/7] bsp/sparc: Ensure that data cache snooping is enabled

2014-07-09 Thread Daniel Cederman
Check that data cache snooping exists and is enabled on all cores. --- c/src/lib/libbsp/shared/include/fatal.h |2 ++ c/src/lib/libbsp/sparc/leon3/include/leon.h | 10 ++ c/src/lib/libbsp/sparc/leon3/startup/bspsmp.c |8 ++-- 3 files changed, 18 insertions(+), 2 delet

[PATCH-V2 1/7] score: Add function to send a SMP message to a set of CPUs

2014-07-09 Thread Daniel Cederman
--- cpukit/score/include/rtems/score/smpimpl.h | 15 +++ cpukit/score/src/smp.c | 16 2 files changed, 31 insertions(+) diff --git a/cpukit/score/include/rtems/score/smpimpl.h b/cpukit/score/include/rtems/score/smpimpl.h index e2fee39..d49f88f

[PATCH-V2 7/7] bsp/sparc: Flush only instruction cache

2014-07-09 Thread Daniel Cederman
The flush instruction on LEON flushes both the data and the instruction cache. Flushing of just the instruction cache can be done by setting the "flush instruction cache" bit in the cache control register. --- c/src/lib/libbsp/sparc/leon3/include/cache_.h |5 - c/src/lib/libbsp/sparc/leon3

[PATCH-V2 5/7] score/sparc: Add comment on icache flush after trap table update

2014-07-09 Thread Daniel Cederman
Changes to the trap table might be missed by other cores. If the system state is up, the other cores can be notified using SMP messages that they need to flush their icache. If the up state has not been reached there is no need to notify other cores. They will do an automatic flush of the icache ju

[PATCH-V2 2/7] score: Rename SMP broadcast message function

2014-07-09 Thread Daniel Cederman
Change message type to unsigned long to match other SMP message functions. --- cpukit/score/include/rtems/score/smpimpl.h |4 ++-- cpukit/score/src/smp.c |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cpukit/score/include/rtems/score/smpimpl.h b/