Re: rtems_io_lookup_name deprecated?

2014-07-08 Thread Sebastian Huber
On 2014-07-08 15:49, Marcos Díaz wrote: Hi, we are developing a CAN driver for a bsp, and at first, we are devloping it in order to use it with the rtems io manager. But for this I need to use the function rtems_io_lookup_name which is deprecated(it works but it gives a warning message) I've been

Misc on RBTree Thread Queue Priority Discipline Changes

2014-07-08 Thread Joel Sherrill
Hi If you take the patches in their entirety, most of the tests appear to be about 500 bytes smaller on the erc32. None of the tmtests do priority based blocking so I can't report any changes there. There was historically a subroutine in the threadq calls for a discipline specific routine. Using

[PATCH 5/6] Thread Queue Priority Discipline Reimplemented with RBTree

2014-07-08 Thread Joel Sherrill
--- cpukit/configure.ac|6 - cpukit/score/include/rtems/score/thread.h |4 + cpukit/score/include/rtems/score/threadq.h | 23 +--- cpukit/score/include/rtems/score/threadqimpl.h | 61 +++--- cpukit/score/src/threadq.c | 28

[PATCH 3/6] sp59: Fix typos

2014-07-08 Thread Joel Sherrill
--- testsuites/sptests/sp59/init.c |4 ++-- testsuites/sptests/sp59/sp59.scn |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/testsuites/sptests/sp59/init.c b/testsuites/sptests/sp59/init.c index 2e68b9f..4120761 100644 --- a/testsuites/sptests/sp59/init.c +++ b/test

[PATCH 4/6] spintrcritical20: Fix incorrect assumption

2014-07-08 Thread Joel Sherrill
The test assumed that the thread would have enough time to block and become enqueued. In fact, the thread would still be in the ready state and not blocked on the semaphore. Thus the state of the Wait sub-structure in the TCB would not be in the expected state. The simple solution was to continue w

[PATCH 2/6] scheduleredfunblock.c: Correct spacing

2014-07-08 Thread Joel Sherrill
--- cpukit/score/src/scheduleredfunblock.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cpukit/score/src/scheduleredfunblock.c b/cpukit/score/src/scheduleredfunblock.c index 469655e..308a691 100644 --- a/cpukit/score/src/scheduleredfunblock.c +++ b/cpukit/score/src/sc

[PATCH 1/6] semdelete.c: Correct spacing

2014-07-08 Thread Joel Sherrill
--- cpukit/rtems/src/semdelete.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cpukit/rtems/src/semdelete.c b/cpukit/rtems/src/semdelete.c index 52bb14e..a805ac6 100644 --- a/cpukit/rtems/src/semdelete.c +++ b/cpukit/rtems/src/semdelete.c @@ -82,7 +82,7 @@ rtems_status_

[PATCH 6/6] Thread Queue: Merge discipline subroutines into main methods

2014-07-08 Thread Joel Sherrill
There was a lot of duplication between the discipline subroutines. With the transition to RBTrees for priority discipline, there were only a few lines of source code manipulating the data structure for FIFO and priority. Thus is made sense to fold these back into the main methods. As part of doing

Adding capture support to score

2014-07-08 Thread Jennifer Averett
The attached patches are a starting point for discussions for adding capture support to core objects. We started to write notes based on our discussions but the text was harder to follow than just writing some code and commenting on it. It is hard to see the impact of "word changes" versus rea

Re: [PATCH 1/2] score: Implement scheduler helping protocol

2014-07-08 Thread Joel Sherrill
On 7/8/2014 1:28 PM, Gedare Bloom wrote: > On Tue, Jul 8, 2014 at 2:20 PM, Sebastian Huber > wrote: > diff --git a/cpukit/score/include/rtems/score/threadimpl.h > b/cpukit/score/include/rtems/score/threadimpl.h > index 4971e9d..cb7d5fe 100644 > --- a/cpukit/score/include/rtems/sco

Re: [PATCH 1/2] score: Implement scheduler helping protocol

2014-07-08 Thread Joel Sherrill
On 7/8/2014 10:05 AM, Sebastian Huber wrote: I reviewed the code and didn't spot anything obvious. Does the Doxygen have any warnings or do we need to wait to see the automated build? I am sure once the SMP dust settles, we will have to work on coverage with SMP enabled. > diff --git a/doc/us

Re: [PATCH 1/2] score: Implement scheduler helping protocol

2014-07-08 Thread Gedare Bloom
On Tue, Jul 8, 2014 at 2:20 PM, Sebastian Huber wrote: >>> > >>> >diff --git a/cpukit/score/include/rtems/score/threadimpl.h >>> > b/cpukit/score/include/rtems/score/threadimpl.h >>> >index 4971e9d..cb7d5fe 100644 >>> >--- a/cpukit/score/include/rtems/score/threadimpl.h >>> >+++ b/cpukit/score/inc

Re: [PATCH 1/2] score: Implement scheduler helping protocol

2014-07-08 Thread Sebastian Huber
Hello Gedare, thanks for reviewing this huge patch. On 07/08/2014 05:22 PM, Gedare Bloom wrote: diff --git a/cpukit/score/include/rtems/score/thread.h b/cpukit/score/include/rtems/score/thread.h >index a9a3f9f..4d758fb 100644 >--- a/cpukit/score/include/rtems/score/thread.h >+++ b/cpukit/score

Re: Fwd: [PATCH] Add const qualifier in

2014-07-08 Thread Joel Sherrill
On 7/8/2014 9:59 AM, Sebastian Huber wrote: > On 2014-07-07 23:27, Joel Sherrill wrote: >> Hi Chris, >> >> I added this patch to rtems-tools. Attached is a patch to >> RSB to use it for the sparc tools. If this looks OK, should >> I make a similar update to all applicable 4.11 targets? > Why don't

[PATCH 2/2] smptests/smpmrsp01: Add and update test cases

2014-07-08 Thread Sebastian Huber
--- testsuites/smptests/smpmrsp01/init.c| 428 +--- testsuites/smptests/smpmrsp01/smpmrsp01.scn | 477 +++ 2 files changed, 720 insertions(+), 185 deletions(-) diff --git a/testsuites/smptests/smpmrsp01/init.c b/testsuites/smptests/smpmrsp01/

Re: Fwd: [PATCH] Add const qualifier in

2014-07-08 Thread Sebastian Huber
On 2014-07-07 23:27, Joel Sherrill wrote: Hi Chris, I added this patch to rtems-tools. Attached is a patch to RSB to use it for the sparc tools. If this looks OK, should I make a similar update to all applicable 4.11 targets? Why don't we move to another Newlib snapshot which includes this pat

rtems_io_lookup_name deprecated?

2014-07-08 Thread Marcos Díaz
Hi, we are developing a CAN driver for a bsp, and at first, we are devloping it in order to use it with the rtems io manager. But for this I need to use the function rtems_io_lookup_name which is deprecated(it works but it gives a warning message) I've been looking and it says to use stat() instead

Re: warning for __atomic_compare_exchange_4

2014-07-08 Thread Sebastian Huber
Hello Joel, see libatomic_i.h in the GCC sources: /* All sized operations are implemented in hidden functions prefixed with "libat_". These are either renamed or aliased to the expected prefix of "__atomic". Some amount of renaming is required to avoid hiding or conflicting with the b