Re: Reducing NSS's allocation rate

2014-11-12 Thread Nicholas Nethercote
On Tue, Nov 11, 2014 at 11:10 PM, Brian Smith wrote: >> >> I've attached to the bug a profile that uses a stack trace depth of 10. > > Unfortunately, 10 isn't enough to see the non-NSS entry (one that > doesn't start with "security/nss/") for every case. I've now attached to the bug a profile tha

Re: Reducing NSS's allocation rate

2014-11-11 Thread Brian Smith
On Mon, Nov 10, 2014 at 9:04 PM, Nicholas Nethercote wrote: >> In your analysis, it would be better to use a call stack trace depth >> larger than 5 that allows us to see what non-NSS function is calling >> into NSS. > > I've attached to the bug a profile that uses a stack trace depth of 10. Unfo

Re: Reducing NSS's allocation rate

2014-11-11 Thread Robert Relyea
On 11/11/2014 12:32 PM, Ryan Sleevi wrote: On Tue, November 11, 2014 10:26 am, Nicholas Nethercote wrote: On Mon, Nov 10, 2014 at 7:06 PM, Ryan Sleevi wrote: Not to be a pain and discourage someone from hacking on NSS My patches are in the following bugs: https://bugzilla.mozilla.org

Re: Reducing NSS's allocation rate

2014-11-11 Thread Ryan Sleevi
On Tue, November 11, 2014 10:26 am, Nicholas Nethercote wrote: > On Mon, Nov 10, 2014 at 7:06 PM, Ryan Sleevi > wrote: > > > > Not to be a pain and discourage someone from hacking on NSS > > My patches are in the following bugs: > > https://bugzilla.mozilla.org/show_bug.cgi?id=1094650 > https

Re: Reducing NSS's allocation rate

2014-11-11 Thread Nicholas Nethercote
On Mon, Nov 10, 2014 at 7:06 PM, Ryan Sleevi wrote: > > Not to be a pain and discourage someone from hacking on NSS My patches are in the following bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1094650 https://bugzilla.mozilla.org/show_bug.cgi?id=1095307 https://bugzilla.mozilla.org/show_bu

Re: Reducing NSS's allocation rate

2014-11-10 Thread Nicholas Nethercote
On Mon, Nov 10, 2014 at 8:53 PM, Brian Smith wrote: >> >> I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1095272 about >> this. I've written several patches that fix problems, one of which has >> r+ and is awaiting checkin; check the dependent bugs. > > In your analysis, it would be better t

Re: Reducing NSS's allocation rate

2014-11-10 Thread Brian Smith
On Mon, Nov 10, 2014 at 6:51 PM, Nicholas Nethercote wrote: > I've been doing some heap allocation profiling and found that during > basic usage NSS accounts for 1/3 of all of Firefox's cumulative (*not* > live) heap allocations. We're talking gigabytes of allocations in > short browsing sessions.

Re: Reducing NSS's allocation rate

2014-11-10 Thread Julien Pierre
Personally, I would like to encourage your efforts. If you are able to move many of these allocations from heap-based with locks, to something stack-based instead, this will improve NSS server performance tremendously. I would be surprised if it was a significant boost to client apps like Firef

Re: Reducing NSS's allocation rate

2014-11-10 Thread Ryan Sleevi
On Mon, November 10, 2014 6:51 pm, Nicholas Nethercote wrote: > Hi, > > I've been doing some heap allocation profiling and found that during > basic usage NSS accounts for 1/3 of all of Firefox's cumulative (*not* > live) heap allocations. We're talking gigabytes of allocations in > short brow

Reducing NSS's allocation rate

2014-11-10 Thread Nicholas Nethercote
Hi, I've been doing some heap allocation profiling and found that during basic usage NSS accounts for 1/3 of all of Firefox's cumulative (*not* live) heap allocations. We're talking gigabytes of allocations in short browsing sessions. That is *insane*. I filed https://bugzilla.mozilla.org/show_bu