On Tue, November 11, 2014 10:26 am, Nicholas Nethercote wrote: > On Mon, Nov 10, 2014 at 7:06 PM, Ryan Sleevi > <ryan-mozdevtechcry...@sleevi.com> wrote: > > > > Not to be a pain and discourage someone from hacking on NSS > > My patches are in the following bugs: > > https://bugzilla.mozilla.org/show_bug.cgi?id=1094650 > https://bugzilla.mozilla.org/show_bug.cgi?id=1095307 > https://bugzilla.mozilla.org/show_bug.cgi?id=1096741 > > I'm happy to hear specific criticisms. > > Nick > --
Not trying to be a pain, but I don't think that's fair to position like that. I'd rather the first question be answered - each one of your patches adds more branches and more complexity. That part is indisputable, even if it may be seen as small. However, what measures do we have to ensure that this is meaningfully improving any objective measure of performance (other than allocation churn, which allocators are exceptionally capable of handling)? How do we ensure this doesn't regress? Otherwise, we're adding complexity without any benefits. And I don't think there are - or at least, I haven't seen, other than "reduces allocations". -- dev-tech-crypto mailing list dev-tech-crypto@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-tech-crypto
