Re: [dev-servo] making features optional

2017-12-21 Thread google via dev-servo
On 21.12.2017 06:20, Fabrice Desre wrote: Hi, I feature-gated the bluetooth support in > https://github.com/fabricedesre/servo/commit/2afbaf365f6379eedf26e36a33e7cb38aba5c00a#diff-8c43e49d8f1af13938ed86125b97244c > > There are more changes that really needed because of rustfmt that ran > whe

Re: [dev-servo] making features optional

2017-12-21 Thread Fabrice Desre
On 12/21/2017 11:12 AM, google via dev-servo wrote: On 21.12.2017 06:20, Fabrice Desre wrote: Hi, I feature-gated the bluetooth support inĀ  > https://github.com/fabricedesre/servo/commit/2afbaf365f6379eedf26e36a33e7cb38aba5c00a#diff-8c43e49d8f1af13938ed86125b97244c > > There are more changes

[dev-servo] RFC: (semi-)automatic source formatting ?

2017-12-21 Thread Enrico Weigelt, metux IT consult via dev-servo
On 22.12.2017 05:57, Fabrice Desre wrote: I'd like that, but I'm quite sure that there are cases where we want hand tuned formatting so doing it properly will be time consuming. Perhaps do that in smaller steps, for individual subtrees ? @all: how do you folks think about that ? BTW: which i

Re: [dev-servo] RFC: (semi-)automatic source formatting ?

2017-12-21 Thread Fabrice Desre
On 12/21/2017 09:02 PM, Enrico Weigelt, metux IT consult via dev-servo wrote: On 22.12.2017 05:57, Fabrice Desre wrote: I'd like that, but I'm quite sure that there are cases where we want hand tuned formatting so doing it properly will be time consuming. Perhaps do that in smaller steps, for

Re: [dev-servo] making features optional

2017-12-21 Thread Enrico Weigelt, metux IT consult via dev-servo
On 22.12.2017 05:57, Fabrice Desre wrote: In components/servo/lib.rs, you didn't disable >> bluetooth_traits::BluetoothRequest. What about the references in the Navigator JSON object ?> > Indeed this is a quick hacked patch to unblock me on something else. > Absolutely not ready to be subm

Re: [dev-servo] making features optional

2017-12-21 Thread Fabrice Desre
On 12/21/2017 09:24 PM, Enrico Weigelt, metux IT consult via dev-servo wrote: Seems it's pretty unfinished yet. Maybe it effectively disables the feature (which a pref also would do), but IMHO most of the code is still in there. But my goals getting rid of everything I don't need/want. Again