Friendly ping to mailing list about
https://github.com/servo/servo/issues/16138, which I remembered because of
https://github.com/servo/servo/pull/17138#issuecomment-305733987
In the following screenshot, you can see one doesn't even know what that commit
is supposed to do from its title, becau
On 6/2/17 5:18 AM, Anthony Ramine wrote:
In the following screenshot, you can see one doesn't even know what that commit
is supposed to do from its title, because it is way too long to be informative.
OK, what is the proposed cap on first line of commit message?
Everything I've seen suggests
Note that in most cases "bug X" isn't deliberate, it's due to `git am`ing a
patch extracted from a gecko repo and forgetting to remove the Gecko stuff.
That said, it does get linkified on the gecko side if it's in the PR title.
I'm not very fond of the length limit imposed by GitCop.
-Manish Gore
> Le 2 juin 2017 à 17:00, Boris Zbarsky a écrit :
>
> On 6/2/17 5:18 AM, Anthony Ramine wrote:
>> In the following screenshot, you can see one doesn't even know what that
>> commit is supposed to do from its title, because it is way too long to be
>> informative.
>
> OK, what is the proposed
> I'm not very fond of the length limit imposed by GitCop.
The length is configurable.
On Fri, Jun 2, 2017 at 8:50 AM Anthony Ramine wrote:
>
>
> > Le 2 juin 2017 à 17:00, Boris Zbarsky a écrit :
> >
> > On 6/2/17 5:18 AM, Anthony Ramine wrote:
> >> In the following screenshot, you can see one
On 6/2/17 11:50 AM, Anthony Ramine wrote:
Though not required, it’s a good idea to begin the commit message with a single
short (less than 50 character)
Just so we're clear, 50 characters is about 9 words.
- Fix style sharing of elements affected by id selectors
No, that's not what it does
> Le 2 juin 2017 à 18:22, Boris Zbarsky a écrit :
>
> On 6/2/17 11:50 AM, Anthony Ramine wrote:
>>> Though not required, it’s a good idea to begin the commit message with a
>>> single short (less than 50 character)
>
> Just so we're clear, 50 characters is about 9 words.
I haven't said we sho
On 6/2/17 12:27 PM, Anthony Ramine wrote:
What was that step? The title you pasted doesn't say what it was about, it only
said what was wrong without it.
That was all. I just removed the if condition in question around the
insertion.
I've tried rewording as this:
Allow inserting element
$ echo -n "Allow style sharing elements with ID selectors" | wc -c
46
On Fri, Jun 2, 2017 at 9:31 AM Boris Zbarsky wrote:
> On 6/2/17 12:27 PM, Anthony Ramine wrote:
> > What was that step? The title you pasted doesn't say what it was about,
> it only said what was wrong without it.
>
> That was
On Fri, Jun 2, 2017 at 8:00 AM, Boris Zbarsky wrote:
> On 6/2/17 5:18 AM, Anthony Ramine wrote:
>
>> In the following screenshot, you can see one doesn't even know what that
>> commit is supposed to do from its title, because it is way too long to be
>> informative.
>>
>
> OK, what is the propose
On 6/2/17 12:34 PM, Michael Howell wrote:
$ echo -n "Allow style sharing elements with ID selectors" | wc -c
Misleading, unfortunately, because that changeset on its own doesn't
allow anything of the sort.
-Boris
___
dev-servo mailing list
dev-serv
11 matches
Mail list logo
