Re: [dev-servo] Regarding missing DOM features project: Named getter implementation

1. Using the struct/enum combo that I suggested in the previous email, you would only need a vector of SourcedName, since the element is included in the struct. You are correct that this corresponds with the description of the specification for `sourced names`. 2. That code snippet looks like

Re: [dev-servo] Regarding missing DOM features project: Named getter implementation

Hi Josh, Sorry to bother you on a Sunday. We have added the enum and struct modifications as mentioned above. Listed below are some issues which we are unclear about: *1.* As mentioned on the project page, we need to create a *vector* *(SourcedName, DomRoot)* by iterating over *self.controls* me

Re: [dev-servo] Regarding missing DOM features project: Named getter implementation

Great question! I recommend representing it like: enum SourcedNameSource { Id, Name, Past(Duration) } struct SourcedName { name: String, element: DomRoot, source: SourcedNameSource, } This will allow you to access the values that are always present as named fields of th

Re: [dev-servo] Regarding missing DOM features project

Hi Chintan, I think I can help to answer some questions > How do we test the changes that we have made? Do we simply verify our changes by running this test: ./mach test-wpt tests/web-platform-tests/html/semantics/embedded-content/the-iframe-element/srcdoc_process_attributes.html or do we need to

Re: [dev-servo] Regarding missing DOM features project

Hello Josh, We are currently working on the *srcdoc iframe* issue and have made some changes to the files: *components/script_traits/lib.rs , components/script/dom/webidls/HTMLIFrameElement.webidl, components/script/script_thread.rs *as specified in the bul

Re: [dev-servo] Regarding missing DOM features project

Oh, I just looked at the project page and I could see why the descriptions of the missing DOM features might be lacking some description. The issue link for srcdoc iframes was to the wrong issue; sorry. I have updated the page to point at https://github.com/servo/servo/issues/4767 instead, whic

Re: [dev-servo] Regarding missing DOM features project

Welcome! Could you be more specific about what kind of clarification you're looking for? What parts of the project description page are unclear right now? Cheers, Josh On 10/16/19 2:13 PM, Chintan Gandhi wrote: Hello All, Greetings! We, Chintan Gandhi, Jay Modi and Anshul Jethvani are grad