Hi Chintan, I think I can help to answer some questions
> How do we test the changes that we have made? Do we simply verify our changes by running this test: ./mach test-wpt tests/web-platform-tests/html/semantics/embedded-content/the-iframe-element/srcdoc_process_attributes.html or do we need to build servo again? First of all, if you just clone the Servo repo and build it successfully, then run `./mach test-wpt` with the `srcdoc_process_attributes.html` test. You will see the test result says "TEST_END: Test TIMEOUT. Subtests passed 0/3. Unexpected 0". There are no subtests passed but there's no unexpected results. For wpt tests, there's a folder <https://github.com/servo/servo/tree/master/tests/wpt/metadata> to record current test status. For the srcdoc test, its metadata file is at tests/wpt/metadata/html/semantics/embedded-content/the-iframe-element/srcdoc_process_attributes.html.ini <https://github.com/servo/servo/blob/master/tests/wpt/metadata/html/semantics/embedded-content/the-iframe-element/srcdoc_process_attributes.html.ini> . So, if you implement the srcdoc correctly and try to run test-wpt with it, you should get unexpected PASS for the `srcdoc_process_attributes` test. and that's how you can verify your implementation is correct or not. > If we are building servo to test the changes, do we rebuild servo from scratch or only some specific crates? When you do any code change with the Servo codebase, you will need to build again to get a new executable Servo. But, if you've built the project before, it will not be rebuilt from scratch; instead, it will get the benefit of incremental compilation from Rust so it will only rebuild those parts you've changed. Hope I help you to understand the questions clearly 🙏 Cheers, CYBAI On Sun, Oct 27, 2019 at 5:51 AM Chintan Gandhi <cagan...@ncsu.edu> wrote: > Hello Josh, > > We are currently working on the *srcdoc iframe* issue and have made some > changes to the files: *components/script_traits/lib.rs > <http://lib.rs>, > components/script/dom/webidls/HTMLIFrameElement.webidl, > components/script/script_thread.rs > <http://script_thread.rs> *as specified in the bullet points 2, 3, 4, 5 of > the *initial steps* section on the project site. > > How do we test the changes that we have made? Do we simply verify our > changes by running this test: ./mach test-wpt > > tests/web-platform-tests/html/semantics/embedded-content/the-iframe-element/srcdoc_process_attributes.html > or > do we need to build servo again? > > If we are building servo to test the changes, do we rebuild servo > from scratch or only some specific crates? > > If anything else is required to be done or you need more information on our > work, kindly let us know. > > Thanking you. Hoping to hear from you soon. > > Regards > Chintan Gandhi > NC State University > > > On Wed, Oct 16, 2019 at 2:49 PM Josh Bowman-Matthews < > j...@joshmatthews.net> > wrote: > > > Oh, I just looked at the project page and I could see why the > > descriptions of the missing DOM features might be lacking some > > description. The issue link for srcdoc iframes was to the wrong issue; > > sorry. I have updated the page to point at > > https://github.com/servo/servo/issues/4767 instead, which contains some > > more helpful links to the specification and explanatory documents. > > > > As for named form getters, given an HTML document like: > > > > <form> > > <input id="name"> > > <input name="password" type="password"> > > </form> > > > > It is legal to write JS that does something like: > > > > let form = document.querySelector('form'); > > let the_name = form.name; > > let the_password = form.password; > > > > Even though the 'name' and 'password' members are not part of the > > HTMLFormElement interface > > (https://html.spec.whatwg.org/multipage/forms.html#the-form-element), > > the presence of a "named getter" in the interface describes how the web > > platform should interpret an arbitrary property name > > (https://html.spec.whatwg.org/multipage/forms.html#dom-form-nameditem). > > Our engine does not support this yet, so part of this project is > > designed to implement it. > > > > Cheers, > > Josh > > > > On 10/16/19 2:40 PM, Josh Bowman-Matthews wrote: > > > Welcome! Could you be more specific about what kind of clarification > > > you're looking for? What parts of the project description page are > > > unclear right now? > > > > > > Cheers, > > > Josh > > > > > > On 10/16/19 2:13 PM, Chintan Gandhi wrote: > > >> Hello All, > > >> > > >> Greetings! > > >> > > >> We, Chintan Gandhi, Jay Modi and Anshul Jethvani are grad students at > NC > > >> State University and will be working on the missing DOM features > > project. > > >> We would be following this web page > > >> https://github.com/servo/servo/wiki/Missing-DOM-features-project in > > order > > >> to move forward with the project. > > >> > > >> It would be really helpful if you could clarify the project definition > > >> and > > >> throw some more light on the DOM features missing in Servo. > > >> > > >> The steps that we plan to take are: > > >> 1. Build Servo on our machines using the guide mentioned on the above > > >> website. > > >> 2. Follow the initial and subsequent steps mentioned on the above > site. > > >> > > >> Looking forward to making useful contributions. > > >> > > >> Regards, > > >> Chintan Gandhi > > >> Jay Modi > > >> Anshul Jethvani > > >> NC State University > > >> > > > > > > > > _______________________________________________ > dev-servo mailing list > dev-servo@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-servo > _______________________________________________ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
