Re: [dev-servo] Question About the Merging Process

Yep! On Mon, Apr 29, 2019, 4:33 PM Maria Sable wrote: > Hi Manish, > > Thank you! By ping, do you mean @them in the pull request conversation? > > Kind regards, > Maria Sable > > On Mon, Apr 29, 2019 at 7:26 PM Manish Goregaokar > wrote: > > > The reviewer has to leave a comment saying `@bors-s

Re: [dev-servo] Question About the Merging Process

Hi Manish, Thank you! By ping, do you mean @them in the pull request conversation? Kind regards, Maria Sable On Mon, Apr 29, 2019 at 7:26 PM Manish Goregaokar wrote: > The reviewer has to leave a comment saying `@bors-servo r+` to inform our > bot that the pull request needs merging. Once that

Re: [dev-servo] Question About the Merging Process

The reviewer has to leave a comment saying `@bors-servo r+` to inform our bot that the pull request needs merging. Once that happens, you can wait. If you have an approving Github review but no r+, make sure you've addressed any straggling issues and ping the reviewer. -Manish Goregaokar On Mon